All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Chen-Yu Tsai <wens@kernel.org>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Vincent Donnefort <vdonnefort@gmail.com>,
	linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>
Subject: Re: [PATCH 2/3] rtc: pcf8563: Clear event flags and disable interrupts before requesting irq
Date: Thu, 20 Jun 2019 20:37:42 +0200	[thread overview]
Message-ID: <20190620183742.GD23549@piout.net> (raw)
In-Reply-To: <20190604042337.26129-3-wens@kernel.org>

On 04/06/2019 12:23:36+0800, Chen-Yu Tsai wrote:
> From: Chen-Yu Tsai <wens@csie.org>
> 
> Besides the alarm, the PCF8563 also has a timer triggered interrupt.
> In cases where the previous system left the timer and interrupts on,
> or somehow the bits got enabled, the interrupt would keep triggering
> as the kernel doesn't know about it.
> 
> Clear both the alarm and timer event flags, and disable the interrupts,
> before requesting the interrupt line.
> 
> Fixes: ede3e9d47cca ("drivers/rtc/rtc-pcf8563.c: add alarm support")
> Fixes: a45d528aab8b ("rtc: pcf8563: clear expired alarm at boot time")
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
>  drivers/rtc/rtc-pcf8563.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Chen-Yu Tsai <wens@kernel.org>
Cc: linux-rtc@vger.kernel.org,
	Alessandro Zummo <a.zummo@towertech.it>,
	devicetree@vger.kernel.org,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	linux-kernel@vger.kernel.org,
	Vincent Donnefort <vdonnefort@gmail.com>,
	Chen-Yu Tsai <wens@csie.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] rtc: pcf8563: Clear event flags and disable interrupts before requesting irq
Date: Thu, 20 Jun 2019 20:37:42 +0200	[thread overview]
Message-ID: <20190620183742.GD23549@piout.net> (raw)
In-Reply-To: <20190604042337.26129-3-wens@kernel.org>

On 04/06/2019 12:23:36+0800, Chen-Yu Tsai wrote:
> From: Chen-Yu Tsai <wens@csie.org>
> 
> Besides the alarm, the PCF8563 also has a timer triggered interrupt.
> In cases where the previous system left the timer and interrupts on,
> or somehow the bits got enabled, the interrupt would keep triggering
> as the kernel doesn't know about it.
> 
> Clear both the alarm and timer event flags, and disable the interrupts,
> before requesting the interrupt line.
> 
> Fixes: ede3e9d47cca ("drivers/rtc/rtc-pcf8563.c: add alarm support")
> Fixes: a45d528aab8b ("rtc: pcf8563: clear expired alarm at boot time")
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
>  drivers/rtc/rtc-pcf8563.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-06-20 18:37 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-04  4:23 [PATCH 0/3] rtc: pcf8563: Fix unhandled interrupt storm Chen-Yu Tsai
2019-06-04  4:23 ` Chen-Yu Tsai
2019-06-04  4:23 ` [PATCH 1/3] rtc: pcf8563: Fix interrupt trigger method Chen-Yu Tsai
2019-06-04  4:23   ` Chen-Yu Tsai
2019-06-04  4:23   ` Chen-Yu Tsai
2019-06-20 18:36   ` Alexandre Belloni
2019-06-20 18:36     ` Alexandre Belloni
2019-06-04  4:23 ` [PATCH 2/3] rtc: pcf8563: Clear event flags and disable interrupts before requesting irq Chen-Yu Tsai
2019-06-04  4:23   ` Chen-Yu Tsai
2019-06-20 18:37   ` Alexandre Belloni [this message]
2019-06-20 18:37     ` Alexandre Belloni
2019-06-04  4:23 ` [PATCH 3/3] arm64: dts: allwinner: h6: Pine H64: Add interrupt line for RTC Chen-Yu Tsai
2019-06-04  4:23   ` Chen-Yu Tsai
2019-06-20 16:22 ` [PATCH 0/3] rtc: pcf8563: Fix unhandled interrupt storm Alexandre Belloni
2019-06-20 16:22   ` Alexandre Belloni
2019-06-24 10:34   ` Chen-Yu Tsai
2019-06-24 10:34     ` Chen-Yu Tsai
2019-06-24 10:42     ` Alexandre Belloni
2019-06-24 10:42       ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190620183742.GD23549@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=a.zummo@towertech.it \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=maxime.ripard@bootlin.com \
    --cc=vdonnefort@gmail.com \
    --cc=wens@csie.org \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.