From: Greg KH <greg@kroah.com>
To: Juergen Gross <jgross@suse.com>
Cc: Prarit Bhargava <prarit@redhat.com>,
xen-devel@lists.xenproject.org,
Ben Hutchings <ben.hutchings@codethink.co.uk>,
stable <stable@vger.kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [Xen-devel] [stable] xen/pciback: Don't disable PCI_COMMAND on PCI device reset.
Date: Tue, 4 Jun 2019 07:48:09 +0200 [thread overview]
Message-ID: <20190604054809.GA16504@kroah.com> (raw)
In-Reply-To: <d3358f62-3e53-4468-782c-7b4466d34c0a@suse.com>
On Mon, Jun 03, 2019 at 03:10:55PM +0200, Juergen Gross wrote:
> On 03/06/2019 14:02, Ben Hutchings wrote:
> > On Mon, 2019-06-03 at 10:00 +0200, Greg KH wrote:
> >> On Thu, May 30, 2019 at 07:02:34PM -0700, Konrad Rzeszutek Wilk wrote:
> >>> On 5/30/19 8:16 AM, Ben Hutchings wrote:
> >>>> I'm looking at CVE-2015-8553 which is fixed by:
> >>>>
> >>>> commit 7681f31ec9cdacab4fd10570be924f2cef6669ba
> >>>> Author: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >>>> Date: Wed Feb 13 18:21:31 2019 -0500
> >>>>
> >>>> xen/pciback: Don't disable PCI_COMMAND on PCI device reset.
> >>>>
> >>>> I'm aware that this change is incompatible with qemu < 2.5, but that's
> >>>> now quite old. Do you think it makes sense to apply this change to
> >>>> some stable branches?
> >>>>
> >>>> Ben.
> >>>>
> >>>
> >>> Hey Ben,
> >>>
> >>> <shrugs> My opinion is to drop it, but if Juergen thinks it makes sense to
> >>> backport I am not going to argue.
> >>
> >> Ok, I've queued this up now, thanks.
> >
> > Juergen said:
> >
> >> I'm with Konrad here.
> >
> > so unless I'm very confused this should *not* be applied to stable
> > branches.
>
> "should not" is a little bit hard. I didn't opt for adding it, but I
> don't object to add it either (like Konrad :-) ).
Ok, I've added it as it does fix a CVE, and if I don't, I'll get odd
emails 6 months from now asking why I didn't include it...
thanks,
greg k-h
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Juergen Gross <jgross@suse.com>
Cc: Ben Hutchings <ben.hutchings@codethink.co.uk>,
Prarit Bhargava <prarit@redhat.com>,
xen-devel@lists.xenproject.org, stable <stable@vger.kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [stable] xen/pciback: Don't disable PCI_COMMAND on PCI device reset.
Date: Tue, 4 Jun 2019 07:48:09 +0200 [thread overview]
Message-ID: <20190604054809.GA16504@kroah.com> (raw)
In-Reply-To: <d3358f62-3e53-4468-782c-7b4466d34c0a@suse.com>
On Mon, Jun 03, 2019 at 03:10:55PM +0200, Juergen Gross wrote:
> On 03/06/2019 14:02, Ben Hutchings wrote:
> > On Mon, 2019-06-03 at 10:00 +0200, Greg KH wrote:
> >> On Thu, May 30, 2019 at 07:02:34PM -0700, Konrad Rzeszutek Wilk wrote:
> >>> On 5/30/19 8:16 AM, Ben Hutchings wrote:
> >>>> I'm looking at CVE-2015-8553 which is fixed by:
> >>>>
> >>>> commit 7681f31ec9cdacab4fd10570be924f2cef6669ba
> >>>> Author: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >>>> Date: Wed Feb 13 18:21:31 2019 -0500
> >>>>
> >>>> xen/pciback: Don't disable PCI_COMMAND on PCI device reset.
> >>>>
> >>>> I'm aware that this change is incompatible with qemu < 2.5, but that's
> >>>> now quite old. Do you think it makes sense to apply this change to
> >>>> some stable branches?
> >>>>
> >>>> Ben.
> >>>>
> >>>
> >>> Hey Ben,
> >>>
> >>> <shrugs> My opinion is to drop it, but if Juergen thinks it makes sense to
> >>> backport I am not going to argue.
> >>
> >> Ok, I've queued this up now, thanks.
> >
> > Juergen said:
> >
> >> I'm with Konrad here.
> >
> > so unless I'm very confused this should *not* be applied to stable
> > branches.
>
> "should not" is a little bit hard. I didn't opt for adding it, but I
> don't object to add it either (like Konrad :-) ).
Ok, I've added it as it does fix a CVE, and if I don't, I'll get odd
emails 6 months from now asking why I didn't include it...
thanks,
greg k-h
next prev parent reply other threads:[~2019-06-04 5:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 15:16 [Xen-devel] [stable] xen/pciback: Don't disable PCI_COMMAND on PCI device reset Ben Hutchings
2019-05-30 15:16 ` Ben Hutchings
2019-05-31 2:02 ` Konrad Rzeszutek Wilk
2019-05-31 2:02 ` Konrad Rzeszutek Wilk
2019-05-31 2:02 ` [Xen-devel] " Konrad Rzeszutek Wilk
2019-05-31 11:46 ` Juergen Gross
2019-05-31 11:46 ` [Xen-devel] " Juergen Gross
2019-05-31 11:46 ` Juergen Gross
2019-06-03 8:00 ` [Xen-devel] " Greg KH
2019-06-03 8:00 ` Greg KH
2019-06-03 12:02 ` Ben Hutchings
2019-06-03 12:02 ` [Xen-devel] " Ben Hutchings
2019-06-03 12:02 ` Ben Hutchings
2019-06-03 13:10 ` [Xen-devel] " Juergen Gross
2019-06-03 13:10 ` Juergen Gross
2019-06-04 5:48 ` Greg KH [this message]
2019-06-04 5:48 ` Greg KH
2019-06-04 5:48 ` Greg KH
2019-06-03 13:10 ` Juergen Gross
2019-06-03 8:00 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190604054809.GA16504@kroah.com \
--to=greg@kroah.com \
--cc=ben.hutchings@codethink.co.uk \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=prarit@redhat.com \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.