From: Eduardo Habkost <ehabkost@redhat.com>
To: Like Xu <like.xu@linux.intel.com>
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Alistair Francis <alistair23@gmail.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v3 07/10] hw/i386: Replace global smp variables with machine smp properties
Date: Wed, 5 Jun 2019 23:57:42 -0300 [thread overview]
Message-ID: <20190606025742.GP22416@habkost.net> (raw)
In-Reply-To: <20190518205428.90532-8-like.xu@linux.intel.com>
On Sun, May 19, 2019 at 04:54:25AM +0800, Like Xu wrote:
> The global smp variables in i386 are replaced with smp machine properties.
> To avoid calling qdev_get_machine() as much as possible, some related funtions
> for acpi data generations are refactored. No semantic changes.
>
> A local variable of the same name would be introduced in the declaration
> phase if it's used widely in the context OR replace it on the spot if it's
> only used once. No semantic changes.
>
> Signed-off-by: Like Xu <like.xu@linux.intel.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Habkost <ehabkost@redhat.com>
To: Like Xu <like.xu@linux.intel.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Alistair Francis <alistair23@gmail.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 07/10] hw/i386: Replace global smp variables with machine smp properties
Date: Wed, 5 Jun 2019 23:57:42 -0300 [thread overview]
Message-ID: <20190606025742.GP22416@habkost.net> (raw)
In-Reply-To: <20190518205428.90532-8-like.xu@linux.intel.com>
On Sun, May 19, 2019 at 04:54:25AM +0800, Like Xu wrote:
> The global smp variables in i386 are replaced with smp machine properties.
> To avoid calling qdev_get_machine() as much as possible, some related funtions
> for acpi data generations are refactored. No semantic changes.
>
> A local variable of the same name would be introduced in the declaration
> phase if it's used widely in the context OR replace it on the spot if it's
> only used once. No semantic changes.
>
> Signed-off-by: Like Xu <like.xu@linux.intel.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
next prev parent reply other threads:[~2019-06-06 2:58 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-18 20:54 [Qemu-trivial] [Qemu-devel] [PATCH v3 00/10] Refactor cpu topo into machine properties Like Xu
2019-05-18 20:54 ` Like Xu
2019-05-18 20:54 ` [Qemu-trivial] [Qemu-devel] [PATCH v3 01/10] hw/boards: Add struct CpuTopology to MachineState Like Xu
2019-05-18 20:54 ` Like Xu
2019-05-18 20:54 ` [Qemu-trivial] [Qemu-devel] [PATCH v3 02/10] machine: Refactor smp-related call chains to pass MachineState Like Xu
2019-05-18 20:54 ` Like Xu
2019-05-18 20:54 ` [Qemu-trivial] [Qemu-devel] [PATCH v3 03/10] general: Replace global smp variables with smp machine properties Like Xu
2019-05-18 20:54 ` Like Xu
2019-05-18 20:54 ` [Qemu-trivial] [Qemu-devel] [PATCH v3 04/10] hw/ppc: Replace global smp variables with machine smp properties Like Xu
2019-05-18 20:54 ` Like Xu
2019-06-06 2:52 ` [Qemu-trivial] " Eduardo Habkost
2019-06-06 2:52 ` Eduardo Habkost
2019-06-06 2:54 ` [Qemu-trivial] " Eduardo Habkost
2019-06-06 2:54 ` Eduardo Habkost
2019-06-06 3:07 ` [Qemu-trivial] " David Gibson
2019-06-06 3:07 ` David Gibson
2019-06-06 8:20 ` [Qemu-trivial] [Qemu-ppc] " Greg Kurz
2019-06-06 8:20 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2019-06-06 8:37 ` [Qemu-trivial] " Like Xu
2019-06-06 8:37 ` Like Xu
2019-05-18 20:54 ` [Qemu-trivial] [Qemu-devel] [PATCH v3 05/10] hw/riscv: " Like Xu
2019-05-18 20:54 ` Like Xu
2019-05-20 21:45 ` [Qemu-trivial] " Alistair Francis
2019-05-20 21:45 ` Alistair Francis
2019-06-20 14:52 ` [Qemu-trivial] " Eduardo Habkost
2019-06-20 14:52 ` Eduardo Habkost
2019-06-21 0:53 ` [Qemu-trivial] " Like Xu
2019-06-21 0:53 ` Like Xu
2019-05-18 20:54 ` [Qemu-trivial] [Qemu-devel] [PATCH v3 06/10] hw/s390x: " Like Xu
2019-05-18 20:54 ` Like Xu
2019-06-06 2:56 ` [Qemu-trivial] " Eduardo Habkost
2019-06-06 2:56 ` Eduardo Habkost
2019-06-06 7:07 ` [Qemu-trivial] [qemu-s390x] " Christian Borntraeger
2019-06-06 7:07 ` [Qemu-devel] [qemu-s390x] " Christian Borntraeger
2019-06-06 7:56 ` [Qemu-trivial] [Qemu-devel] " Cornelia Huck
2019-06-06 7:56 ` Cornelia Huck
2019-06-28 18:33 ` [Qemu-trivial] [PATCH] fixup! " Eduardo Habkost
2019-06-28 18:33 ` [Qemu-devel] " Eduardo Habkost
2019-06-28 23:04 ` [Qemu-trivial] " no-reply
2019-06-28 23:04 ` no-reply
2019-05-18 20:54 ` [Qemu-trivial] [Qemu-devel] [PATCH v3 07/10] hw/i386: " Like Xu
2019-05-18 20:54 ` Like Xu
2019-06-06 2:57 ` Eduardo Habkost [this message]
2019-06-06 2:57 ` Eduardo Habkost
2019-05-18 20:54 ` [Qemu-trivial] [Qemu-devel] [PATCH v3 08/10] hw/arm: " Like Xu
2019-05-18 20:54 ` Like Xu
2019-06-06 2:58 ` [Qemu-trivial] " Eduardo Habkost
2019-06-06 2:58 ` Eduardo Habkost
2019-06-06 2:58 ` [Qemu-arm] " Eduardo Habkost
2019-05-18 20:54 ` [Qemu-trivial] [Qemu-devel] [PATCH v3 09/10] hw: Replace global smp variables with MachineState for all remaining archs Like Xu
2019-05-18 20:54 ` Like Xu
2019-06-06 3:00 ` Eduardo Habkost
2019-05-18 20:54 ` [Qemu-trivial] [Qemu-devel] [PATCH v3 10/10] vl.c: Replace smp global variables with smp machine properties Like Xu
2019-05-18 20:54 ` Like Xu
2019-06-06 3:00 ` [Qemu-trivial] " Eduardo Habkost
2019-06-06 3:00 ` Eduardo Habkost
2019-05-26 13:51 ` [Qemu-trivial] [Qemu-devel] [PATCH v3 00/10] Refactor cpu topo into " Like Xu
2019-05-26 13:51 ` Like Xu
2019-05-29 0:37 ` Like Xu
2019-06-06 3:02 ` [Qemu-trivial] " Eduardo Habkost
2019-06-06 3:02 ` Eduardo Habkost
2019-06-07 21:25 ` [Qemu-trivial] " Eduardo Habkost
2019-06-07 21:25 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606025742.GP22416@habkost.net \
--to=ehabkost@redhat.com \
--cc=alistair23@gmail.com \
--cc=dgilbert@redhat.com \
--cc=imammedo@redhat.com \
--cc=like.xu@linux.intel.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.