All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Like Xu <like.xu@linux.intel.com>
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	Alistair Francis <alistair23@gmail.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Halil Pasic <pasic@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Richard Henderson <rth@twiddle.net>,
	David Hildenbrand <david@redhat.com>,
	qemu-s390x@nongnu.org
Subject: [Qemu-trivial] [PATCH] fixup! hw/s390x: Replace global smp variables with machine smp properties
Date: Fri, 28 Jun 2019 15:33:21 -0300	[thread overview]
Message-ID: <20190628183321.GE1862@habkost.net> (raw)
In-Reply-To: <20190518205428.90532-7-like.xu@linux.intel.com>

On Sun, May 19, 2019 at 04:54:24AM +0800, Like Xu wrote:
> The global smp variables in s390x are replaced with smp machine properties.
> 
> A local variable of the same name would be introduced in the declaration
> phase if it's used widely in the context OR replace it on the spot if it's
> only used once. No semantic changes.
> 
> Signed-off-by: Like Xu <like.xu@linux.intel.com>

I'm applying the following fixup to address s390x build failures
on machine-next.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 target/s390x/kvm.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
index 0267c6c2f6..6e814c230b 100644
--- a/target/s390x/kvm.c
+++ b/target/s390x/kvm.c
@@ -119,8 +119,8 @@
  * Needs to be big enough to contain max_cpus emergency signals
  * and in addition NR_LOCAL_IRQS interrupts
  */
-#define VCPU_IRQ_BUF_SIZE (sizeof(struct kvm_s390_irq) * \
-                           (max_cpus + NR_LOCAL_IRQS))
+#define VCPU_IRQ_BUF_SIZE(max_cpus) (sizeof(struct kvm_s390_irq) * \
+                                     (max_cpus + NR_LOCAL_IRQS))
 
 static CPUWatchpoint hw_watchpoint;
 /*
@@ -362,9 +362,10 @@ unsigned long kvm_arch_vcpu_id(CPUState *cpu)
 
 int kvm_arch_init_vcpu(CPUState *cs)
 {
+    unsigned int max_cpus = MACHINE(qdev_get_machine())->smp.max_cpus;
     S390CPU *cpu = S390_CPU(cs);
     kvm_s390_set_cpu_state(cpu, cpu->env.cpu_state);
-    cpu->irqstate = g_malloc0(VCPU_IRQ_BUF_SIZE);
+    cpu->irqstate = g_malloc0(VCPU_IRQ_BUF_SIZE(max_cpus));
     return 0;
 }
 
@@ -1950,9 +1951,10 @@ int kvm_s390_set_cpu_state(S390CPU *cpu, uint8_t cpu_state)
 
 void kvm_s390_vcpu_interrupt_pre_save(S390CPU *cpu)
 {
+    unsigned int max_cpus = MACHINE(qdev_get_machine())->smp.max_cpus;
     struct kvm_s390_irq_state irq_state = {
         .buf = (uint64_t) cpu->irqstate,
-        .len = VCPU_IRQ_BUF_SIZE,
+        .len = VCPU_IRQ_BUF_SIZE(max_cpus),
     };
     CPUState *cs = CPU(cpu);
     int32_t bytes;
-- 
2.18.0.rc1.1.g3f1ff2140

-- 
Eduardo


WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Habkost <ehabkost@redhat.com>
To: Like Xu <like.xu@linux.intel.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	David Hildenbrand <david@redhat.com>,
	qemu-trivial@nongnu.org, Cornelia Huck <cohuck@redhat.com>,
	qemu-devel@nongnu.org,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	Halil Pasic <pasic@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	qemu-s390x@nongnu.org, Alistair Francis <alistair23@gmail.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH] fixup! hw/s390x: Replace global smp variables with machine smp properties
Date: Fri, 28 Jun 2019 15:33:21 -0300	[thread overview]
Message-ID: <20190628183321.GE1862@habkost.net> (raw)
In-Reply-To: <20190518205428.90532-7-like.xu@linux.intel.com>

On Sun, May 19, 2019 at 04:54:24AM +0800, Like Xu wrote:
> The global smp variables in s390x are replaced with smp machine properties.
> 
> A local variable of the same name would be introduced in the declaration
> phase if it's used widely in the context OR replace it on the spot if it's
> only used once. No semantic changes.
> 
> Signed-off-by: Like Xu <like.xu@linux.intel.com>

I'm applying the following fixup to address s390x build failures
on machine-next.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 target/s390x/kvm.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
index 0267c6c2f6..6e814c230b 100644
--- a/target/s390x/kvm.c
+++ b/target/s390x/kvm.c
@@ -119,8 +119,8 @@
  * Needs to be big enough to contain max_cpus emergency signals
  * and in addition NR_LOCAL_IRQS interrupts
  */
-#define VCPU_IRQ_BUF_SIZE (sizeof(struct kvm_s390_irq) * \
-                           (max_cpus + NR_LOCAL_IRQS))
+#define VCPU_IRQ_BUF_SIZE(max_cpus) (sizeof(struct kvm_s390_irq) * \
+                                     (max_cpus + NR_LOCAL_IRQS))
 
 static CPUWatchpoint hw_watchpoint;
 /*
@@ -362,9 +362,10 @@ unsigned long kvm_arch_vcpu_id(CPUState *cpu)
 
 int kvm_arch_init_vcpu(CPUState *cs)
 {
+    unsigned int max_cpus = MACHINE(qdev_get_machine())->smp.max_cpus;
     S390CPU *cpu = S390_CPU(cs);
     kvm_s390_set_cpu_state(cpu, cpu->env.cpu_state);
-    cpu->irqstate = g_malloc0(VCPU_IRQ_BUF_SIZE);
+    cpu->irqstate = g_malloc0(VCPU_IRQ_BUF_SIZE(max_cpus));
     return 0;
 }
 
@@ -1950,9 +1951,10 @@ int kvm_s390_set_cpu_state(S390CPU *cpu, uint8_t cpu_state)
 
 void kvm_s390_vcpu_interrupt_pre_save(S390CPU *cpu)
 {
+    unsigned int max_cpus = MACHINE(qdev_get_machine())->smp.max_cpus;
     struct kvm_s390_irq_state irq_state = {
         .buf = (uint64_t) cpu->irqstate,
-        .len = VCPU_IRQ_BUF_SIZE,
+        .len = VCPU_IRQ_BUF_SIZE(max_cpus),
     };
     CPUState *cs = CPU(cpu);
     int32_t bytes;
-- 
2.18.0.rc1.1.g3f1ff2140

-- 
Eduardo


  parent reply	other threads:[~2019-06-28 18:33 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-18 20:54 [Qemu-trivial] [Qemu-devel] [PATCH v3 00/10] Refactor cpu topo into machine properties Like Xu
2019-05-18 20:54 ` Like Xu
2019-05-18 20:54 ` [Qemu-trivial] [Qemu-devel] [PATCH v3 01/10] hw/boards: Add struct CpuTopology to MachineState Like Xu
2019-05-18 20:54   ` Like Xu
2019-05-18 20:54 ` [Qemu-trivial] [Qemu-devel] [PATCH v3 02/10] machine: Refactor smp-related call chains to pass MachineState Like Xu
2019-05-18 20:54   ` Like Xu
2019-05-18 20:54 ` [Qemu-trivial] [Qemu-devel] [PATCH v3 03/10] general: Replace global smp variables with smp machine properties Like Xu
2019-05-18 20:54   ` Like Xu
2019-05-18 20:54 ` [Qemu-trivial] [Qemu-devel] [PATCH v3 04/10] hw/ppc: Replace global smp variables with machine smp properties Like Xu
2019-05-18 20:54   ` Like Xu
2019-06-06  2:52   ` [Qemu-trivial] " Eduardo Habkost
2019-06-06  2:52     ` Eduardo Habkost
2019-06-06  2:54     ` [Qemu-trivial] " Eduardo Habkost
2019-06-06  2:54       ` Eduardo Habkost
2019-06-06  3:07       ` [Qemu-trivial] " David Gibson
2019-06-06  3:07         ` David Gibson
2019-06-06  8:20         ` [Qemu-trivial] [Qemu-ppc] " Greg Kurz
2019-06-06  8:20           ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2019-06-06  8:37           ` [Qemu-trivial] " Like Xu
2019-06-06  8:37             ` Like Xu
2019-05-18 20:54 ` [Qemu-trivial] [Qemu-devel] [PATCH v3 05/10] hw/riscv: " Like Xu
2019-05-18 20:54   ` Like Xu
2019-05-20 21:45   ` [Qemu-trivial] " Alistair Francis
2019-05-20 21:45     ` Alistair Francis
2019-06-20 14:52   ` [Qemu-trivial] " Eduardo Habkost
2019-06-20 14:52     ` Eduardo Habkost
2019-06-21  0:53     ` [Qemu-trivial] " Like Xu
2019-06-21  0:53       ` Like Xu
2019-05-18 20:54 ` [Qemu-trivial] [Qemu-devel] [PATCH v3 06/10] hw/s390x: " Like Xu
2019-05-18 20:54   ` Like Xu
2019-06-06  2:56   ` [Qemu-trivial] " Eduardo Habkost
2019-06-06  2:56     ` Eduardo Habkost
2019-06-06  7:07     ` [Qemu-trivial] [qemu-s390x] " Christian Borntraeger
2019-06-06  7:07       ` [Qemu-devel] [qemu-s390x] " Christian Borntraeger
2019-06-06  7:56     ` [Qemu-trivial] [Qemu-devel] " Cornelia Huck
2019-06-06  7:56       ` Cornelia Huck
2019-06-28 18:33   ` Eduardo Habkost [this message]
2019-06-28 18:33     ` [Qemu-devel] [PATCH] fixup! " Eduardo Habkost
2019-06-28 23:04     ` [Qemu-trivial] " no-reply
2019-06-28 23:04       ` no-reply
2019-05-18 20:54 ` [Qemu-trivial] [Qemu-devel] [PATCH v3 07/10] hw/i386: " Like Xu
2019-05-18 20:54   ` Like Xu
2019-06-06  2:57   ` [Qemu-trivial] " Eduardo Habkost
2019-06-06  2:57     ` Eduardo Habkost
2019-05-18 20:54 ` [Qemu-trivial] [Qemu-devel] [PATCH v3 08/10] hw/arm: " Like Xu
2019-05-18 20:54   ` Like Xu
2019-06-06  2:58   ` [Qemu-trivial] " Eduardo Habkost
2019-06-06  2:58     ` Eduardo Habkost
2019-06-06  2:58     ` [Qemu-arm] " Eduardo Habkost
2019-05-18 20:54 ` [Qemu-trivial] [Qemu-devel] [PATCH v3 09/10] hw: Replace global smp variables with MachineState for all remaining archs Like Xu
2019-05-18 20:54   ` Like Xu
2019-06-06  3:00   ` Eduardo Habkost
2019-05-18 20:54 ` [Qemu-trivial] [Qemu-devel] [PATCH v3 10/10] vl.c: Replace smp global variables with smp machine properties Like Xu
2019-05-18 20:54   ` Like Xu
2019-06-06  3:00   ` [Qemu-trivial] " Eduardo Habkost
2019-06-06  3:00     ` Eduardo Habkost
2019-05-26 13:51 ` [Qemu-trivial] [Qemu-devel] [PATCH v3 00/10] Refactor cpu topo into " Like Xu
2019-05-26 13:51   ` Like Xu
2019-05-29  0:37   ` Like Xu
2019-06-06  3:02 ` [Qemu-trivial] " Eduardo Habkost
2019-06-06  3:02   ` Eduardo Habkost
2019-06-07 21:25 ` [Qemu-trivial] " Eduardo Habkost
2019-06-07 21:25   ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190628183321.GE1862@habkost.net \
    --to=ehabkost@redhat.com \
    --cc=alistair23@gmail.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=like.xu@linux.intel.com \
    --cc=pasic@linux.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.