From: Greg KH <gregkh@linuxfoundation.org>
To: Dragan Cvetic <draganc@xilinx.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Michal Simek <michals@xilinx.com>,
Derek Kiernan <dkiernan@xilinx.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V4 02/12] misc: xilinx-sdfec: add core driver
Date: Thu, 6 Jun 2019 21:04:06 +0200 [thread overview]
Message-ID: <20190606190406.GA20166@kroah.com> (raw)
In-Reply-To: <CH2PR02MB63592DAB5E23A35C86F81D09CB170@CH2PR02MB6359.namprd02.prod.outlook.com>
On Thu, Jun 06, 2019 at 06:16:48PM +0000, Dragan Cvetic wrote:
> >
> > > +
> > > + misc_deregister(&xsdfec->miscdev);
> > > + atomic_dec(&xsdfec_ndevs);
> > > + return 0;
> >
> > You free nothing?
> >
> > You are leaking resources like crazy here, this is not ok at all.
>
> The managed resources are used.
> Anyway, I'll test for memory leak and search for the answer.
Oops, no, you are right, I missed the "devm" prefix on those calls. My
fault.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Dragan Cvetic <draganc@xilinx.com>
Cc: "arnd@arndb.de" <arnd@arndb.de>,
Michal Simek <michals@xilinx.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Derek Kiernan <dkiernan@xilinx.com>
Subject: Re: [PATCH V4 02/12] misc: xilinx-sdfec: add core driver
Date: Thu, 6 Jun 2019 21:04:06 +0200 [thread overview]
Message-ID: <20190606190406.GA20166@kroah.com> (raw)
In-Reply-To: <CH2PR02MB63592DAB5E23A35C86F81D09CB170@CH2PR02MB6359.namprd02.prod.outlook.com>
On Thu, Jun 06, 2019 at 06:16:48PM +0000, Dragan Cvetic wrote:
> >
> > > +
> > > + misc_deregister(&xsdfec->miscdev);
> > > + atomic_dec(&xsdfec_ndevs);
> > > + return 0;
> >
> > You free nothing?
> >
> > You are leaking resources like crazy here, this is not ok at all.
>
> The managed resources are used.
> Anyway, I'll test for memory leak and search for the answer.
Oops, no, you are right, I missed the "devm" prefix on those calls. My
fault.
thanks,
greg k-h
next prev parent reply other threads:[~2019-06-06 19:04 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-25 11:37 [PATCH V4 00/12] misc: xilinx sd-fec drive Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-05-25 11:37 ` [PATCH V4 01/12] dt-bindings: xilinx-sdfec: Add SDFEC binding Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-05-25 11:37 ` [PATCH V4 02/12] misc: xilinx-sdfec: add core driver Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-06-06 13:25 ` Greg KH
2019-06-06 13:25 ` Greg KH
2019-06-06 18:16 ` Dragan Cvetic
2019-06-06 18:16 ` Dragan Cvetic
2019-06-06 19:04 ` Greg KH [this message]
2019-06-06 19:04 ` Greg KH
2019-05-25 11:37 ` [PATCH V4 03/12] misc: xilinx_sdfec: Add CCF support Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-05-25 11:37 ` [PATCH V4 04/12] misc: xilinx_sdfec: Add open, close and ioctl Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-06-06 13:26 ` Greg KH
2019-06-06 13:26 ` Greg KH
2019-06-06 18:18 ` Dragan Cvetic
2019-06-06 18:18 ` Dragan Cvetic
2019-06-06 13:28 ` Greg KH
2019-06-06 13:28 ` Greg KH
2019-06-06 18:22 ` Dragan Cvetic
2019-06-06 18:22 ` Dragan Cvetic
2019-06-07 10:58 ` Dragan Cvetic
2019-06-07 10:58 ` Dragan Cvetic
2019-06-07 15:57 ` Greg KH
2019-06-07 15:57 ` Greg KH
2019-06-08 19:40 ` Dragan Cvetic
2019-06-08 19:40 ` Dragan Cvetic
2019-06-08 19:40 ` Dragan Cvetic
2019-05-25 11:37 ` [PATCH V4 05/12] misc: xilinx_sdfec: Store driver config and state Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-05-25 11:37 ` [PATCH V4 06/12] misc: xilinx_sdfec: Add ability to configure turbo Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-05-25 11:37 ` [PATCH V4 07/12] misc: xilinx_sdfec: Add ability to configure LDPC Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-05-25 11:37 ` [PATCH V4 08/12] misc: xilinx_sdfec: Add ability to get/set config Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-05-25 11:37 ` [PATCH V4 09/12] misc: xilinx_sdfec: Support poll file operation Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-05-25 11:37 ` [PATCH V4 10/12] misc: xilinx_sdfec: Add stats & status ioctls Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-06-06 14:11 ` Greg KH
2019-06-06 14:11 ` Greg KH
2019-06-06 18:27 ` Dragan Cvetic
2019-06-06 18:27 ` Dragan Cvetic
2019-05-25 11:37 ` [PATCH V4 11/12] Docs: misc: xilinx_sdfec: Add documentation Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-05-25 11:37 ` [PATCH V4 12/12] MAINTAINERS: add maintainer for SD-FEC Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
2019-05-25 11:37 ` Dragan Cvetic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606190406.GA20166@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=dkiernan@xilinx.com \
--cc=draganc@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michals@xilinx.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.