All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
To: Alex Deucher <alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "Charlene Liu" <charlene.liu-5C7GfCeVMHo@public.gmane.org>,
	"Hariprasad Kelam"
	<hariprasad.kelam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Dmytro Laktyushkin"
	<Dmytro.Laktyushkin-5C7GfCeVMHo@public.gmane.org>,
	"Christian König" <christian.koenig-5C7GfCeVMHo@public.gmane.org>,
	"Leo Li" <sunpeng.li-5C7GfCeVMHo@public.gmane.org>,
	"Tony Cheng" <tony.cheng-5C7GfCeVMHo@public.gmane.org>,
	LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"amd-gfx list"
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	"Gloria Li" <geling.li-5C7GfCeVMHo@public.gmane.org>,
	"David Airlie" <airlied-cv59FeDIM0c@public.gmane.org>,
	"Yongqiang Sun" <yongqiang.sun-5C7GfCeVMHo@public.gmane.org>,
	"Maling list - DRI developers"
	<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	"Alex Deucher" <alexander.deucher-5C7GfCeVMHo@public.gmane.org>,
	"Bhawanpreet Lakha"
	<Bhawanpreet.Lakha-5C7GfCeVMHo@public.gmane.org>,
	"Nicholas Kazlauskas"
	<nicholas.kazlauskas-5C7GfCeVMHo@public.gmane.org>,
	"Anthony Koo" <Anthony.Koo-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH] drm/amd/display: fix compilation error
Date: Thu, 13 Jun 2019 20:42:17 +0200	[thread overview]
Message-ID: <20190613184217.GA2385@ravnborg.org> (raw)
In-Reply-To: <CADnq5_PU_jvOskC-=+oRQdvYXZvu_n26ogoWTxLRxnW+ke4wDw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hi Alex.

On Wed, Jun 12, 2019 at 10:35:26PM -0400, Alex Deucher wrote:
> On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam
> <hariprasad.kelam@gmail.com> wrote:
> >
> > this patch fixes below compilation error
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In
> > function ‘dcn10_apply_ctx_for_surface’:
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:
> > error: implicit declaration of function ‘udelay’
> > [-Werror=implicit-function-declaration]
> >    udelay(underflow_check_delay_us);
> >
> > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>

Am I right in assuming you took this patch?

I expect that new code using udelay was added to the amd tree,
and when merged with drm-misc-next it failed, because drm-misc-next no
longer had drmP.h included so no implicit include of delay.h

The root cause was that my original patchset should have been based
on the amd tree, and applied there :-(

	Sam
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: "Hariprasad Kelam" <hariprasad.kelam@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Yongqiang Sun" <yongqiang.sun@amd.com>,
	"Charlene Liu" <charlene.liu@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Bhawanpreet Lakha" <Bhawanpreet.Lakha@amd.com>,
	"Gloria Li" <geling.li@amd.com>,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	"Nicholas Kazlauskas" <nicholas.kazlauskas@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"Dmytro Laktyushkin" <Dmytro.Laktyushkin@amd.com>,
	"Tony Cheng" <tony.cheng@amd.com>,
	"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Anthony Koo" <Anthony.Koo@amd.com>
Subject: Re: [PATCH] drm/amd/display: fix compilation error
Date: Thu, 13 Jun 2019 20:42:17 +0200	[thread overview]
Message-ID: <20190613184217.GA2385@ravnborg.org> (raw)
In-Reply-To: <CADnq5_PU_jvOskC-=+oRQdvYXZvu_n26ogoWTxLRxnW+ke4wDw@mail.gmail.com>

Hi Alex.

On Wed, Jun 12, 2019 at 10:35:26PM -0400, Alex Deucher wrote:
> On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam
> <hariprasad.kelam@gmail.com> wrote:
> >
> > this patch fixes below compilation error
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In
> > function ‘dcn10_apply_ctx_for_surface’:
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:
> > error: implicit declaration of function ‘udelay’
> > [-Werror=implicit-function-declaration]
> >    udelay(underflow_check_delay_us);
> >
> > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>

Am I right in assuming you took this patch?

I expect that new code using udelay was added to the amd tree,
and when merged with drm-misc-next it failed, because drm-misc-next no
longer had drmP.h included so no implicit include of delay.h

The root cause was that my original patchset should have been based
on the amd tree, and applied there :-(

	Sam

  parent reply	other threads:[~2019-06-13 18:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-13  2:32 [PATCH] drm/amd/display: fix compilation error Hariprasad Kelam
2019-06-13  2:32 ` Hariprasad Kelam
2019-06-13  2:35 ` Alex Deucher
2019-06-13  2:35   ` Alex Deucher
     [not found]   ` <CADnq5_PU_jvOskC-=+oRQdvYXZvu_n26ogoWTxLRxnW+ke4wDw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-06-13  2:48     ` Hariprasad Kelam
2019-06-13  2:48       ` Hariprasad Kelam
2019-06-13  8:23       ` Daniel Vetter
2019-06-13  8:23         ` Daniel Vetter
2019-06-13 18:42     ` Sam Ravnborg [this message]
2019-06-13 18:42       ` Sam Ravnborg
2019-06-13 18:52       ` Alex Deucher
  -- strict thread matches above, loose matches on Subject: below --
2020-10-02 23:56 [PATCH] drm/amd/display: [FIX] Compilation error Qingqing Zhuo
2020-10-02 23:56 ` Qingqing Zhuo
2020-10-03  1:11 ` Stephen Rothwell
2020-10-03  1:11   ` Stephen Rothwell
2020-10-03  0:16 Qingqing Zhuo
2020-10-03  0:16 ` Qingqing Zhuo
2020-10-05 15:27 ` Rodrigo Siqueira
2020-10-05 15:27   ` Rodrigo Siqueira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190613184217.GA2385@ravnborg.org \
    --to=sam-uyr5n9q2vtjg9huczpvpmw@public.gmane.org \
    --cc=Anthony.Koo-5C7GfCeVMHo@public.gmane.org \
    --cc=Bhawanpreet.Lakha-5C7GfCeVMHo@public.gmane.org \
    --cc=Dmytro.Laktyushkin-5C7GfCeVMHo@public.gmane.org \
    --cc=airlied-cv59FeDIM0c@public.gmane.org \
    --cc=alexander.deucher-5C7GfCeVMHo@public.gmane.org \
    --cc=alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=charlene.liu-5C7GfCeVMHo@public.gmane.org \
    --cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=geling.li-5C7GfCeVMHo@public.gmane.org \
    --cc=hariprasad.kelam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=nicholas.kazlauskas-5C7GfCeVMHo@public.gmane.org \
    --cc=sunpeng.li-5C7GfCeVMHo@public.gmane.org \
    --cc=tony.cheng-5C7GfCeVMHo@public.gmane.org \
    --cc=yongqiang.sun-5C7GfCeVMHo@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.