* [PATCH] drm/amd/display: fix compilation error
@ 2019-06-13 2:32 ` Hariprasad Kelam
0 siblings, 0 replies; 19+ messages in thread
From: Hariprasad Kelam @ 2019-06-13 2:32 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Alex Deucher, Christian König,
David (ChunMing) Zhou, David Airlie, Daniel Vetter,
Dmytro Laktyushkin, Bhawanpreet Lakha, Tony Cheng, Anthony Koo,
Charlene Liu, Nicholas Kazlauskas, Yongqiang Sun, Gloria Li,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
this patch fixes below compilation error
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In
function ‘dcn10_apply_ctx_for_surface’:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:
error: implicit declaration of function ‘udelay’
[-Werror=implicit-function-declaration]
udelay(underflow_check_delay_us);
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
index d2352949..1ac9a4f 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
@@ -23,6 +23,7 @@
*
*/
+#include <linux/delay.h>
#include "dm_services.h"
#include "core_types.h"
#include "resource.h"
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH] drm/amd/display: fix compilation error
@ 2019-06-13 2:32 ` Hariprasad Kelam
0 siblings, 0 replies; 19+ messages in thread
From: Hariprasad Kelam @ 2019-06-13 2:32 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Alex Deucher, Christian König,
David (ChunMing) Zhou, David Airlie, Daniel Vetter,
Dmytro Laktyushkin, Bhawanpreet Lakha, Tony Cheng, Anthony Koo,
Charlene Liu, Nicholas Kazlauskas, Yongqiang Sun, Gloria Li,
amd-gfx, dri-devel, linux-kernel
this patch fixes below compilation error
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In
function ‘dcn10_apply_ctx_for_surface’:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:
error: implicit declaration of function ‘udelay’
[-Werror=implicit-function-declaration]
udelay(underflow_check_delay_us);
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
index d2352949..1ac9a4f 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
@@ -23,6 +23,7 @@
*
*/
+#include <linux/delay.h>
#include "dm_services.h"
#include "core_types.h"
#include "resource.h"
--
2.7.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH] drm/amd/display: fix compilation error
2019-06-13 2:32 ` Hariprasad Kelam
@ 2019-06-13 2:35 ` Alex Deucher
-1 siblings, 0 replies; 19+ messages in thread
From: Alex Deucher @ 2019-06-13 2:35 UTC (permalink / raw)
To: Hariprasad Kelam
Cc: LKML, Yongqiang Sun, Charlene Liu, Leo Li, Bhawanpreet Lakha,
Gloria Li, amd-gfx list, Nicholas Kazlauskas, David Airlie,
Dmytro Laktyushkin, Tony Cheng, Maling list - DRI developers,
Alex Deucher, Christian König, Anthony Koo
On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam
<hariprasad.kelam@gmail.com> wrote:
>
> this patch fixes below compilation error
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In
> function ‘dcn10_apply_ctx_for_surface’:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:
> error: implicit declaration of function ‘udelay’
> [-Werror=implicit-function-declaration]
> udelay(underflow_check_delay_us);
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
What branch is this patch based on?
Alex
> ---
> drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> index d2352949..1ac9a4f 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> @@ -23,6 +23,7 @@
> *
> */
>
> +#include <linux/delay.h>
> #include "dm_services.h"
> #include "core_types.h"
> #include "resource.h"
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] drm/amd/display: fix compilation error
@ 2019-06-13 2:35 ` Alex Deucher
0 siblings, 0 replies; 19+ messages in thread
From: Alex Deucher @ 2019-06-13 2:35 UTC (permalink / raw)
To: Hariprasad Kelam
Cc: Harry Wentland, Leo Li, Alex Deucher, Christian König,
David (ChunMing) Zhou, David Airlie, Daniel Vetter,
Dmytro Laktyushkin, Bhawanpreet Lakha, Tony Cheng, Anthony Koo,
Charlene Liu, Nicholas Kazlauskas, Yongqiang Sun, Gloria Li,
amd-gfx list, Maling list - DRI developers, LKML
On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam
<hariprasad.kelam@gmail.com> wrote:
>
> this patch fixes below compilation error
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In
> function ‘dcn10_apply_ctx_for_surface’:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:
> error: implicit declaration of function ‘udelay’
> [-Werror=implicit-function-declaration]
> udelay(underflow_check_delay_us);
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
What branch is this patch based on?
Alex
> ---
> drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> index d2352949..1ac9a4f 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> @@ -23,6 +23,7 @@
> *
> */
>
> +#include <linux/delay.h>
> #include "dm_services.h"
> #include "core_types.h"
> #include "resource.h"
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
[parent not found: <CADnq5_PU_jvOskC-=+oRQdvYXZvu_n26ogoWTxLRxnW+ke4wDw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] drm/amd/display: fix compilation error
2019-06-13 2:35 ` Alex Deucher
@ 2019-06-13 2:48 ` Hariprasad Kelam
-1 siblings, 0 replies; 19+ messages in thread
From: Hariprasad Kelam @ 2019-06-13 2:48 UTC (permalink / raw)
To: Alex Deucher, Harry Wentland, Leo Li, Alex Deucher,
Christian König, David (ChunMing) Zhou, David Airlie,
Daniel Vetter, Dmytro Laktyushkin, Bhawanpreet Lakha, Tony Cheng,
Anthony Koo, Charlene Liu, Nicholas Kazlauskas, Yongqiang Sun,
Gloria Li, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Wed, Jun 12, 2019 at 10:35:26PM -0400, Alex Deucher wrote:
> On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam
> <hariprasad.kelam@gmail.com> wrote:
> >
> > this patch fixes below compilation error
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In
> > function ‘dcn10_apply_ctx_for_surface’:
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:
> > error: implicit declaration of function ‘udelay’
> > [-Werror=implicit-function-declaration]
> > udelay(underflow_check_delay_us);
> >
> > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
>
> What branch is this patch based on?
>
> Alex
Hi Alex,
It is on linux-next
Thanks,
Hariprasad k
> > ---
> > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > index d2352949..1ac9a4f 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > @@ -23,6 +23,7 @@
> > *
> > */
> >
> > +#include <linux/delay.h>
> > #include "dm_services.h"
> > #include "core_types.h"
> > #include "resource.h"
> > --
> > 2.7.4
> >
> > _______________________________________________
> > amd-gfx mailing list
> > amd-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] drm/amd/display: fix compilation error
@ 2019-06-13 2:48 ` Hariprasad Kelam
0 siblings, 0 replies; 19+ messages in thread
From: Hariprasad Kelam @ 2019-06-13 2:48 UTC (permalink / raw)
To: Alex Deucher, Harry Wentland, Leo Li, Alex Deucher,
Christian König, David (ChunMing) Zhou, David Airlie,
Daniel Vetter, Dmytro Laktyushkin, Bhawanpreet Lakha, Tony Cheng,
Anthony Koo, Charlene Liu, Nicholas Kazlauskas, Yongqiang Sun,
Gloria Li, amd-gfx, dri-devel, linux-kernel
On Wed, Jun 12, 2019 at 10:35:26PM -0400, Alex Deucher wrote:
> On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam
> <hariprasad.kelam@gmail.com> wrote:
> >
> > this patch fixes below compilation error
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In
> > function ‘dcn10_apply_ctx_for_surface’:
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:
> > error: implicit declaration of function ‘udelay’
> > [-Werror=implicit-function-declaration]
> > udelay(underflow_check_delay_us);
> >
> > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
>
> What branch is this patch based on?
>
> Alex
Hi Alex,
It is on linux-next
Thanks,
Hariprasad k
> > ---
> > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > index d2352949..1ac9a4f 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > @@ -23,6 +23,7 @@
> > *
> > */
> >
> > +#include <linux/delay.h>
> > #include "dm_services.h"
> > #include "core_types.h"
> > #include "resource.h"
> > --
> > 2.7.4
> >
> > _______________________________________________
> > amd-gfx mailing list
> > amd-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] drm/amd/display: fix compilation error
2019-06-13 2:48 ` Hariprasad Kelam
@ 2019-06-13 8:23 ` Daniel Vetter
-1 siblings, 0 replies; 19+ messages in thread
From: Daniel Vetter @ 2019-06-13 8:23 UTC (permalink / raw)
To: Hariprasad Kelam
Cc: linux-kernel, Yongqiang Sun, Charlene Liu, Leo Li,
Bhawanpreet Lakha, David Airlie, Gloria Li, amd-gfx,
Nicholas Kazlauskas, Alex Deucher, Dmytro Laktyushkin, Tony Cheng,
dri-devel, Christian König, Anthony Koo
On Thu, Jun 13, 2019 at 08:18:54AM +0530, Hariprasad Kelam wrote:
> On Wed, Jun 12, 2019 at 10:35:26PM -0400, Alex Deucher wrote:
> > On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam
> > <hariprasad.kelam@gmail.com> wrote:
> > >
> > > this patch fixes below compilation error
> > >
> > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In
> > > function ‘dcn10_apply_ctx_for_surface’:
> > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:
> > > error: implicit declaration of function ‘udelay’
> > > [-Werror=implicit-function-declaration]
> > > udelay(underflow_check_delay_us);
> > >
> > > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> >
> > What branch is this patch based on?
> >
> > Alex
>
> Hi Alex,
>
> It is on linux-next
drm-misc-next has Sam's header cleanup. I guess we pull linux/delay.h in
implicitly somewhere, but not for all configs.
-Daniel
>
> Thanks,
> Hariprasad k
> > > ---
> > > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > > index d2352949..1ac9a4f 100644
> > > --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > > +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > > @@ -23,6 +23,7 @@
> > > *
> > > */
> > >
> > > +#include <linux/delay.h>
> > > #include "dm_services.h"
> > > #include "core_types.h"
> > > #include "resource.h"
> > > --
> > > 2.7.4
> > >
> > > _______________________________________________
> > > amd-gfx mailing list
> > > amd-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] drm/amd/display: fix compilation error
@ 2019-06-13 8:23 ` Daniel Vetter
0 siblings, 0 replies; 19+ messages in thread
From: Daniel Vetter @ 2019-06-13 8:23 UTC (permalink / raw)
To: Hariprasad Kelam
Cc: Alex Deucher, Harry Wentland, Leo Li, Alex Deucher,
Christian König, David (ChunMing) Zhou, David Airlie,
Daniel Vetter, Dmytro Laktyushkin, Bhawanpreet Lakha, Tony Cheng,
Anthony Koo, Charlene Liu, Nicholas Kazlauskas, Yongqiang Sun,
Gloria Li, amd-gfx, dri-devel, linux-kernel
On Thu, Jun 13, 2019 at 08:18:54AM +0530, Hariprasad Kelam wrote:
> On Wed, Jun 12, 2019 at 10:35:26PM -0400, Alex Deucher wrote:
> > On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam
> > <hariprasad.kelam@gmail.com> wrote:
> > >
> > > this patch fixes below compilation error
> > >
> > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In
> > > function ‘dcn10_apply_ctx_for_surface’:
> > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:
> > > error: implicit declaration of function ‘udelay’
> > > [-Werror=implicit-function-declaration]
> > > udelay(underflow_check_delay_us);
> > >
> > > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> >
> > What branch is this patch based on?
> >
> > Alex
>
> Hi Alex,
>
> It is on linux-next
drm-misc-next has Sam's header cleanup. I guess we pull linux/delay.h in
implicitly somewhere, but not for all configs.
-Daniel
>
> Thanks,
> Hariprasad k
> > > ---
> > > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > > index d2352949..1ac9a4f 100644
> > > --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > > +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > > @@ -23,6 +23,7 @@
> > > *
> > > */
> > >
> > > +#include <linux/delay.h>
> > > #include "dm_services.h"
> > > #include "core_types.h"
> > > #include "resource.h"
> > > --
> > > 2.7.4
> > >
> > > _______________________________________________
> > > amd-gfx mailing list
> > > amd-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] drm/amd/display: fix compilation error
2019-06-13 2:35 ` Alex Deucher
@ 2019-06-13 18:42 ` Sam Ravnborg
-1 siblings, 0 replies; 19+ messages in thread
From: Sam Ravnborg @ 2019-06-13 18:42 UTC (permalink / raw)
To: Alex Deucher
Cc: Charlene Liu, Hariprasad Kelam, Dmytro Laktyushkin,
Christian König, Leo Li, Tony Cheng, LKML, amd-gfx list,
Gloria Li, David Airlie, Yongqiang Sun,
Maling list - DRI developers, Alex Deucher, Bhawanpreet Lakha,
Nicholas Kazlauskas, Anthony Koo
Hi Alex.
On Wed, Jun 12, 2019 at 10:35:26PM -0400, Alex Deucher wrote:
> On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam
> <hariprasad.kelam@gmail.com> wrote:
> >
> > this patch fixes below compilation error
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In
> > function ‘dcn10_apply_ctx_for_surface’:
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:
> > error: implicit declaration of function ‘udelay’
> > [-Werror=implicit-function-declaration]
> > udelay(underflow_check_delay_us);
> >
> > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Am I right in assuming you took this patch?
I expect that new code using udelay was added to the amd tree,
and when merged with drm-misc-next it failed, because drm-misc-next no
longer had drmP.h included so no implicit include of delay.h
The root cause was that my original patchset should have been based
on the amd tree, and applied there :-(
Sam
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] drm/amd/display: fix compilation error
@ 2019-06-13 18:42 ` Sam Ravnborg
0 siblings, 0 replies; 19+ messages in thread
From: Sam Ravnborg @ 2019-06-13 18:42 UTC (permalink / raw)
To: Alex Deucher
Cc: Hariprasad Kelam, LKML, Yongqiang Sun, Charlene Liu, Leo Li,
Bhawanpreet Lakha, Gloria Li, amd-gfx list, Nicholas Kazlauskas,
David Airlie, Dmytro Laktyushkin, Tony Cheng,
Maling list - DRI developers, Alex Deucher, Christian König,
Anthony Koo
Hi Alex.
On Wed, Jun 12, 2019 at 10:35:26PM -0400, Alex Deucher wrote:
> On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam
> <hariprasad.kelam@gmail.com> wrote:
> >
> > this patch fixes below compilation error
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In
> > function ‘dcn10_apply_ctx_for_surface’:
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:
> > error: implicit declaration of function ‘udelay’
> > [-Werror=implicit-function-declaration]
> > udelay(underflow_check_delay_us);
> >
> > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Am I right in assuming you took this patch?
I expect that new code using udelay was added to the amd tree,
and when merged with drm-misc-next it failed, because drm-misc-next no
longer had drmP.h included so no implicit include of delay.h
The root cause was that my original patchset should have been based
on the amd tree, and applied there :-(
Sam
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] drm/amd/display: fix compilation error
2019-06-13 18:42 ` Sam Ravnborg
(?)
@ 2019-06-13 18:52 ` Alex Deucher
-1 siblings, 0 replies; 19+ messages in thread
From: Alex Deucher @ 2019-06-13 18:52 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Hariprasad Kelam, LKML, Yongqiang Sun, Charlene Liu, Leo Li,
Bhawanpreet Lakha, Gloria Li, amd-gfx list, Nicholas Kazlauskas,
David Airlie, Dmytro Laktyushkin, Tony Cheng,
Maling list - DRI developers, Alex Deucher, Christian König,
Anthony Koo
On Thu, Jun 13, 2019 at 2:42 PM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Alex.
>
> On Wed, Jun 12, 2019 at 10:35:26PM -0400, Alex Deucher wrote:
> > On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam
> > <hariprasad.kelam@gmail.com> wrote:
> > >
> > > this patch fixes below compilation error
> > >
> > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In
> > > function ‘dcn10_apply_ctx_for_surface’:
> > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:
> > > error: implicit declaration of function ‘udelay’
> > > [-Werror=implicit-function-declaration]
> > > udelay(underflow_check_delay_us);
> > >
> > > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
>
> Am I right in assuming you took this patch?
>
> I expect that new code using udelay was added to the amd tree,
> and when merged with drm-misc-next it failed, because drm-misc-next no
> longer had drmP.h included so no implicit include of delay.h
>
> The root cause was that my original patchset should have been based
> on the amd tree, and applied there :-(
No worries. I've picked it up.
Alex
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH] drm/amd/display: [FIX] Compilation error
@ 2020-10-02 23:56 ` Qingqing Zhuo
0 siblings, 0 replies; 19+ messages in thread
From: Qingqing Zhuo @ 2020-10-02 23:56 UTC (permalink / raw)
To: amd-gfx
Cc: Lewis.Huang, Aric.Cyr, sfr, Harry.Wentland, stable,
Alexander.Deucher, Bhawanpreet.Lakha, Nicholas.Kazlauskas
[Why]
ifdef mismatch.
[How]
Update to the correct flag.
Signed-off-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
Cc: <stable@vger.kernel.org>
---
drivers/gpu/drm/amd/display/dc/dce/dce_abm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h b/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h
index 389ca0d54d1b..24f7fe374e13 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h
+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h
@@ -189,7 +189,7 @@
#define ABM_MASK_SH_LIST_DCN20(mask_sh) ABM_MASK_SH_LIST_DCE110(mask_sh)
-#if defined(CONFIG_DRM_AMD_DC_DCN3_01)
+#if defined(CONFIG_DRM_AMD_DC_DCN3_0)
#define ABM_MASK_SH_LIST_DCN301(mask_sh) ABM_MASK_SH_LIST_DCN10(mask_sh)
#endif
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH] drm/amd/display: [FIX] Compilation error
@ 2020-10-02 23:56 ` Qingqing Zhuo
0 siblings, 0 replies; 19+ messages in thread
From: Qingqing Zhuo @ 2020-10-02 23:56 UTC (permalink / raw)
To: amd-gfx
Cc: Alexander.Deucher, Harry.Wentland, Bhawanpreet.Lakha,
Nicholas.Kazlauskas, Lewis.Huang, Aric.Cyr, sfr, stable
[Why]
ifdef mismatch.
[How]
Update to the correct flag.
Signed-off-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
Cc: <stable@vger.kernel.org>
---
drivers/gpu/drm/amd/display/dc/dce/dce_abm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h b/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h
index 389ca0d54d1b..24f7fe374e13 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h
+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h
@@ -189,7 +189,7 @@
#define ABM_MASK_SH_LIST_DCN20(mask_sh) ABM_MASK_SH_LIST_DCE110(mask_sh)
-#if defined(CONFIG_DRM_AMD_DC_DCN3_01)
+#if defined(CONFIG_DRM_AMD_DC_DCN3_0)
#define ABM_MASK_SH_LIST_DCN301(mask_sh) ABM_MASK_SH_LIST_DCN10(mask_sh)
#endif
--
2.17.1
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH] drm/amd/display: [FIX] Compilation error
2020-10-02 23:56 ` Qingqing Zhuo
@ 2020-10-03 1:11 ` Stephen Rothwell
-1 siblings, 0 replies; 19+ messages in thread
From: Stephen Rothwell @ 2020-10-03 1:11 UTC (permalink / raw)
To: Qingqing Zhuo
Cc: Lewis.Huang, Aric.Cyr, Harry.Wentland, amd-gfx, stable,
Alexander.Deucher, Bhawanpreet.Lakha, Nicholas.Kazlauskas
[-- Attachment #1.1: Type: text/plain, Size: 369 bytes --]
Hi Qingqing,
On Fri, 2 Oct 2020 19:56:08 -0400 Qingqing Zhuo <qingqing.zhuo@amd.com> wrote:
>
> [Why]
> ifdef mismatch.
>
> [How]
> Update to the correct flag.
>
> Signed-off-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
> Cc: <stable@vger.kernel.org>
This needs a Fixes: tag (if possible) and the error message, please.
--
Cheers,
Stephen Rothwell
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] drm/amd/display: [FIX] Compilation error
@ 2020-10-03 1:11 ` Stephen Rothwell
0 siblings, 0 replies; 19+ messages in thread
From: Stephen Rothwell @ 2020-10-03 1:11 UTC (permalink / raw)
To: Qingqing Zhuo
Cc: amd-gfx, Alexander.Deucher, Harry.Wentland, Bhawanpreet.Lakha,
Nicholas.Kazlauskas, Lewis.Huang, Aric.Cyr, stable
[-- Attachment #1: Type: text/plain, Size: 369 bytes --]
Hi Qingqing,
On Fri, 2 Oct 2020 19:56:08 -0400 Qingqing Zhuo <qingqing.zhuo@amd.com> wrote:
>
> [Why]
> ifdef mismatch.
>
> [How]
> Update to the correct flag.
>
> Signed-off-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
> Cc: <stable@vger.kernel.org>
This needs a Fixes: tag (if possible) and the error message, please.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH] drm/amd/display: [FIX] Compilation error
@ 2020-10-03 0:16 ` Qingqing Zhuo
0 siblings, 0 replies; 19+ messages in thread
From: Qingqing Zhuo @ 2020-10-03 0:16 UTC (permalink / raw)
To: amd-gfx
Cc: Eryk.Brol, Sunpeng.Li, Harry.Wentland, Qingqing.Zhuo,
Rodrigo.Siqueira, stable, Bhawanpreet.Lakha
[Why]
ifdef mismatch.
[How]
Update to the correct flag.
Signed-off-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
Cc: <stable@vger.kernel.org>
---
drivers/gpu/drm/amd/display/dc/dce/dce_abm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h b/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h
index 389ca0d54d1b..829cd9a93ba9 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h
+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h
@@ -189,7 +189,7 @@
#define ABM_MASK_SH_LIST_DCN20(mask_sh) ABM_MASK_SH_LIST_DCE110(mask_sh)
-#if defined(CONFIG_DRM_AMD_DC_DCN3_01)
+#if defined(CONFIG_DRM_AMD_DC_DCN3_0) || defined(CONFIG_DRM_AMD_DC_DCN3_01)
#define ABM_MASK_SH_LIST_DCN301(mask_sh) ABM_MASK_SH_LIST_DCN10(mask_sh)
#endif
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH] drm/amd/display: [FIX] Compilation error
@ 2020-10-03 0:16 ` Qingqing Zhuo
0 siblings, 0 replies; 19+ messages in thread
From: Qingqing Zhuo @ 2020-10-03 0:16 UTC (permalink / raw)
To: amd-gfx
Cc: Harry.Wentland, Sunpeng.Li, Bhawanpreet.Lakha, Rodrigo.Siqueira,
Qingqing.Zhuo, Eryk.Brol, stable
[Why]
ifdef mismatch.
[How]
Update to the correct flag.
Signed-off-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
Cc: <stable@vger.kernel.org>
---
drivers/gpu/drm/amd/display/dc/dce/dce_abm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h b/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h
index 389ca0d54d1b..829cd9a93ba9 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h
+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h
@@ -189,7 +189,7 @@
#define ABM_MASK_SH_LIST_DCN20(mask_sh) ABM_MASK_SH_LIST_DCE110(mask_sh)
-#if defined(CONFIG_DRM_AMD_DC_DCN3_01)
+#if defined(CONFIG_DRM_AMD_DC_DCN3_0) || defined(CONFIG_DRM_AMD_DC_DCN3_01)
#define ABM_MASK_SH_LIST_DCN301(mask_sh) ABM_MASK_SH_LIST_DCN10(mask_sh)
#endif
--
2.17.1
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH] drm/amd/display: [FIX] Compilation error
2020-10-03 0:16 ` Qingqing Zhuo
@ 2020-10-05 15:27 ` Rodrigo Siqueira
-1 siblings, 0 replies; 19+ messages in thread
From: Rodrigo Siqueira @ 2020-10-05 15:27 UTC (permalink / raw)
To: Qingqing Zhuo
Cc: Eryk.Brol, Sunpeng.Li, Harry.Wentland, stable, amd-gfx,
Bhawanpreet.Lakha
[-- Attachment #1.1: Type: text/plain, Size: 1027 bytes --]
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
On 10/02, Qingqing Zhuo wrote:
> [Why]
> ifdef mismatch.
>
> [How]
> Update to the correct flag.
>
> Signed-off-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
> Cc: <stable@vger.kernel.org>
> ---
> drivers/gpu/drm/amd/display/dc/dce/dce_abm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h b/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h
> index 389ca0d54d1b..829cd9a93ba9 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h
> @@ -189,7 +189,7 @@
>
> #define ABM_MASK_SH_LIST_DCN20(mask_sh) ABM_MASK_SH_LIST_DCE110(mask_sh)
>
> -#if defined(CONFIG_DRM_AMD_DC_DCN3_01)
> +#if defined(CONFIG_DRM_AMD_DC_DCN3_0) || defined(CONFIG_DRM_AMD_DC_DCN3_01)
> #define ABM_MASK_SH_LIST_DCN301(mask_sh) ABM_MASK_SH_LIST_DCN10(mask_sh)
> #endif
>
> --
> 2.17.1
>
--
Rodrigo Siqueira
https://siqueira.tech
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] drm/amd/display: [FIX] Compilation error
@ 2020-10-05 15:27 ` Rodrigo Siqueira
0 siblings, 0 replies; 19+ messages in thread
From: Rodrigo Siqueira @ 2020-10-05 15:27 UTC (permalink / raw)
To: Qingqing Zhuo
Cc: amd-gfx, Harry.Wentland, Sunpeng.Li, Bhawanpreet.Lakha, Eryk.Brol,
stable
[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
On 10/02, Qingqing Zhuo wrote:
> [Why]
> ifdef mismatch.
>
> [How]
> Update to the correct flag.
>
> Signed-off-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
> Cc: <stable@vger.kernel.org>
> ---
> drivers/gpu/drm/amd/display/dc/dce/dce_abm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h b/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h
> index 389ca0d54d1b..829cd9a93ba9 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h
> @@ -189,7 +189,7 @@
>
> #define ABM_MASK_SH_LIST_DCN20(mask_sh) ABM_MASK_SH_LIST_DCE110(mask_sh)
>
> -#if defined(CONFIG_DRM_AMD_DC_DCN3_01)
> +#if defined(CONFIG_DRM_AMD_DC_DCN3_0) || defined(CONFIG_DRM_AMD_DC_DCN3_01)
> #define ABM_MASK_SH_LIST_DCN301(mask_sh) ABM_MASK_SH_LIST_DCN10(mask_sh)
> #endif
>
> --
> 2.17.1
>
--
Rodrigo Siqueira
https://siqueira.tech
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2020-10-05 15:42 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-13 2:32 [PATCH] drm/amd/display: fix compilation error Hariprasad Kelam
2019-06-13 2:32 ` Hariprasad Kelam
2019-06-13 2:35 ` Alex Deucher
2019-06-13 2:35 ` Alex Deucher
[not found] ` <CADnq5_PU_jvOskC-=+oRQdvYXZvu_n26ogoWTxLRxnW+ke4wDw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-06-13 2:48 ` Hariprasad Kelam
2019-06-13 2:48 ` Hariprasad Kelam
2019-06-13 8:23 ` Daniel Vetter
2019-06-13 8:23 ` Daniel Vetter
2019-06-13 18:42 ` Sam Ravnborg
2019-06-13 18:42 ` Sam Ravnborg
2019-06-13 18:52 ` Alex Deucher
-- strict thread matches above, loose matches on Subject: below --
2020-10-02 23:56 [PATCH] drm/amd/display: [FIX] Compilation error Qingqing Zhuo
2020-10-02 23:56 ` Qingqing Zhuo
2020-10-03 1:11 ` Stephen Rothwell
2020-10-03 1:11 ` Stephen Rothwell
2020-10-03 0:16 Qingqing Zhuo
2020-10-03 0:16 ` Qingqing Zhuo
2020-10-05 15:27 ` Rodrigo Siqueira
2020-10-05 15:27 ` Rodrigo Siqueira
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.