* Re: [PATCH 2/2] KVM: nVMX: trace nested VM-Enter failures detected by H/W [not found] ` <0cb40615-de9e-4c3e-bcc7-68300a09481d@redhat.com> @ 2019-06-19 19:47 ` Sean Christopherson 2019-07-02 16:35 ` Paolo Bonzini 0 siblings, 1 reply; 2+ messages in thread From: Sean Christopherson @ 2019-06-19 19:47 UTC (permalink / raw) To: Paolo Bonzini; +Cc: Jim Mattson, Radim Krčmář, kvm list On Mon, Mar 18, 2019 at 10:47:03AM +0100, Paolo Bonzini wrote: > On 15/03/19 20:53, Jim Mattson wrote: > > On Fri, Mar 15, 2019 at 11:15 AM Paolo Bonzini <pbonzini@redhat.com> wrote: > >> > >> On 14/03/19 19:45, Sean Christopherson wrote: > >>>>> if (unlikely(vmx->fail)) { > >>>>> - pr_info_ratelimited("%s failed vm entry %x\n", __func__, > >>>>> - vmcs_read32(VM_INSTRUCTION_ERROR)); > >>>> I *love* the tracing, but I don't think we want to turn it on for > >>>> production. Can we keep the pr_info_ratelimited for when tracing is > >>>> disabled? > >>> Could we drop it to pr_debug_ratelimited()? Say "no" if it's at all > >>> inconvenient to use debug instead of info. The printing is nothing > >>> more than a minor annoyance when I'm running unit tests, i.e. any kind > >>> of actual use case trumps my partiality for a clean kernel log. > >>> > >> > >> I agree, it should be pr_debug_ratelimited (if anything). > > > > Let's go ahead and drop it, then. > > I'll add at least a vcpu_stat. Paolo, is this one of those series that you need to Google, or are you waiting on me for something? :-D ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] KVM: nVMX: trace nested VM-Enter failures detected by H/W 2019-06-19 19:47 ` [PATCH 2/2] KVM: nVMX: trace nested VM-Enter failures detected by H/W Sean Christopherson @ 2019-07-02 16:35 ` Paolo Bonzini 0 siblings, 0 replies; 2+ messages in thread From: Paolo Bonzini @ 2019-07-02 16:35 UTC (permalink / raw) To: Sean Christopherson; +Cc: Jim Mattson, Radim Krčmář, kvm list On 19/06/19 21:47, Sean Christopherson wrote: > are you waiting on me for something? :-D Can you please rebase the patches? Thanks, Paolo ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-02 16:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190308231645.25402-1-sean.j.christopherson@intel.com>
[not found] ` <20190308231645.25402-3-sean.j.christopherson@intel.com>
[not found] ` <CALMp9eQ4ADEqTmL4-1wT9Xh9mT9Xof9nmFypqF7_-TeKkHdOMQ@mail.gmail.com>
[not found] ` <20190314184540.GC4245@linux.intel.com>
[not found] ` <fe728261-67dc-a247-3ed3-b403269ac83d@redhat.com>
[not found] ` <CALMp9eQFT2qEuuOoZRpRkx0Fr0452kTnGyxKjK8qP9skWtY0rA@mail.gmail.com>
[not found] ` <0cb40615-de9e-4c3e-bcc7-68300a09481d@redhat.com>
2019-06-19 19:47 ` [PATCH 2/2] KVM: nVMX: trace nested VM-Enter failures detected by H/W Sean Christopherson
2019-07-02 16:35 ` Paolo Bonzini
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.