From: helgaas at kernel.org (Bjorn Helgaas)
Subject: [Linux-kernel-mentees] [PATCH v3 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates
Date: Fri, 21 Jun 2019 09:05:05 -0500 [thread overview]
Message-ID: <20190621140505.GF82584@google.com> (raw)
In-Reply-To: <20190621094607.15011-1-puranjay12@gmail.com>
[+cc Stephen]
On Fri, Jun 21, 2019 at 03:16:04PM +0530, Puranjay Mohan wrote:
> This patch series removes the private duplicates of PCI definitions in
> favour of generic definitions defined in pci_regs.h.
>
> This driver only uses some of the generic PCI definitons,
> which are included from pci_regs.h and thier private versions
> are removed from skfbi.h with all other private defines.
>
> The skfbi.h defines PCI_REV_ID and other private defines with different
> names, these are renamed to Generic PCI names to make them
> compatible with defines in pci_regs.h.
>
> All unused defines are removed from skfbi.h.
>
> Puranjay Mohan (3):
> net: fddi: skfp: Rename local PCI defines to match generic PCI defines
> net: fddi: skfp: Include generic PCI definitions
> net: fddi: skfp: Remove unused private PCI definitions
>
> drivers/net/fddi/skfp/drvfbi.c | 3 +-
> drivers/net/fddi/skfp/h/skfbi.h | 80 +--------------------------------
> 2 files changed, 4 insertions(+), 79 deletions(-)
It's good form to CC people who have commented on previous versions of
your series, so I added Stephen.
FWIW,
Reviewed-by: Bjorn Helgaas <bhelgaas at google.com>
WARNING: multiple messages have this Message-ID (diff)
From: helgaas@kernel.org (Bjorn Helgaas)
Subject: [Linux-kernel-mentees] [PATCH v3 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates
Date: Fri, 21 Jun 2019 09:05:05 -0500 [thread overview]
Message-ID: <20190621140505.GF82584@google.com> (raw)
Message-ID: <20190621140505.PqbOabPaHY5UGAU5LrxckKUFNldZv_eW3Yx8vtv6DcQ@z> (raw)
In-Reply-To: <20190621094607.15011-1-puranjay12@gmail.com>
[+cc Stephen]
On Fri, Jun 21, 2019 at 03:16:04PM +0530, Puranjay Mohan wrote:
> This patch series removes the private duplicates of PCI definitions in
> favour of generic definitions defined in pci_regs.h.
>
> This driver only uses some of the generic PCI definitons,
> which are included from pci_regs.h and thier private versions
> are removed from skfbi.h with all other private defines.
>
> The skfbi.h defines PCI_REV_ID and other private defines with different
> names, these are renamed to Generic PCI names to make them
> compatible with defines in pci_regs.h.
>
> All unused defines are removed from skfbi.h.
>
> Puranjay Mohan (3):
> net: fddi: skfp: Rename local PCI defines to match generic PCI defines
> net: fddi: skfp: Include generic PCI definitions
> net: fddi: skfp: Remove unused private PCI definitions
>
> drivers/net/fddi/skfp/drvfbi.c | 3 +-
> drivers/net/fddi/skfp/h/skfbi.h | 80 +--------------------------------
> 2 files changed, 4 insertions(+), 79 deletions(-)
It's good form to CC people who have commented on previous versions of
your series, so I added Stephen.
FWIW,
Reviewed-by: Bjorn Helgaas <bhelgaas at google.com>
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Puranjay Mohan <puranjay12@gmail.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
Bjorn Helgaas <bjorn@helgaas.com>,
netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-pci@vger.kernel.org,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v3 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates
Date: Fri, 21 Jun 2019 09:05:05 -0500 [thread overview]
Message-ID: <20190621140505.GF82584@google.com> (raw)
In-Reply-To: <20190621094607.15011-1-puranjay12@gmail.com>
[+cc Stephen]
On Fri, Jun 21, 2019 at 03:16:04PM +0530, Puranjay Mohan wrote:
> This patch series removes the private duplicates of PCI definitions in
> favour of generic definitions defined in pci_regs.h.
>
> This driver only uses some of the generic PCI definitons,
> which are included from pci_regs.h and thier private versions
> are removed from skfbi.h with all other private defines.
>
> The skfbi.h defines PCI_REV_ID and other private defines with different
> names, these are renamed to Generic PCI names to make them
> compatible with defines in pci_regs.h.
>
> All unused defines are removed from skfbi.h.
>
> Puranjay Mohan (3):
> net: fddi: skfp: Rename local PCI defines to match generic PCI defines
> net: fddi: skfp: Include generic PCI definitions
> net: fddi: skfp: Remove unused private PCI definitions
>
> drivers/net/fddi/skfp/drvfbi.c | 3 +-
> drivers/net/fddi/skfp/h/skfbi.h | 80 +--------------------------------
> 2 files changed, 4 insertions(+), 79 deletions(-)
It's good form to CC people who have commented on previous versions of
your series, so I added Stephen.
FWIW,
Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
next prev parent reply other threads:[~2019-06-21 14:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 9:46 [Linux-kernel-mentees] [PATCH v3 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates puranjay12
2019-06-21 9:46 ` Puranjay Mohan
2019-06-21 9:46 ` [Linux-kernel-mentees] " Puranjay Mohan
2019-06-21 9:46 ` [Linux-kernel-mentees] [PATCH v3 1/3] net: fddi: skfp: Rename local PCI defines to match generic PCI defines puranjay12
2019-06-21 9:46 ` Puranjay Mohan
2019-06-21 9:46 ` [Linux-kernel-mentees] " Puranjay Mohan
2019-06-21 9:46 ` [Linux-kernel-mentees] [PATCH v3 2/3] net: fddi: skfp: Include generic PCI definitions puranjay12
2019-06-21 9:46 ` Puranjay Mohan
2019-06-21 9:46 ` [Linux-kernel-mentees] " Puranjay Mohan
2019-06-21 9:46 ` [Linux-kernel-mentees] [PATCH v3 3/3] net: fddi: skfp: Remove unused private " puranjay12
2019-06-21 9:46 ` Puranjay Mohan
2019-06-21 9:46 ` [Linux-kernel-mentees] " Puranjay Mohan
2019-06-21 14:05 ` helgaas [this message]
2019-06-21 14:05 ` [PATCH v3 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates Bjorn Helgaas
2019-06-21 14:05 ` [Linux-kernel-mentees] " Bjorn Helgaas
2019-06-21 15:20 ` gnomes
2019-06-21 15:20 ` Alan Cox
2019-06-21 15:20 ` [Linux-kernel-mentees] " Alan Cox
2019-06-21 16:36 ` skhan
2019-06-21 16:36 ` Shuah Khan
2019-06-21 16:36 ` [Linux-kernel-mentees] " Shuah Khan
2019-06-26 20:03 ` davem
2019-06-26 20:03 ` David Miller
2019-06-26 20:03 ` [Linux-kernel-mentees] " David Miller
2019-06-21 16:44 ` helgaas
2019-06-21 16:44 ` Bjorn Helgaas
2019-06-21 16:44 ` [Linux-kernel-mentees] " Bjorn Helgaas
2019-06-21 17:59 ` joe
2019-06-21 17:59 ` Joe Perches
2019-06-21 17:59 ` [Linux-kernel-mentees] " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190621140505.GF82584@google.com \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.