All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregkh at linuxfoundation.org (Greg KH)
Subject: [Linux-kernel-mentees] [PATCH] staging: rtl8732bs: replace symbolic permission with octal permission
Date: Sat, 22 Jun 2019 08:28:15 +0200	[thread overview]
Message-ID: <20190622062815.GA6089@kroah.com> (raw)
In-Reply-To: <20190622053358.5832-1-sushmaunnibhavi425@gmail.com>

On Sat, Jun 22, 2019 at 11:03:58AM +0530, Sushma Unnibhavi wrote:
> Resolved following checkpatch issue:
> WARNING: Symbolic permissions 'S_IXUGO' are not preferred. Consider using octal permissions '0111'
> 
> Signed-off-by: Sushma Unnibhavi <sushmaunnibhavi425 at gmail.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Is this a "v2" patch?  If so, you always have to say that as per the
kernel documentation and put what changed below the --- line.

Also, you can not send patches based on top of a previous patch, unless
that patch was accepted.  And I don't think I accepted your previous
patch, right?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg KH)
Subject: [Linux-kernel-mentees] [PATCH] staging: rtl8732bs: replace symbolic permission with octal permission
Date: Sat, 22 Jun 2019 08:28:15 +0200	[thread overview]
Message-ID: <20190622062815.GA6089@kroah.com> (raw)
Message-ID: <20190622062815.MCMdBxjYsyy_D32Zwb15lbuLBRF7rTivEgdRrf5hmiQ@z> (raw)
In-Reply-To: <20190622053358.5832-1-sushmaunnibhavi425@gmail.com>

On Sat, Jun 22, 2019 at 11:03:58AM +0530, Sushma Unnibhavi wrote:
> Resolved following checkpatch issue:
> WARNING: Symbolic permissions 'S_IXUGO' are not preferred. Consider using octal permissions '0111'
> 
> Signed-off-by: Sushma Unnibhavi <sushmaunnibhavi425 at gmail.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Is this a "v2" patch?  If so, you always have to say that as per the
kernel documentation and put what changed below the --- line.

Also, you can not send patches based on top of a previous patch, unless
that patch was accepted.  And I don't think I accepted your previous
patch, right?

thanks,

greg k-h

  reply	other threads:[~2019-06-22  6:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-22  5:33 [Linux-kernel-mentees] [PATCH] staging: rtl8732bs: replace symbolic permission with octal permission sushmaunnibhavi425
2019-06-22  5:33 ` Sushma Unnibhavi
2019-06-22  6:28 ` gregkh [this message]
2019-06-22  6:28   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190622062815.GA6089@kroah.com \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.