* [Linux-kernel-mentees] [PATCH] staging: rtl8732bs: replace symbolic permission with octal permission
@ 2019-06-22 5:33 ` Sushma Unnibhavi
0 siblings, 0 replies; 4+ messages in thread
From: sushmaunnibhavi425 @ 2019-06-22 5:33 UTC (permalink / raw)
Resolved following checkpatch issue:
WARNING: Symbolic permissions 'S_IXUGO' are not preferred. Consider using octal permissions '0111'
Signed-off-by: Sushma Unnibhavi <sushmaunnibhavi425 at gmail.com>
---
drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/rtw_proc.c b/drivers/staging/rtl8723bs/os_dep/rtw_proc.c
index fd9dfb953ada..f4292a2fd011 100644
--- a/drivers/staging/rtl8723bs/os_dep/rtw_proc.c
+++ b/drivers/staging/rtl8723bs/os_dep/rtw_proc.c
@@ -21,7 +21,7 @@ inline struct proc_dir_entry *rtw_proc_create_dir(const char *name, struct proc_
{
struct proc_dir_entry *entry;
- entry = proc_mkdir_data(name, 0444|S_IXUGO, parent, data);
+ entry = proc_mkdir_data(name, 0444|0111, parent, data);
return entry;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Linux-kernel-mentees] [PATCH] staging: rtl8732bs: replace symbolic permission with octal permission
@ 2019-06-22 5:33 ` Sushma Unnibhavi
0 siblings, 0 replies; 4+ messages in thread
From: Sushma Unnibhavi @ 2019-06-22 5:33 UTC (permalink / raw)
Resolved following checkpatch issue:
WARNING: Symbolic permissions 'S_IXUGO' are not preferred. Consider using octal permissions '0111'
Signed-off-by: Sushma Unnibhavi <sushmaunnibhavi425 at gmail.com>
---
drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/rtw_proc.c b/drivers/staging/rtl8723bs/os_dep/rtw_proc.c
index fd9dfb953ada..f4292a2fd011 100644
--- a/drivers/staging/rtl8723bs/os_dep/rtw_proc.c
+++ b/drivers/staging/rtl8723bs/os_dep/rtw_proc.c
@@ -21,7 +21,7 @@ inline struct proc_dir_entry *rtw_proc_create_dir(const char *name, struct proc_
{
struct proc_dir_entry *entry;
- entry = proc_mkdir_data(name, 0444|S_IXUGO, parent, data);
+ entry = proc_mkdir_data(name, 0444|0111, parent, data);
return entry;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Linux-kernel-mentees] [PATCH] staging: rtl8732bs: replace symbolic permission with octal permission
@ 2019-06-22 6:28 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: gregkh @ 2019-06-22 6:28 UTC (permalink / raw)
On Sat, Jun 22, 2019 at 11:03:58AM +0530, Sushma Unnibhavi wrote:
> Resolved following checkpatch issue:
> WARNING: Symbolic permissions 'S_IXUGO' are not preferred. Consider using octal permissions '0111'
>
> Signed-off-by: Sushma Unnibhavi <sushmaunnibhavi425 at gmail.com>
> ---
> drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Is this a "v2" patch? If so, you always have to say that as per the
kernel documentation and put what changed below the --- line.
Also, you can not send patches based on top of a previous patch, unless
that patch was accepted. And I don't think I accepted your previous
patch, right?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Linux-kernel-mentees] [PATCH] staging: rtl8732bs: replace symbolic permission with octal permission
@ 2019-06-22 6:28 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2019-06-22 6:28 UTC (permalink / raw)
On Sat, Jun 22, 2019 at 11:03:58AM +0530, Sushma Unnibhavi wrote:
> Resolved following checkpatch issue:
> WARNING: Symbolic permissions 'S_IXUGO' are not preferred. Consider using octal permissions '0111'
>
> Signed-off-by: Sushma Unnibhavi <sushmaunnibhavi425 at gmail.com>
> ---
> drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Is this a "v2" patch? If so, you always have to say that as per the
kernel documentation and put what changed below the --- line.
Also, you can not send patches based on top of a previous patch, unless
that patch was accepted. And I don't think I accepted your previous
patch, right?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-22 6:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-22 5:33 [Linux-kernel-mentees] [PATCH] staging: rtl8732bs: replace symbolic permission with octal permission sushmaunnibhavi425
2019-06-22 5:33 ` Sushma Unnibhavi
2019-06-22 6:28 ` gregkh
2019-06-22 6:28 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.