All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregkh at linuxfoundation.org (Greg KH)
Subject: [Linux-kernel-mentees] [PATCH] changes in v2: changed both the symbolic permissions S_IFREG and S_IXUGO into octal permissions 0100000 and 0444 respectively
Date: Sat, 22 Jun 2019 09:00:23 +0200	[thread overview]
Message-ID: <20190622070023.GA25039@kroah.com> (raw)
In-Reply-To: <20190622064900.8830-1-sushmaunnibhavi425@gmail.com>

On Sat, Jun 22, 2019 at 12:19:00PM +0530, Sushma Unnibhavi wrote:
> Signed-off-by: Sushma Unnibhavi <sushmaunnibhavi425 at gmail.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Slow down, take a few hours off, and think about what you are doing
here.  Make a new patch, read the documentation for how to properly
document a versioned patch, and then send it to yourself to ensure you
have it right.

Then if it all looks ok, resend it here to everyone.  There is no rush.
Some of us are about to leave on 10+ plane rides anyway  :)

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg KH)
Subject: [Linux-kernel-mentees] [PATCH] changes in v2: changed both the symbolic permissions S_IFREG and S_IXUGO into octal permissions 0100000 and 0444 respectively
Date: Sat, 22 Jun 2019 09:00:23 +0200	[thread overview]
Message-ID: <20190622070023.GA25039@kroah.com> (raw)
Message-ID: <20190622070023._rpSb3mALXUlPj_AT9h8Uhwi6vQoN91m4whUi_flK3s@z> (raw)
In-Reply-To: <20190622064900.8830-1-sushmaunnibhavi425@gmail.com>

On Sat, Jun 22, 2019 at 12:19:00PM +0530, Sushma Unnibhavi wrote:
> Signed-off-by: Sushma Unnibhavi <sushmaunnibhavi425 at gmail.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Slow down, take a few hours off, and think about what you are doing
here.  Make a new patch, read the documentation for how to properly
document a versioned patch, and then send it to yourself to ensure you
have it right.

Then if it all looks ok, resend it here to everyone.  There is no rush.
Some of us are about to leave on 10+ plane rides anyway  :)

thanks,

greg k-h

  reply	other threads:[~2019-06-22  7:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-22  6:49 [Linux-kernel-mentees] [PATCH] changes in v2: changed both the symbolic permissions S_IFREG and S_IXUGO into octal permissions 0100000 and 0444 respectively sushmaunnibhavi425
2019-06-22  6:49 ` Sushma Unnibhavi
2019-06-22  7:00 ` gregkh [this message]
2019-06-22  7:00   ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2019-06-22  6:43 sushmaunnibhavi425
2019-06-22  6:43 ` Sushma Unnibhavi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190622070023.GA25039@kroah.com \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.