* [Linux-kernel-mentees] [PATCH] changes in v2: changed both the symbolic permissions S_IFREG and S_IXUGO into octal permissions 0100000 and 0444 respectively
@ 2019-06-22 6:43 ` Sushma Unnibhavi
0 siblings, 0 replies; 6+ messages in thread
From: sushmaunnibhavi425 @ 2019-06-22 6:43 UTC (permalink / raw)
Signed-off-by: Sushma Unnibhavi <sushmaunnibhavi425 at gmail.com>
---
drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/rtw_proc.c b/drivers/staging/rtl8723bs/os_dep/rtw_proc.c
index f4292a2fd011..5fcdcb47e657 100644
--- a/drivers/staging/rtl8723bs/os_dep/rtw_proc.c
+++ b/drivers/staging/rtl8723bs/os_dep/rtw_proc.c
@@ -31,7 +31,7 @@ inline struct proc_dir_entry *rtw_proc_create_entry(const char *name, struct pro
{
struct proc_dir_entry *entry;
- entry = proc_create_data(name, S_IFREG|0444, parent, fops, data);
+ entry = proc_create_data(name, 0100000|0444, parent, fops, data);
return entry;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Linux-kernel-mentees] [PATCH] changes in v2: changed both the symbolic permissions S_IFREG and S_IXUGO into octal permissions 0100000 and 0444 respectively
@ 2019-06-22 6:43 ` Sushma Unnibhavi
0 siblings, 0 replies; 6+ messages in thread
From: Sushma Unnibhavi @ 2019-06-22 6:43 UTC (permalink / raw)
Signed-off-by: Sushma Unnibhavi <sushmaunnibhavi425 at gmail.com>
---
drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/rtw_proc.c b/drivers/staging/rtl8723bs/os_dep/rtw_proc.c
index f4292a2fd011..5fcdcb47e657 100644
--- a/drivers/staging/rtl8723bs/os_dep/rtw_proc.c
+++ b/drivers/staging/rtl8723bs/os_dep/rtw_proc.c
@@ -31,7 +31,7 @@ inline struct proc_dir_entry *rtw_proc_create_entry(const char *name, struct pro
{
struct proc_dir_entry *entry;
- entry = proc_create_data(name, S_IFREG|0444, parent, fops, data);
+ entry = proc_create_data(name, 0100000|0444, parent, fops, data);
return entry;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Linux-kernel-mentees] [PATCH] changes in v2: changed both the symbolic permissions S_IFREG and S_IXUGO into octal permissions 0100000 and 0444 respectively
@ 2019-06-22 6:49 ` Sushma Unnibhavi
0 siblings, 0 replies; 6+ messages in thread
From: sushmaunnibhavi425 @ 2019-06-22 6:49 UTC (permalink / raw)
Signed-off-by: Sushma Unnibhavi <sushmaunnibhavi425 at gmail.com>
---
drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/rtw_proc.c b/drivers/staging/rtl8723bs/os_dep/rtw_proc.c
index f4292a2fd011..5fcdcb47e657 100644
--- a/drivers/staging/rtl8723bs/os_dep/rtw_proc.c
+++ b/drivers/staging/rtl8723bs/os_dep/rtw_proc.c
@@ -31,7 +31,7 @@ inline struct proc_dir_entry *rtw_proc_create_entry(const char *name, struct pro
{
struct proc_dir_entry *entry;
- entry = proc_create_data(name, S_IFREG|0444, parent, fops, data);
+ entry = proc_create_data(name, 0100000|0444, parent, fops, data);
return entry;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Linux-kernel-mentees] [PATCH] changes in v2: changed both the symbolic permissions S_IFREG and S_IXUGO into octal permissions 0100000 and 0444 respectively
@ 2019-06-22 6:49 ` Sushma Unnibhavi
0 siblings, 0 replies; 6+ messages in thread
From: Sushma Unnibhavi @ 2019-06-22 6:49 UTC (permalink / raw)
Signed-off-by: Sushma Unnibhavi <sushmaunnibhavi425 at gmail.com>
---
drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/rtw_proc.c b/drivers/staging/rtl8723bs/os_dep/rtw_proc.c
index f4292a2fd011..5fcdcb47e657 100644
--- a/drivers/staging/rtl8723bs/os_dep/rtw_proc.c
+++ b/drivers/staging/rtl8723bs/os_dep/rtw_proc.c
@@ -31,7 +31,7 @@ inline struct proc_dir_entry *rtw_proc_create_entry(const char *name, struct pro
{
struct proc_dir_entry *entry;
- entry = proc_create_data(name, S_IFREG|0444, parent, fops, data);
+ entry = proc_create_data(name, 0100000|0444, parent, fops, data);
return entry;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Linux-kernel-mentees] [PATCH] changes in v2: changed both the symbolic permissions S_IFREG and S_IXUGO into octal permissions 0100000 and 0444 respectively
@ 2019-06-22 7:00 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: gregkh @ 2019-06-22 7:00 UTC (permalink / raw)
On Sat, Jun 22, 2019 at 12:19:00PM +0530, Sushma Unnibhavi wrote:
> Signed-off-by: Sushma Unnibhavi <sushmaunnibhavi425 at gmail.com>
> ---
> drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Slow down, take a few hours off, and think about what you are doing
here. Make a new patch, read the documentation for how to properly
document a versioned patch, and then send it to yourself to ensure you
have it right.
Then if it all looks ok, resend it here to everyone. There is no rush.
Some of us are about to leave on 10+ plane rides anyway :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Linux-kernel-mentees] [PATCH] changes in v2: changed both the symbolic permissions S_IFREG and S_IXUGO into octal permissions 0100000 and 0444 respectively
@ 2019-06-22 7:00 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2019-06-22 7:00 UTC (permalink / raw)
On Sat, Jun 22, 2019 at 12:19:00PM +0530, Sushma Unnibhavi wrote:
> Signed-off-by: Sushma Unnibhavi <sushmaunnibhavi425 at gmail.com>
> ---
> drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Slow down, take a few hours off, and think about what you are doing
here. Make a new patch, read the documentation for how to properly
document a versioned patch, and then send it to yourself to ensure you
have it right.
Then if it all looks ok, resend it here to everyone. There is no rush.
Some of us are about to leave on 10+ plane rides anyway :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-06-22 7:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-22 6:49 [Linux-kernel-mentees] [PATCH] changes in v2: changed both the symbolic permissions S_IFREG and S_IXUGO into octal permissions 0100000 and 0444 respectively sushmaunnibhavi425
2019-06-22 6:49 ` Sushma Unnibhavi
2019-06-22 7:00 ` gregkh
2019-06-22 7:00 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2019-06-22 6:43 sushmaunnibhavi425
2019-06-22 6:43 ` Sushma Unnibhavi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.