stable queue build failures (ipv4/tcp)

stable queue build failures (ipv4/tcp)

[Guenter Roeck]

v4.4.y, v4.9.y, v4.14.y are affected.

net/ipv4/tcp_output.c: In function 'tcp_fragment':
net/ipv4/tcp_output.c:1165:8: error: 'tcp_queue' undeclared

net/ipv4/tcp_output.c:1165:21: error: 'TCP_FRAG_IN_WRITE_QUEUE' undeclared

Guenter

Re: stable queue build failures (ipv4/tcp)

[Greg Kroah-Hartman]

On Sat, Jun 22, 2019 at 06:41:38AM -0700, Guenter Roeck wrote:
> v4.4.y, v4.9.y, v4.14.y are affected.
> 
> net/ipv4/tcp_output.c: In function 'tcp_fragment':
> net/ipv4/tcp_output.c:1165:8: error: 'tcp_queue' undeclared
> 
> net/ipv4/tcp_output.c:1165:21: error: 'TCP_FRAG_IN_WRITE_QUEUE' undeclared

I deleted that patch a while ago, do you not see that update to the
queue?

thanks,

greg k-h

Re: stable queue build failures (ipv4/tcp)

[Greg Kroah-Hartman]

On Sat, Jun 22, 2019 at 05:29:29PM +0200, Greg Kroah-Hartman wrote:
> On Sat, Jun 22, 2019 at 06:41:38AM -0700, Guenter Roeck wrote:
> > v4.4.y, v4.9.y, v4.14.y are affected.
> > 
> > net/ipv4/tcp_output.c: In function 'tcp_fragment':
> > net/ipv4/tcp_output.c:1165:8: error: 'tcp_queue' undeclared
> > 
> > net/ipv4/tcp_output.c:1165:21: error: 'TCP_FRAG_IN_WRITE_QUEUE' undeclared
> 
> I deleted that patch a while ago, do you not see that update to the
> queue?

I have pushed out updated linux-stable-rc git updates in case you were
building off of those.

thanks,

greg k-h

Re: stable queue build failures (ipv4/tcp)

[Guenter Roeck]

On 6/22/19 8:29 AM, Greg Kroah-Hartman wrote:
> On Sat, Jun 22, 2019 at 06:41:38AM -0700, Guenter Roeck wrote:
>> v4.4.y, v4.9.y, v4.14.y are affected.
>>
>> net/ipv4/tcp_output.c: In function 'tcp_fragment':
>> net/ipv4/tcp_output.c:1165:8: error: 'tcp_queue' undeclared
>>
>> net/ipv4/tcp_output.c:1165:21: error: 'TCP_FRAG_IN_WRITE_QUEUE' undeclared
> 
> I deleted that patch a while ago, do you not see that update to the
> queue?
> 

I sent my e-mail at 6:41am today. The failing build was based on changes
the builders had picked up during the night. The builders picked up another
change at 8:45am, and one more at 8:55am. With those, the problem is gone.

Thanks,
Guenter

Re: stable queue build failures (ipv4/tcp)

[Guenter Roeck]

On 6/22/19 8:40 AM, Greg Kroah-Hartman wrote:
> On Sat, Jun 22, 2019 at 05:29:29PM +0200, Greg Kroah-Hartman wrote:
>> On Sat, Jun 22, 2019 at 06:41:38AM -0700, Guenter Roeck wrote:
>>> v4.4.y, v4.9.y, v4.14.y are affected.
>>>
>>> net/ipv4/tcp_output.c: In function 'tcp_fragment':
>>> net/ipv4/tcp_output.c:1165:8: error: 'tcp_queue' undeclared
>>>
>>> net/ipv4/tcp_output.c:1165:21: error: 'TCP_FRAG_IN_WRITE_QUEUE' undeclared
>>
>> I deleted that patch a while ago, do you not see that update to the
>> queue?
> 
> I have pushed out updated linux-stable-rc git updates in case you were
> building off of those.
> 

Ah yes, I keep forgetting that you don't update those immediately.
Sorry for the noise.

Guenter