* stable queue build failures (ipv4/tcp)
@ 2019-06-22 13:41 Guenter Roeck
2019-06-22 15:29 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Guenter Roeck @ 2019-06-22 13:41 UTC (permalink / raw)
To: stable, Greg Kroah-Hartman
v4.4.y, v4.9.y, v4.14.y are affected.
net/ipv4/tcp_output.c: In function 'tcp_fragment':
net/ipv4/tcp_output.c:1165:8: error: 'tcp_queue' undeclared
net/ipv4/tcp_output.c:1165:21: error: 'TCP_FRAG_IN_WRITE_QUEUE' undeclared
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: stable queue build failures (ipv4/tcp)
2019-06-22 13:41 stable queue build failures (ipv4/tcp) Guenter Roeck
@ 2019-06-22 15:29 ` Greg Kroah-Hartman
2019-06-22 15:40 ` Greg Kroah-Hartman
2019-06-22 16:03 ` Guenter Roeck
0 siblings, 2 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2019-06-22 15:29 UTC (permalink / raw)
To: Guenter Roeck; +Cc: stable
On Sat, Jun 22, 2019 at 06:41:38AM -0700, Guenter Roeck wrote:
> v4.4.y, v4.9.y, v4.14.y are affected.
>
> net/ipv4/tcp_output.c: In function 'tcp_fragment':
> net/ipv4/tcp_output.c:1165:8: error: 'tcp_queue' undeclared
>
> net/ipv4/tcp_output.c:1165:21: error: 'TCP_FRAG_IN_WRITE_QUEUE' undeclared
I deleted that patch a while ago, do you not see that update to the
queue?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: stable queue build failures (ipv4/tcp)
2019-06-22 15:29 ` Greg Kroah-Hartman
@ 2019-06-22 15:40 ` Greg Kroah-Hartman
2019-06-22 16:12 ` Guenter Roeck
2019-06-22 16:03 ` Guenter Roeck
1 sibling, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2019-06-22 15:40 UTC (permalink / raw)
To: Guenter Roeck; +Cc: stable
On Sat, Jun 22, 2019 at 05:29:29PM +0200, Greg Kroah-Hartman wrote:
> On Sat, Jun 22, 2019 at 06:41:38AM -0700, Guenter Roeck wrote:
> > v4.4.y, v4.9.y, v4.14.y are affected.
> >
> > net/ipv4/tcp_output.c: In function 'tcp_fragment':
> > net/ipv4/tcp_output.c:1165:8: error: 'tcp_queue' undeclared
> >
> > net/ipv4/tcp_output.c:1165:21: error: 'TCP_FRAG_IN_WRITE_QUEUE' undeclared
>
> I deleted that patch a while ago, do you not see that update to the
> queue?
I have pushed out updated linux-stable-rc git updates in case you were
building off of those.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: stable queue build failures (ipv4/tcp)
2019-06-22 15:40 ` Greg Kroah-Hartman
@ 2019-06-22 16:12 ` Guenter Roeck
0 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2019-06-22 16:12 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: stable
On 6/22/19 8:40 AM, Greg Kroah-Hartman wrote:
> On Sat, Jun 22, 2019 at 05:29:29PM +0200, Greg Kroah-Hartman wrote:
>> On Sat, Jun 22, 2019 at 06:41:38AM -0700, Guenter Roeck wrote:
>>> v4.4.y, v4.9.y, v4.14.y are affected.
>>>
>>> net/ipv4/tcp_output.c: In function 'tcp_fragment':
>>> net/ipv4/tcp_output.c:1165:8: error: 'tcp_queue' undeclared
>>>
>>> net/ipv4/tcp_output.c:1165:21: error: 'TCP_FRAG_IN_WRITE_QUEUE' undeclared
>>
>> I deleted that patch a while ago, do you not see that update to the
>> queue?
>
> I have pushed out updated linux-stable-rc git updates in case you were
> building off of those.
>
Ah yes, I keep forgetting that you don't update those immediately.
Sorry for the noise.
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: stable queue build failures (ipv4/tcp)
2019-06-22 15:29 ` Greg Kroah-Hartman
2019-06-22 15:40 ` Greg Kroah-Hartman
@ 2019-06-22 16:03 ` Guenter Roeck
1 sibling, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2019-06-22 16:03 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: stable
On 6/22/19 8:29 AM, Greg Kroah-Hartman wrote:
> On Sat, Jun 22, 2019 at 06:41:38AM -0700, Guenter Roeck wrote:
>> v4.4.y, v4.9.y, v4.14.y are affected.
>>
>> net/ipv4/tcp_output.c: In function 'tcp_fragment':
>> net/ipv4/tcp_output.c:1165:8: error: 'tcp_queue' undeclared
>>
>> net/ipv4/tcp_output.c:1165:21: error: 'TCP_FRAG_IN_WRITE_QUEUE' undeclared
>
> I deleted that patch a while ago, do you not see that update to the
> queue?
>
I sent my e-mail at 6:41am today. The failing build was based on changes
the builders had picked up during the night. The builders picked up another
change at 8:45am, and one more at 8:55am. With those, the problem is gone.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-22 16:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-22 13:41 stable queue build failures (ipv4/tcp) Guenter Roeck
2019-06-22 15:29 ` Greg Kroah-Hartman
2019-06-22 15:40 ` Greg Kroah-Hartman
2019-06-22 16:12 ` Guenter Roeck
2019-06-22 16:03 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.