All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
Cc: vigneshr@ti.com, bbrezillon@kernel.org, helmut.grohne@intenta.de,
	richard@nod.at, linux-kernel@vger.kernel.org,
	marek.vasut@gmail.com, yamada.masahiro@socionext.com,
	linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com,
	computersforpeace@gmail.com, dwmw2@infradead.org
Subject: Re: [LINUX PATCH v17 1/2] mtd: rawnand: nand_micron: Do not over write driver's read_page()/write_page()
Date: Wed, 26 Jun 2019 08:48:07 +0200	[thread overview]
Message-ID: <20190626084807.3f06e718@collabora.com> (raw)
In-Reply-To: <20190625044630.31717-1-naga.sureshkumar.relli@xilinx.com>

On Mon, 24 Jun 2019 22:46:29 -0600
Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com> wrote:

> Add check before assigning chip->ecc.read_page() and chip->ecc.write_page()
> 
> Signed-off-by: Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
> ---
>  drivers/mtd/nand/raw/nand_micron.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/nand_micron.c b/drivers/mtd/nand/raw/nand_micron.c
> index cbd4f09ac178..565f2696c747 100644
> --- a/drivers/mtd/nand/raw/nand_micron.c
> +++ b/drivers/mtd/nand/raw/nand_micron.c
> @@ -500,8 +500,11 @@ static int micron_nand_init(struct nand_chip *chip)
>  		chip->ecc.size = 512;
>  		chip->ecc.strength = chip->base.eccreq.strength;
>  		chip->ecc.algo = NAND_ECC_BCH;
> -		chip->ecc.read_page = micron_nand_read_page_on_die_ecc;
> -		chip->ecc.write_page = micron_nand_write_page_on_die_ecc;
> +		if (!chip->ecc.read_page)
> +			chip->ecc.read_page = micron_nand_read_page_on_die_ecc;
> +
> +		if (!chip->ecc.write_page)
> +			chip->ecc.write_page = micron_nand_write_page_on_die_ecc;

That's wrong, if you don't want on-die ECC to be used, simply don't set
nand-ecc-mode to "on-die".

>  
>  		if (ondie == MICRON_ON_DIE_MANDATORY) {
>  			chip->ecc.read_page_raw = nand_read_page_raw_notsupp;


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
Cc: miquel.raynal@bootlin.com, helmut.grohne@intenta.de,
	richard@nod.at, dwmw2@infradead.org, computersforpeace@gmail.com,
	marek.vasut@gmail.com, vigneshr@ti.com, bbrezillon@kernel.org,
	yamada.masahiro@socionext.com, linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [LINUX PATCH v17 1/2] mtd: rawnand: nand_micron: Do not over write driver's read_page()/write_page()
Date: Wed, 26 Jun 2019 08:48:07 +0200	[thread overview]
Message-ID: <20190626084807.3f06e718@collabora.com> (raw)
In-Reply-To: <20190625044630.31717-1-naga.sureshkumar.relli@xilinx.com>

On Mon, 24 Jun 2019 22:46:29 -0600
Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com> wrote:

> Add check before assigning chip->ecc.read_page() and chip->ecc.write_page()
> 
> Signed-off-by: Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
> ---
>  drivers/mtd/nand/raw/nand_micron.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/nand_micron.c b/drivers/mtd/nand/raw/nand_micron.c
> index cbd4f09ac178..565f2696c747 100644
> --- a/drivers/mtd/nand/raw/nand_micron.c
> +++ b/drivers/mtd/nand/raw/nand_micron.c
> @@ -500,8 +500,11 @@ static int micron_nand_init(struct nand_chip *chip)
>  		chip->ecc.size = 512;
>  		chip->ecc.strength = chip->base.eccreq.strength;
>  		chip->ecc.algo = NAND_ECC_BCH;
> -		chip->ecc.read_page = micron_nand_read_page_on_die_ecc;
> -		chip->ecc.write_page = micron_nand_write_page_on_die_ecc;
> +		if (!chip->ecc.read_page)
> +			chip->ecc.read_page = micron_nand_read_page_on_die_ecc;
> +
> +		if (!chip->ecc.write_page)
> +			chip->ecc.write_page = micron_nand_write_page_on_die_ecc;

That's wrong, if you don't want on-die ECC to be used, simply don't set
nand-ecc-mode to "on-die".

>  
>  		if (ondie == MICRON_ON_DIE_MANDATORY) {
>  			chip->ecc.read_page_raw = nand_read_page_raw_notsupp;


  parent reply	other threads:[~2019-06-26  6:48 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-25  4:46 [LINUX PATCH v17 1/2] mtd: rawnand: nand_micron: Do not over write driver's read_page()/write_page() Naga Sureshkumar Relli
2019-06-25  4:46 ` Naga Sureshkumar Relli
2019-06-25  4:46 ` [LINUX PATCH v17 2/2] mtd: rawnand: pl353: Add basic driver for arm pl353 smc nand interface Naga Sureshkumar Relli
2019-06-25  4:46   ` Naga Sureshkumar Relli
2019-06-25 14:11   ` Helmut Grohne
2019-06-25 14:11     ` Helmut Grohne
2019-07-03  6:13     ` Naga Sureshkumar Relli
2019-07-03  6:13       ` Naga Sureshkumar Relli
2019-07-03  6:25   ` Boris Brezillon
2019-07-03  6:25     ` Boris Brezillon
2019-07-03  8:57     ` Naga Sureshkumar Relli
2019-07-03  8:57       ` Naga Sureshkumar Relli
2019-07-03 11:06       ` Boris Brezillon
2019-07-03 11:06         ` Boris Brezillon
2019-07-03 11:29         ` Naga Sureshkumar Relli
2019-07-03 11:29           ` Naga Sureshkumar Relli
2019-07-03 11:40           ` Boris Brezillon
2019-07-03 11:40             ` Boris Brezillon
2019-06-25 14:11 ` [LINUX PATCH v17 1/2] mtd: rawnand: nand_micron: Do not over write driver's read_page()/write_page() Helmut Grohne
2019-06-25 14:11   ` Helmut Grohne
2019-06-26  6:48 ` Boris Brezillon [this message]
2019-06-26  6:48   ` Boris Brezillon
2019-06-26 11:22   ` Naga Sureshkumar Relli
2019-06-26 11:22     ` Naga Sureshkumar Relli
2019-06-26 11:27     ` Boris Brezillon
2019-06-26 11:27       ` Boris Brezillon
2019-06-26 11:51       ` Naga Sureshkumar Relli
2019-06-26 11:51         ` Naga Sureshkumar Relli
2019-06-26 12:04         ` Boris Brezillon
2019-06-26 12:04           ` Boris Brezillon
2019-06-26 12:12           ` Naga Sureshkumar Relli
2019-06-26 12:12             ` Naga Sureshkumar Relli
2019-06-26 12:20             ` Boris Brezillon
2019-06-26 12:20               ` Boris Brezillon
2019-06-26 12:33               ` Naga Sureshkumar Relli
2019-06-26 12:33                 ` Naga Sureshkumar Relli
2019-07-08 12:18                 ` Naga Sureshkumar Relli
2019-07-08 12:18                   ` Naga Sureshkumar Relli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190626084807.3f06e718@collabora.com \
    --to=boris.brezillon@collabora.com \
    --cc=bbrezillon@kernel.org \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=helmut.grohne@intenta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=naga.sureshkumar.relli@xilinx.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.