From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Mason Yang <masonccyang@mxic.com.tw>
Cc: devicetree@vger.kernel.org, anders.roxell@linaro.org,
vigneshr@ti.com, jianxin.pan@amlogic.com, bbrezillon@kernel.org,
juliensu@mxic.com.tw, richard@nod.at, broonie@kernel.org,
linux-kernel@vger.kernel.org, stefan@agner.ch,
paul@crapouillou.net, marek.vasut@gmail.com,
paul.burton@mips.com, liang.yang@amlogic.com,
linux-mtd@lists.infradead.org, christophe.kerello@st.com,
lee.jones@linaro.org, computersforpeace@gmail.com,
dwmw2@infradead.org
Subject: Re: [PATCH v4 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings
Date: Thu, 27 Jun 2019 19:26:09 +0200 [thread overview]
Message-ID: <20190627192609.0965f6d5@xps13> (raw)
In-Reply-To: <1561443056-13766-3-git-send-email-masonccyang@mxic.com.tw>
Hi Mason,
Mason Yang <masonccyang@mxic.com.tw> wrote on Tue, 25 Jun 2019 14:10:56
+0800:
> Document the bindings used by the Macronix raw NAND controller.
>
> Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> ---
> .../devicetree/bindings/mtd/mxic-nand.txt | 26 ++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mtd/mxic-nand.txt
>
> diff --git a/Documentation/devicetree/bindings/mtd/mxic-nand.txt b/Documentation/devicetree/bindings/mtd/mxic-nand.txt
> new file mode 100644
> index 0000000..3d198e4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/mxic-nand.txt
> @@ -0,0 +1,26 @@
> +Macronix Raw NAND Controller Device Tree Bindings
> +-------------------------------------------------
> +
> +Required properties:
> +- compatible: should be "mxic,raw-nand-ctlr"
I would prefer "macronix,nand-controller"
> +- reg: should contain 1 entrie for the registers
entry
> +- reg-names: should contain "regs"
Not sure you need that?
> +- interrupts: interrupt line connected to this NAND controller
> +- clock-names: should contain "ps_clk", "send_clk" and "send_dly_clk"
> +- clocks: should contain 3 entries for the "ps_clk", "send_clk" and
> + "send_dly_clk" clocks
s/entries/phandles/ ?
> +
> +Example:
> +
> + nand: mxic-nfc@43c30000 {
> + compatible = "mxic,raw-nand-ctlr";
> + reg = <0x43c30000 0x10000>;
> + reg-names = "regs";
> + clocks = <&clkwizard 0>, <&clkwizard 1>, <&clkc 15>;
> + clock-names = "send_clk", "send_dly_clk", "ps_clk";
> +
> + nand-ecc-mode = "soft";
> + nand-ecc-algo = "bch";
> + nand-ecc-step-size = <512>;
> + nand-ecc-strength = <8>;
The last 4 lines are probably not needed.
> + };
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Mason Yang <masonccyang@mxic.com.tw>
Cc: marek.vasut@gmail.com, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, bbrezillon@kernel.org,
dwmw2@infradead.org, computersforpeace@gmail.com,
vigneshr@ti.com, paul.burton@mips.com, liang.yang@amlogic.com,
richard@nod.at, anders.roxell@linaro.org,
christophe.kerello@st.com, paul@crapouillou.net,
jianxin.pan@amlogic.com, stefan@agner.ch,
devicetree@vger.kernel.org, juliensu@mxic.com.tw,
lee.jones@linaro.org, broonie@kernel.org
Subject: Re: [PATCH v4 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings
Date: Thu, 27 Jun 2019 19:26:09 +0200 [thread overview]
Message-ID: <20190627192609.0965f6d5@xps13> (raw)
In-Reply-To: <1561443056-13766-3-git-send-email-masonccyang@mxic.com.tw>
Hi Mason,
Mason Yang <masonccyang@mxic.com.tw> wrote on Tue, 25 Jun 2019 14:10:56
+0800:
> Document the bindings used by the Macronix raw NAND controller.
>
> Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> ---
> .../devicetree/bindings/mtd/mxic-nand.txt | 26 ++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mtd/mxic-nand.txt
>
> diff --git a/Documentation/devicetree/bindings/mtd/mxic-nand.txt b/Documentation/devicetree/bindings/mtd/mxic-nand.txt
> new file mode 100644
> index 0000000..3d198e4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/mxic-nand.txt
> @@ -0,0 +1,26 @@
> +Macronix Raw NAND Controller Device Tree Bindings
> +-------------------------------------------------
> +
> +Required properties:
> +- compatible: should be "mxic,raw-nand-ctlr"
I would prefer "macronix,nand-controller"
> +- reg: should contain 1 entrie for the registers
entry
> +- reg-names: should contain "regs"
Not sure you need that?
> +- interrupts: interrupt line connected to this NAND controller
> +- clock-names: should contain "ps_clk", "send_clk" and "send_dly_clk"
> +- clocks: should contain 3 entries for the "ps_clk", "send_clk" and
> + "send_dly_clk" clocks
s/entries/phandles/ ?
> +
> +Example:
> +
> + nand: mxic-nfc@43c30000 {
> + compatible = "mxic,raw-nand-ctlr";
> + reg = <0x43c30000 0x10000>;
> + reg-names = "regs";
> + clocks = <&clkwizard 0>, <&clkwizard 1>, <&clkc 15>;
> + clock-names = "send_clk", "send_dly_clk", "ps_clk";
> +
> + nand-ecc-mode = "soft";
> + nand-ecc-algo = "bch";
> + nand-ecc-step-size = <512>;
> + nand-ecc-strength = <8>;
The last 4 lines are probably not needed.
> + };
Thanks,
Miquèl
next prev parent reply other threads:[~2019-06-27 17:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 6:10 [PATCH v4 0/2] Add Macronix Raw NAND controller driver Mason Yang
2019-06-25 6:10 ` Mason Yang
2019-06-25 6:10 ` [PATCH v4 1/2] mtd: rawnand: Add Macronix Raw NAND controller Mason Yang
2019-06-25 6:10 ` Mason Yang
2019-06-27 17:36 ` Miquel Raynal
2019-06-27 17:36 ` Miquel Raynal
2019-06-28 6:01 ` masonccyang
2019-06-28 6:01 ` masonccyang
2019-06-28 7:18 ` Miquel Raynal
2019-06-28 7:18 ` Miquel Raynal
2019-06-28 8:31 ` masonccyang
2019-06-28 8:31 ` masonccyang
2019-06-28 8:44 ` Miquel Raynal
2019-06-28 8:44 ` Miquel Raynal
2019-07-03 3:03 ` masonccyang
2019-07-03 3:03 ` masonccyang
2019-06-25 6:10 ` [PATCH v4 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings Mason Yang
2019-06-25 6:10 ` Mason Yang
2019-06-27 17:26 ` Miquel Raynal [this message]
2019-06-27 17:26 ` Miquel Raynal
2019-06-28 6:48 ` masonccyang
2019-06-28 6:48 ` masonccyang
2019-06-28 7:42 ` Miquel Raynal
2019-06-28 7:42 ` Miquel Raynal
2019-06-28 9:09 ` masonccyang
2019-06-28 9:09 ` masonccyang
2019-06-28 9:12 ` Miquel Raynal
2019-06-28 9:12 ` Miquel Raynal
2019-06-28 9:23 ` masonccyang
2019-06-28 9:23 ` masonccyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627192609.0965f6d5@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=anders.roxell@linaro.org \
--cc=bbrezillon@kernel.org \
--cc=broonie@kernel.org \
--cc=christophe.kerello@st.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=jianxin.pan@amlogic.com \
--cc=juliensu@mxic.com.tw \
--cc=lee.jones@linaro.org \
--cc=liang.yang@amlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=masonccyang@mxic.com.tw \
--cc=paul.burton@mips.com \
--cc=paul@crapouillou.net \
--cc=richard@nod.at \
--cc=stefan@agner.ch \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.