All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: masonccyang@mxic.com.tw
Cc: devicetree@vger.kernel.org, christophe.kerello@st.com,
	vigneshr@ti.com, jianxin.pan@amlogic.com, bbrezillon@kernel.org,
	juliensu@mxic.com.tw, lee.jones@linaro.org,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	paul@crapouillou.net, marek.vasut@gmail.com,
	paul.burton@mips.com, broonie@kernel.org,
	linux-mtd@lists.infradead.org, stefan@agner.ch, richard@nod.at,
	anders.roxell@linaro.org, liang.yang@amlogic.com,
	computersforpeace@gmail.com, dwmw2@infradead.org
Subject: Re: [PATCH v4 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings
Date: Fri, 28 Jun 2019 11:12:50 +0200	[thread overview]
Message-ID: <20190628111250.34da11be@xps13> (raw)
In-Reply-To: <OFF895B48A.00F391C1-ON48258427.002F8256-48258427.003249E0@mxic.com.tw>

Hi Mason,

masonccyang@mxic.com.tw wrote on Fri, 28 Jun 2019 17:09:16 +0800:

> Hi Miquel,
> 
> > 
> > Please always Cc: Rob (robh+dt@kernel.org) when you send bindings
> > related patches.  
> 
> Understood. thanks for your remind.
> 
> 
> > >   
> > > >   
> > > > > +- reg: should contain 1 entrie for the registers   
> > > > 
> > > >                            entry
> > > >   
> > > > > +- reg-names: should contain "regs"   
> > > > 
> > > > Not sure you need that?   
> > > 
> > > for a base address of ctlr registers.  
> > 
> > Yes I know, I mean: you don't necessarily need the 'reg-names' property
> > as it is supposed that the only entry will be the IP registers (unless
> > there are more). I don't know what's Rob preference here but I would
> > either drop the reg-names property or enhance the name, "regs" is
> > terribly not descriptive.  
> 
> Got it, any comment is appreciated for either drop the reg-names property 
> or enhance the name.
> 
> >   
> > > > > +- interrupts: interrupt line connected to this NAND controller
> > > > > +- clock-names: should contain "ps_clk", "send_clk" and   
> "send_dly_clk"
> > > > > +- clocks: should contain 3 entries for the "ps_clk", "send_clk"   
> and
> > > > > +    "send_dly_clk" clocks   
> > > > 
> > > > s/entries/phandles/ ?   
> > > 
> > > ?
> > > as I know that kernel views the phandle values as device tree   
> structure
> > > information instead of device tree data and thus does not store them   
> as
> > > properties.  
> > 
> > The bindings have nothing to do with the kernel views. They might
> > actually be merged in a different project, out of the kernel.
> >   
> 
> if patch to phandle, should we also patch driver to of_xxx_phandle()?

I don't understand your question. <&clk 1> is a phandle, you already
use phandles, it's just more precise than the word "entries".


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: masonccyang@mxic.com.tw
Cc: anders.roxell@linaro.org, bbrezillon@kernel.org,
	broonie@kernel.org, christophe.kerello@st.com,
	computersforpeace@gmail.com, devicetree@vger.kernel.org,
	dwmw2@infradead.org, jianxin.pan@amlogic.com,
	juliensu@mxic.com.tw, lee.jones@linaro.org,
	liang.yang@amlogic.com, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org, marek.vasut@gmail.com,
	paul@crapouillou.net, paul.burton@mips.com, richard@nod.at,
	robh+dt@kernel.org, stefan@agner.ch, vigneshr@ti.com
Subject: Re: [PATCH v4 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings
Date: Fri, 28 Jun 2019 11:12:50 +0200	[thread overview]
Message-ID: <20190628111250.34da11be@xps13> (raw)
In-Reply-To: <OFF895B48A.00F391C1-ON48258427.002F8256-48258427.003249E0@mxic.com.tw>

Hi Mason,

masonccyang@mxic.com.tw wrote on Fri, 28 Jun 2019 17:09:16 +0800:

> Hi Miquel,
> 
> > 
> > Please always Cc: Rob (robh+dt@kernel.org) when you send bindings
> > related patches.  
> 
> Understood. thanks for your remind.
> 
> 
> > >   
> > > >   
> > > > > +- reg: should contain 1 entrie for the registers   
> > > > 
> > > >                            entry
> > > >   
> > > > > +- reg-names: should contain "regs"   
> > > > 
> > > > Not sure you need that?   
> > > 
> > > for a base address of ctlr registers.  
> > 
> > Yes I know, I mean: you don't necessarily need the 'reg-names' property
> > as it is supposed that the only entry will be the IP registers (unless
> > there are more). I don't know what's Rob preference here but I would
> > either drop the reg-names property or enhance the name, "regs" is
> > terribly not descriptive.  
> 
> Got it, any comment is appreciated for either drop the reg-names property 
> or enhance the name.
> 
> >   
> > > > > +- interrupts: interrupt line connected to this NAND controller
> > > > > +- clock-names: should contain "ps_clk", "send_clk" and   
> "send_dly_clk"
> > > > > +- clocks: should contain 3 entries for the "ps_clk", "send_clk"   
> and
> > > > > +    "send_dly_clk" clocks   
> > > > 
> > > > s/entries/phandles/ ?   
> > > 
> > > ?
> > > as I know that kernel views the phandle values as device tree   
> structure
> > > information instead of device tree data and thus does not store them   
> as
> > > properties.  
> > 
> > The bindings have nothing to do with the kernel views. They might
> > actually be merged in a different project, out of the kernel.
> >   
> 
> if patch to phandle, should we also patch driver to of_xxx_phandle()?

I don't understand your question. <&clk 1> is a phandle, you already
use phandles, it's just more precise than the word "entries".


Thanks,
Miquèl

  reply	other threads:[~2019-06-28  9:13 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-25  6:10 [PATCH v4 0/2] Add Macronix Raw NAND controller driver Mason Yang
2019-06-25  6:10 ` Mason Yang
2019-06-25  6:10 ` [PATCH v4 1/2] mtd: rawnand: Add Macronix Raw NAND controller Mason Yang
2019-06-25  6:10   ` Mason Yang
2019-06-27 17:36   ` Miquel Raynal
2019-06-27 17:36     ` Miquel Raynal
2019-06-28  6:01     ` masonccyang
2019-06-28  6:01       ` masonccyang
2019-06-28  7:18       ` Miquel Raynal
2019-06-28  7:18         ` Miquel Raynal
2019-06-28  8:31         ` masonccyang
2019-06-28  8:31           ` masonccyang
2019-06-28  8:44           ` Miquel Raynal
2019-06-28  8:44             ` Miquel Raynal
2019-07-03  3:03     ` masonccyang
2019-07-03  3:03       ` masonccyang
2019-06-25  6:10 ` [PATCH v4 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings Mason Yang
2019-06-25  6:10   ` Mason Yang
2019-06-27 17:26   ` Miquel Raynal
2019-06-27 17:26     ` Miquel Raynal
2019-06-28  6:48     ` masonccyang
2019-06-28  6:48       ` masonccyang
2019-06-28  7:42       ` Miquel Raynal
2019-06-28  7:42         ` Miquel Raynal
2019-06-28  9:09         ` masonccyang
2019-06-28  9:09           ` masonccyang
2019-06-28  9:12           ` Miquel Raynal [this message]
2019-06-28  9:12             ` Miquel Raynal
2019-06-28  9:23             ` masonccyang
2019-06-28  9:23               ` masonccyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190628111250.34da11be@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=anders.roxell@linaro.org \
    --cc=bbrezillon@kernel.org \
    --cc=broonie@kernel.org \
    --cc=christophe.kerello@st.com \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=jianxin.pan@amlogic.com \
    --cc=juliensu@mxic.com.tw \
    --cc=lee.jones@linaro.org \
    --cc=liang.yang@amlogic.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=masonccyang@mxic.com.tw \
    --cc=paul.burton@mips.com \
    --cc=paul@crapouillou.net \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=stefan@agner.ch \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.