From: Peter Zijlstra <peterz@infradead.org>
To: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Cc: Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org,
srinivas.eeda@oracle.com, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [Xen-devel] [PATCH v2] xen/pv: Fix a boot up hang revealed by int3 self test
Date: Fri, 12 Jul 2019 14:06:26 +0200 [thread overview]
Message-ID: <20190712120626.GW3402@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1562832921-20831-1-git-send-email-zhenzhong.duan@oracle.com>
On Thu, Jul 11, 2019 at 04:15:21PM +0800, Zhenzhong Duan wrote:
> diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
> index 4722ba2..2138d69 100644
> --- a/arch/x86/xen/enlighten_pv.c
> +++ b/arch/x86/xen/enlighten_pv.c
> @@ -596,7 +596,7 @@ struct trap_array_entry {
>
> static struct trap_array_entry trap_array[] = {
> { debug, xen_xendebug, true },
> - { int3, xen_xenint3, true },
> + { int3, xen_int3, true },
> { double_fault, xen_double_fault, true },
> #ifdef CONFIG_X86_MCE
> { machine_check, xen_machine_check, true },
I'm confused on the purpose of trap_array[], could you elucidate me?
The sole user seems to be get_trap_addr() and that talks about ISTs, but
#BP isn't an IST anymore, so why does it have ist_okay=true?
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
x86@kernel.org, srinivas.eeda@oracle.com,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH v2] xen/pv: Fix a boot up hang revealed by int3 self test
Date: Fri, 12 Jul 2019 14:06:26 +0200 [thread overview]
Message-ID: <20190712120626.GW3402@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1562832921-20831-1-git-send-email-zhenzhong.duan@oracle.com>
On Thu, Jul 11, 2019 at 04:15:21PM +0800, Zhenzhong Duan wrote:
> diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
> index 4722ba2..2138d69 100644
> --- a/arch/x86/xen/enlighten_pv.c
> +++ b/arch/x86/xen/enlighten_pv.c
> @@ -596,7 +596,7 @@ struct trap_array_entry {
>
> static struct trap_array_entry trap_array[] = {
> { debug, xen_xendebug, true },
> - { int3, xen_xenint3, true },
> + { int3, xen_int3, true },
> { double_fault, xen_double_fault, true },
> #ifdef CONFIG_X86_MCE
> { machine_check, xen_machine_check, true },
I'm confused on the purpose of trap_array[], could you elucidate me?
The sole user seems to be get_trap_addr() and that talks about ISTs, but
#BP isn't an IST anymore, so why does it have ist_okay=true?
next prev parent reply other threads:[~2019-07-12 12:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 8:15 [Xen-devel] [PATCH v2] xen/pv: Fix a boot up hang revealed by int3 self test Zhenzhong Duan
2019-07-11 8:15 ` Zhenzhong Duan
2019-07-12 12:06 ` Peter Zijlstra [this message]
2019-07-12 12:06 ` Peter Zijlstra
2019-07-12 13:04 ` [Xen-devel] " Zhenzhong Duan
2019-07-12 13:04 ` Zhenzhong Duan
2019-07-12 13:09 ` [Xen-devel] " Peter Zijlstra
2019-07-12 13:09 ` Peter Zijlstra
2019-07-12 13:17 ` [Xen-devel] " Peter Zijlstra
2019-07-12 13:17 ` Peter Zijlstra
2019-07-12 13:27 ` [Xen-devel] " Zhenzhong Duan
2019-07-12 13:27 ` Zhenzhong Duan
2019-07-12 14:06 ` [Xen-devel] " Andrew Cooper
2019-07-12 14:06 ` Andrew Cooper
2019-07-15 5:05 ` Zhenzhong Duan
2019-07-15 5:05 ` Zhenzhong Duan
2019-07-15 6:54 ` Jan Beulich
2019-07-15 6:54 ` Jan Beulich
2019-07-15 9:09 ` Andrew Cooper
2019-07-15 9:09 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712120626.GW3402@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=srinivas.eeda@oracle.com \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=zhenzhong.duan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.