From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
qemu-riscv@nongnu.org, "Palmer Dabbelt" <palmer@sifive.com>,
"Richard Henderson" <rth@twiddle.net>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Thomas Huth" <thuth@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Alistair Francis" <Alistair.Francis@wdc.com>,
qemu-ppc@nongnu.org, "Artyom Tarasenko" <atar4qemu@gmail.com>,
qemu-arm@nongnu.org, "Helge Deller" <deller@gmx.de>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [Qemu-riscv] [PATCH-for-4.2 2/3] hw/usb/Kconfig: Add CONFIG_USB_EHCI_PCI
Date: Mon, 15 Jul 2019 11:55:44 +0200 [thread overview]
Message-ID: <20190715095545.28545-3-philmd@redhat.com> (raw)
In-Reply-To: <20190715095545.28545-1-philmd@redhat.com>
The USB_EHCI entry currently include PCI code. Since the EHCI
implementation is already split in sysbus/PCI, add a new
USB_EHCI_PCI. There are no logical changes, but the Kconfig
dependencies tree is cleaner.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/usb/Kconfig | 9 ++++++---
hw/usb/Makefile.objs | 5 +++--
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
index 564305e283..495c6f2d48 100644
--- a/hw/usb/Kconfig
+++ b/hw/usb/Kconfig
@@ -19,13 +19,16 @@ config USB_OHCI_PCI
config USB_EHCI
bool
- default y if PCI_DEVICES
- depends on PCI
select USB
+config USB_EHCI_PCI
+ bool
+ default y if PCI_DEVICES
+ select USB_EHCI
+
config USB_EHCI_SYSBUS
bool
- select USB
+ select USB_EHCI
config USB_XHCI
bool
diff --git a/hw/usb/Makefile.objs b/hw/usb/Makefile.objs
index 81688f6e70..303ac084a0 100644
--- a/hw/usb/Makefile.objs
+++ b/hw/usb/Makefile.objs
@@ -6,8 +6,9 @@ common-obj-$(CONFIG_USB) += desc.o desc-msos.o
common-obj-$(CONFIG_USB_UHCI) += hcd-uhci.o
common-obj-$(CONFIG_USB_OHCI) += hcd-ohci.o
common-obj-$(CONFIG_USB_OHCI_PCI) += hcd-ohci-pci.o
-common-obj-$(CONFIG_USB_EHCI) += hcd-ehci.o hcd-ehci-pci.o
-common-obj-$(CONFIG_USB_EHCI_SYSBUS) += hcd-ehci.o hcd-ehci-sysbus.o
+common-obj-$(CONFIG_USB_EHCI) += hcd-ehci.o
+common-obj-$(CONFIG_USB_EHCI_PCI) += hcd-ehci-pci.o
+common-obj-$(CONFIG_USB_EHCI_SYSBUS) += hcd-ehci-sysbus.o
common-obj-$(CONFIG_USB_XHCI) += hcd-xhci.o
common-obj-$(CONFIG_USB_XHCI_NEC) += hcd-xhci-nec.o
common-obj-$(CONFIG_USB_MUSB) += hcd-musb.o
--
2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
qemu-riscv@nongnu.org, "Eduardo Habkost" <ehabkost@redhat.com>,
"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-ppc@nongnu.org,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Helge Deller" <deller@gmx.de>,
"Palmer Dabbelt" <palmer@sifive.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
qemu-arm@nongnu.org,
"Alistair Francis" <Alistair.Francis@wdc.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Richard Henderson" <rth@twiddle.net>
Subject: [Qemu-arm] [PATCH-for-4.2 2/3] hw/usb/Kconfig: Add CONFIG_USB_EHCI_PCI
Date: Mon, 15 Jul 2019 11:55:44 +0200 [thread overview]
Message-ID: <20190715095545.28545-3-philmd@redhat.com> (raw)
In-Reply-To: <20190715095545.28545-1-philmd@redhat.com>
The USB_EHCI entry currently include PCI code. Since the EHCI
implementation is already split in sysbus/PCI, add a new
USB_EHCI_PCI. There are no logical changes, but the Kconfig
dependencies tree is cleaner.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/usb/Kconfig | 9 ++++++---
hw/usb/Makefile.objs | 5 +++--
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
index 564305e283..495c6f2d48 100644
--- a/hw/usb/Kconfig
+++ b/hw/usb/Kconfig
@@ -19,13 +19,16 @@ config USB_OHCI_PCI
config USB_EHCI
bool
- default y if PCI_DEVICES
- depends on PCI
select USB
+config USB_EHCI_PCI
+ bool
+ default y if PCI_DEVICES
+ select USB_EHCI
+
config USB_EHCI_SYSBUS
bool
- select USB
+ select USB_EHCI
config USB_XHCI
bool
diff --git a/hw/usb/Makefile.objs b/hw/usb/Makefile.objs
index 81688f6e70..303ac084a0 100644
--- a/hw/usb/Makefile.objs
+++ b/hw/usb/Makefile.objs
@@ -6,8 +6,9 @@ common-obj-$(CONFIG_USB) += desc.o desc-msos.o
common-obj-$(CONFIG_USB_UHCI) += hcd-uhci.o
common-obj-$(CONFIG_USB_OHCI) += hcd-ohci.o
common-obj-$(CONFIG_USB_OHCI_PCI) += hcd-ohci-pci.o
-common-obj-$(CONFIG_USB_EHCI) += hcd-ehci.o hcd-ehci-pci.o
-common-obj-$(CONFIG_USB_EHCI_SYSBUS) += hcd-ehci.o hcd-ehci-sysbus.o
+common-obj-$(CONFIG_USB_EHCI) += hcd-ehci.o
+common-obj-$(CONFIG_USB_EHCI_PCI) += hcd-ehci-pci.o
+common-obj-$(CONFIG_USB_EHCI_SYSBUS) += hcd-ehci-sysbus.o
common-obj-$(CONFIG_USB_XHCI) += hcd-xhci.o
common-obj-$(CONFIG_USB_XHCI_NEC) += hcd-xhci-nec.o
common-obj-$(CONFIG_USB_MUSB) += hcd-musb.o
--
2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
qemu-riscv@nongnu.org, "Eduardo Habkost" <ehabkost@redhat.com>,
"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-ppc@nongnu.org,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Helge Deller" <deller@gmx.de>,
"Palmer Dabbelt" <palmer@sifive.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
qemu-arm@nongnu.org,
"Alistair Francis" <Alistair.Francis@wdc.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Richard Henderson" <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH-for-4.2 2/3] hw/usb/Kconfig: Add CONFIG_USB_EHCI_PCI
Date: Mon, 15 Jul 2019 11:55:44 +0200 [thread overview]
Message-ID: <20190715095545.28545-3-philmd@redhat.com> (raw)
In-Reply-To: <20190715095545.28545-1-philmd@redhat.com>
The USB_EHCI entry currently include PCI code. Since the EHCI
implementation is already split in sysbus/PCI, add a new
USB_EHCI_PCI. There are no logical changes, but the Kconfig
dependencies tree is cleaner.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/usb/Kconfig | 9 ++++++---
hw/usb/Makefile.objs | 5 +++--
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
index 564305e283..495c6f2d48 100644
--- a/hw/usb/Kconfig
+++ b/hw/usb/Kconfig
@@ -19,13 +19,16 @@ config USB_OHCI_PCI
config USB_EHCI
bool
- default y if PCI_DEVICES
- depends on PCI
select USB
+config USB_EHCI_PCI
+ bool
+ default y if PCI_DEVICES
+ select USB_EHCI
+
config USB_EHCI_SYSBUS
bool
- select USB
+ select USB_EHCI
config USB_XHCI
bool
diff --git a/hw/usb/Makefile.objs b/hw/usb/Makefile.objs
index 81688f6e70..303ac084a0 100644
--- a/hw/usb/Makefile.objs
+++ b/hw/usb/Makefile.objs
@@ -6,8 +6,9 @@ common-obj-$(CONFIG_USB) += desc.o desc-msos.o
common-obj-$(CONFIG_USB_UHCI) += hcd-uhci.o
common-obj-$(CONFIG_USB_OHCI) += hcd-ohci.o
common-obj-$(CONFIG_USB_OHCI_PCI) += hcd-ohci-pci.o
-common-obj-$(CONFIG_USB_EHCI) += hcd-ehci.o hcd-ehci-pci.o
-common-obj-$(CONFIG_USB_EHCI_SYSBUS) += hcd-ehci.o hcd-ehci-sysbus.o
+common-obj-$(CONFIG_USB_EHCI) += hcd-ehci.o
+common-obj-$(CONFIG_USB_EHCI_PCI) += hcd-ehci-pci.o
+common-obj-$(CONFIG_USB_EHCI_SYSBUS) += hcd-ehci-sysbus.o
common-obj-$(CONFIG_USB_XHCI) += hcd-xhci.o
common-obj-$(CONFIG_USB_XHCI_NEC) += hcd-xhci-nec.o
common-obj-$(CONFIG_USB_MUSB) += hcd-musb.o
--
2.20.1
next prev parent reply other threads:[~2019-07-15 9:56 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 9:55 [Qemu-riscv] [PATCH 0/3] hw/Kconfig: PCI & USB fixes Philippe Mathieu-Daudé
2019-07-15 9:55 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-15 9:55 ` [Qemu-arm] " Philippe Mathieu-Daudé
2019-07-15 9:55 ` [Qemu-riscv] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES Philippe Mathieu-Daudé
2019-07-15 9:55 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-15 9:55 ` [Qemu-arm] " Philippe Mathieu-Daudé
2019-07-15 10:15 ` [Qemu-riscv] " Thomas Huth
2019-07-15 10:15 ` [Qemu-devel] " Thomas Huth
2019-07-15 10:15 ` [Qemu-arm] " Thomas Huth
2019-07-15 10:19 ` [Qemu-riscv] " Peter Maydell
2019-07-15 10:19 ` [Qemu-devel] " Peter Maydell
2019-07-15 10:19 ` [Qemu-arm] " Peter Maydell
2019-07-15 10:48 ` [Qemu-riscv] " Thomas Huth
2019-07-15 10:48 ` [Qemu-devel] " Thomas Huth
2019-07-15 10:48 ` [Qemu-arm] " Thomas Huth
2019-07-15 10:56 ` [Qemu-riscv] [qemu-s390x] " Cornelia Huck
2019-07-15 10:56 ` [Qemu-devel] " Cornelia Huck
2019-07-15 10:56 ` [Qemu-arm] " Cornelia Huck
2019-07-15 11:04 ` [Qemu-riscv] " Philippe Mathieu-Daudé
2019-07-15 11:04 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-15 11:04 ` [Qemu-arm] " Philippe Mathieu-Daudé
2019-07-15 11:09 ` [Qemu-riscv] " Cornelia Huck
2019-07-15 11:09 ` [Qemu-devel] " Cornelia Huck
2019-07-15 11:09 ` [Qemu-arm] " Cornelia Huck
2019-07-15 13:19 ` [Qemu-riscv] " Thomas Huth
2019-07-15 13:19 ` [Qemu-devel] " Thomas Huth
2019-07-15 13:19 ` [Qemu-arm] " Thomas Huth
2019-07-15 13:38 ` [Qemu-riscv] " Philippe Mathieu-Daudé
2019-07-15 13:38 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-15 13:38 ` [Qemu-arm] " Philippe Mathieu-Daudé
2019-07-15 13:49 ` [Qemu-riscv] " Thomas Huth
2019-07-15 13:49 ` [Qemu-devel] " Thomas Huth
2019-07-15 13:49 ` [Qemu-arm] " Thomas Huth
2019-07-15 16:08 ` [Qemu-riscv] [Qemu-devel] " Markus Armbruster
2019-07-15 16:08 ` Markus Armbruster
2019-07-15 16:08 ` [Qemu-arm] " Markus Armbruster
2019-07-15 16:12 ` [Qemu-riscv] " Cornelia Huck
2019-07-15 16:12 ` Cornelia Huck
2019-07-15 16:12 ` [Qemu-arm] " Cornelia Huck
2019-07-15 18:22 ` [Qemu-riscv] " Paolo Bonzini
2019-07-15 18:22 ` Paolo Bonzini
2019-07-15 18:22 ` [Qemu-arm] " Paolo Bonzini
2019-07-16 13:06 ` [Qemu-riscv] " Markus Armbruster
2019-07-16 13:06 ` Markus Armbruster
2019-07-16 13:06 ` [Qemu-arm] " Markus Armbruster
2019-07-16 15:04 ` [Qemu-riscv] " Thomas Huth
2019-07-16 15:04 ` Thomas Huth
2019-07-16 15:04 ` [Qemu-arm] " Thomas Huth
2019-07-17 12:59 ` [Qemu-riscv] " Collin Walling
2019-07-17 12:59 ` Collin Walling
2019-07-17 13:52 ` [Qemu-riscv] " Paolo Bonzini
2019-07-17 13:52 ` Paolo Bonzini
2019-07-17 13:52 ` [Qemu-arm] " Paolo Bonzini
2019-07-17 14:54 ` [Qemu-riscv] " Collin Walling
2019-07-17 14:54 ` Collin Walling
2019-07-17 14:54 ` [Qemu-arm] " Collin Walling
2019-07-17 15:04 ` [Qemu-riscv] " Paolo Bonzini
2019-07-17 15:04 ` Paolo Bonzini
2019-07-17 15:04 ` [Qemu-arm] " Paolo Bonzini
2019-07-18 15:33 ` [Qemu-riscv] " Cornelia Huck
2019-07-18 15:33 ` Cornelia Huck
2019-07-18 15:33 ` [Qemu-arm] " Cornelia Huck
2019-07-22 13:40 ` [Qemu-riscv] " Markus Armbruster
2019-07-22 13:40 ` Markus Armbruster
2019-07-22 13:40 ` [Qemu-arm] " Markus Armbruster
2019-07-15 9:55 ` Philippe Mathieu-Daudé [this message]
2019-07-15 9:55 ` [Qemu-devel] [PATCH-for-4.2 2/3] hw/usb/Kconfig: Add CONFIG_USB_EHCI_PCI Philippe Mathieu-Daudé
2019-07-15 9:55 ` [Qemu-arm] " Philippe Mathieu-Daudé
2019-07-15 10:54 ` [Qemu-riscv] [Qemu-ppc] " BALATON Zoltan
2019-07-15 10:54 ` [Qemu-devel] " BALATON Zoltan
2019-07-15 10:54 ` [Qemu-arm] " BALATON Zoltan
2019-07-15 11:03 ` [Qemu-riscv] " Thomas Huth
2019-07-15 11:03 ` [Qemu-devel] " Thomas Huth
2019-07-15 11:03 ` [Qemu-arm] " Thomas Huth
2019-07-15 11:10 ` [Qemu-riscv] " BALATON Zoltan
2019-07-15 11:10 ` [Qemu-devel] " BALATON Zoltan
2019-07-15 11:19 ` [Qemu-riscv] " Thomas Huth
2019-07-15 11:19 ` [Qemu-devel] " Thomas Huth
2019-07-15 11:19 ` [Qemu-arm] " Thomas Huth
2019-07-15 11:20 ` [Qemu-riscv] " Paolo Bonzini
2019-07-15 11:20 ` [Qemu-devel] " Paolo Bonzini
2019-07-15 11:20 ` [Qemu-arm] " Paolo Bonzini
2019-07-15 11:01 ` [Qemu-riscv] " Thomas Huth
2019-07-15 11:01 ` [Qemu-devel] " Thomas Huth
2019-07-15 11:01 ` [Qemu-arm] " Thomas Huth
2019-07-15 9:55 ` [Qemu-riscv] [PATCH-for-4.1? 3/3] hw/usb/Kconfig: USB_XHCI_NEC requires USB_XHCI Philippe Mathieu-Daudé
2019-07-15 9:55 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-15 9:55 ` [Qemu-arm] " Philippe Mathieu-Daudé
2019-07-15 10:50 ` [Qemu-trivial] " Thomas Huth
2019-07-15 10:50 ` [Qemu-devel] " Thomas Huth
2019-07-15 10:50 ` [Qemu-arm] " Thomas Huth
2019-07-15 10:50 ` [Qemu-riscv] " Thomas Huth
2019-07-15 11:21 ` [Qemu-riscv] [PATCH 0/3] hw/Kconfig: PCI & USB fixes Paolo Bonzini
2019-07-15 11:21 ` [Qemu-devel] " Paolo Bonzini
2019-07-15 11:21 ` [Qemu-arm] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715095545.28545-3-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=david@gibson.dropbear.id.au \
--cc=deller@gmx.de \
--cc=ehabkost@redhat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=kraxel@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=palmer@sifive.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=rth@twiddle.net \
--cc=sagark@eecs.berkeley.edu \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.