All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Collin Walling" <walling@linux.ibm.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Palmer Dabbelt" <palmer@sifive.com>,
	"open list:RISC-V" <qemu-riscv@nongnu.org>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Helge Deller" <deller@gmx.de>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"open list:S390" <qemu-s390x@nongnu.org>,
	qemu-arm <qemu-arm@nongnu.org>,
	"Alistair Francis" <Alistair.Francis@wdc.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	qemu-ppc <qemu-ppc@nongnu.org>,
	"Richard Henderson" <rth@twiddle.net>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Artyom Tarasenko" <atar4qemu@gmail.com>,
	"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-riscv] [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES
Date: Thu, 18 Jul 2019 17:33:08 +0200	[thread overview]
Message-ID: <20190718173308.224f01a9.cohuck@redhat.com> (raw)
In-Reply-To: <a88a7f65-60c2-22a8-5523-faedabc06b44@redhat.com>

On Wed, 17 Jul 2019 17:04:54 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> On 17/07/19 16:54, Collin Walling wrote:
> > PCI host plugging will check for the MSI-X capability on the
> > PCI device. If the MSI-X cap is missing, we fail device plugging.
> > We do not check for MSI. Only MSI-X.
> > 
> > Specifically, the capability is represented by PCI_CAP_ID_MSIX
> > in pci_regs.h  
> 
> The code in Linux says that single MSIs are supported too:
> 
>        if (type == PCI_CAP_ID_MSI && nvec > 1)
>                return 1;

Interestingly, the check for MSI-X in QEMU seems to have been
introduced in 857cc71985dc ("s390x/pci: merge msix init functions"),
but that commit does not give a rationale (maybe it just referred to the
existing code structure?)

A quick look through the code suggests that single MSIs should be
supportable; can someone with access to the details verify?


WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Collin Walling" <walling@linux.ibm.com>,
	"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Palmer Dabbelt" <palmer@sifive.com>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Alistair Francis" <Alistair.Francis@wdc.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Helge Deller" <deller@gmx.de>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Artyom Tarasenko" <atar4qemu@gmail.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"open list:S390" <qemu-s390x@nongnu.org>,
	qemu-arm <qemu-arm@nongnu.org>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"open list:RISC-V" <qemu-riscv@nongnu.org>,
	qemu-ppc <qemu-ppc@nongnu.org>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [Qemu-arm] [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES
Date: Thu, 18 Jul 2019 17:33:08 +0200	[thread overview]
Message-ID: <20190718173308.224f01a9.cohuck@redhat.com> (raw)
In-Reply-To: <a88a7f65-60c2-22a8-5523-faedabc06b44@redhat.com>

On Wed, 17 Jul 2019 17:04:54 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> On 17/07/19 16:54, Collin Walling wrote:
> > PCI host plugging will check for the MSI-X capability on the
> > PCI device. If the MSI-X cap is missing, we fail device plugging.
> > We do not check for MSI. Only MSI-X.
> > 
> > Specifically, the capability is represented by PCI_CAP_ID_MSIX
> > in pci_regs.h  
> 
> The code in Linux says that single MSIs are supported too:
> 
>        if (type == PCI_CAP_ID_MSI && nvec > 1)
>                return 1;

Interestingly, the check for MSI-X in QEMU seems to have been
introduced in 857cc71985dc ("s390x/pci: merge msix init functions"),
but that commit does not give a rationale (maybe it just referred to the
existing code structure?)

A quick look through the code suggests that single MSIs should be
supportable; can someone with access to the details verify?

WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Collin Walling" <walling@linux.ibm.com>,
	"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Palmer Dabbelt" <palmer@sifive.com>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Alistair Francis" <Alistair.Francis@wdc.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Helge Deller" <deller@gmx.de>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Artyom Tarasenko" <atar4qemu@gmail.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"open list:S390" <qemu-s390x@nongnu.org>,
	qemu-arm <qemu-arm@nongnu.org>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"open list:RISC-V" <qemu-riscv@nongnu.org>,
	qemu-ppc <qemu-ppc@nongnu.org>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES
Date: Thu, 18 Jul 2019 17:33:08 +0200	[thread overview]
Message-ID: <20190718173308.224f01a9.cohuck@redhat.com> (raw)
In-Reply-To: <a88a7f65-60c2-22a8-5523-faedabc06b44@redhat.com>

On Wed, 17 Jul 2019 17:04:54 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> On 17/07/19 16:54, Collin Walling wrote:
> > PCI host plugging will check for the MSI-X capability on the
> > PCI device. If the MSI-X cap is missing, we fail device plugging.
> > We do not check for MSI. Only MSI-X.
> > 
> > Specifically, the capability is represented by PCI_CAP_ID_MSIX
> > in pci_regs.h  
> 
> The code in Linux says that single MSIs are supported too:
> 
>        if (type == PCI_CAP_ID_MSI && nvec > 1)
>                return 1;

Interestingly, the check for MSI-X in QEMU seems to have been
introduced in 857cc71985dc ("s390x/pci: merge msix init functions"),
but that commit does not give a rationale (maybe it just referred to the
existing code structure?)

A quick look through the code suggests that single MSIs should be
supportable; can someone with access to the details verify?


  reply	other threads:[~2019-07-18 15:33 UTC|newest]

Thread overview: 95+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-15  9:55 [Qemu-riscv] [PATCH 0/3] hw/Kconfig: PCI & USB fixes Philippe Mathieu-Daudé
2019-07-15  9:55 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-15  9:55 ` [Qemu-arm] " Philippe Mathieu-Daudé
2019-07-15  9:55 ` [Qemu-riscv] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES Philippe Mathieu-Daudé
2019-07-15  9:55   ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-15  9:55   ` [Qemu-arm] " Philippe Mathieu-Daudé
2019-07-15 10:15   ` [Qemu-riscv] " Thomas Huth
2019-07-15 10:15     ` [Qemu-devel] " Thomas Huth
2019-07-15 10:15     ` [Qemu-arm] " Thomas Huth
2019-07-15 10:19     ` [Qemu-riscv] " Peter Maydell
2019-07-15 10:19       ` [Qemu-devel] " Peter Maydell
2019-07-15 10:19       ` [Qemu-arm] " Peter Maydell
2019-07-15 10:48       ` [Qemu-riscv] " Thomas Huth
2019-07-15 10:48         ` [Qemu-devel] " Thomas Huth
2019-07-15 10:48         ` [Qemu-arm] " Thomas Huth
2019-07-15 10:56         ` [Qemu-riscv] [qemu-s390x] " Cornelia Huck
2019-07-15 10:56           ` [Qemu-devel] " Cornelia Huck
2019-07-15 10:56           ` [Qemu-arm] " Cornelia Huck
2019-07-15 11:04           ` [Qemu-riscv] " Philippe Mathieu-Daudé
2019-07-15 11:04             ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-15 11:04             ` [Qemu-arm] " Philippe Mathieu-Daudé
2019-07-15 11:09             ` [Qemu-riscv] " Cornelia Huck
2019-07-15 11:09               ` [Qemu-devel] " Cornelia Huck
2019-07-15 11:09               ` [Qemu-arm] " Cornelia Huck
2019-07-15 13:19               ` [Qemu-riscv] " Thomas Huth
2019-07-15 13:19                 ` [Qemu-devel] " Thomas Huth
2019-07-15 13:19                 ` [Qemu-arm] " Thomas Huth
2019-07-15 13:38                 ` [Qemu-riscv] " Philippe Mathieu-Daudé
2019-07-15 13:38                   ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-15 13:38                   ` [Qemu-arm] " Philippe Mathieu-Daudé
2019-07-15 13:49                   ` [Qemu-riscv] " Thomas Huth
2019-07-15 13:49                     ` [Qemu-devel] " Thomas Huth
2019-07-15 13:49                     ` [Qemu-arm] " Thomas Huth
2019-07-15 16:08                   ` [Qemu-riscv] [Qemu-devel] " Markus Armbruster
2019-07-15 16:08                     ` Markus Armbruster
2019-07-15 16:08                     ` [Qemu-arm] " Markus Armbruster
2019-07-15 16:12                     ` [Qemu-riscv] " Cornelia Huck
2019-07-15 16:12                       ` Cornelia Huck
2019-07-15 16:12                       ` [Qemu-arm] " Cornelia Huck
2019-07-15 18:22                       ` [Qemu-riscv] " Paolo Bonzini
2019-07-15 18:22                         ` Paolo Bonzini
2019-07-15 18:22                         ` [Qemu-arm] " Paolo Bonzini
2019-07-16 13:06                         ` [Qemu-riscv] " Markus Armbruster
2019-07-16 13:06                           ` Markus Armbruster
2019-07-16 13:06                           ` [Qemu-arm] " Markus Armbruster
2019-07-16 15:04                           ` [Qemu-riscv] " Thomas Huth
2019-07-16 15:04                             ` Thomas Huth
2019-07-16 15:04                             ` [Qemu-arm] " Thomas Huth
2019-07-17 12:59                             ` [Qemu-riscv] " Collin Walling
2019-07-17 12:59                               ` Collin Walling
2019-07-17 13:52                               ` [Qemu-riscv] " Paolo Bonzini
2019-07-17 13:52                                 ` Paolo Bonzini
2019-07-17 13:52                                 ` [Qemu-arm] " Paolo Bonzini
2019-07-17 14:54                                 ` [Qemu-riscv] " Collin Walling
2019-07-17 14:54                                   ` Collin Walling
2019-07-17 14:54                                   ` [Qemu-arm] " Collin Walling
2019-07-17 15:04                                   ` [Qemu-riscv] " Paolo Bonzini
2019-07-17 15:04                                     ` Paolo Bonzini
2019-07-17 15:04                                     ` [Qemu-arm] " Paolo Bonzini
2019-07-18 15:33                                     ` Cornelia Huck [this message]
2019-07-18 15:33                                       ` Cornelia Huck
2019-07-18 15:33                                       ` [Qemu-arm] " Cornelia Huck
2019-07-22 13:40                             ` [Qemu-riscv] " Markus Armbruster
2019-07-22 13:40                               ` Markus Armbruster
2019-07-22 13:40                               ` [Qemu-arm] " Markus Armbruster
2019-07-15  9:55 ` [Qemu-riscv] [PATCH-for-4.2 2/3] hw/usb/Kconfig: Add CONFIG_USB_EHCI_PCI Philippe Mathieu-Daudé
2019-07-15  9:55   ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-15  9:55   ` [Qemu-arm] " Philippe Mathieu-Daudé
2019-07-15 10:54   ` [Qemu-riscv] [Qemu-ppc] " BALATON Zoltan
2019-07-15 10:54     ` [Qemu-devel] " BALATON Zoltan
2019-07-15 10:54     ` [Qemu-arm] " BALATON Zoltan
2019-07-15 11:03     ` [Qemu-riscv] " Thomas Huth
2019-07-15 11:03       ` [Qemu-devel] " Thomas Huth
2019-07-15 11:03       ` [Qemu-arm] " Thomas Huth
2019-07-15 11:10       ` [Qemu-riscv] " BALATON Zoltan
2019-07-15 11:10         ` [Qemu-devel] " BALATON Zoltan
2019-07-15 11:19         ` [Qemu-riscv] " Thomas Huth
2019-07-15 11:19           ` [Qemu-devel] " Thomas Huth
2019-07-15 11:19           ` [Qemu-arm] " Thomas Huth
2019-07-15 11:20         ` [Qemu-riscv] " Paolo Bonzini
2019-07-15 11:20           ` [Qemu-devel] " Paolo Bonzini
2019-07-15 11:20           ` [Qemu-arm] " Paolo Bonzini
2019-07-15 11:01   ` [Qemu-riscv] " Thomas Huth
2019-07-15 11:01     ` [Qemu-devel] " Thomas Huth
2019-07-15 11:01     ` [Qemu-arm] " Thomas Huth
2019-07-15  9:55 ` [Qemu-riscv] [PATCH-for-4.1? 3/3] hw/usb/Kconfig: USB_XHCI_NEC requires USB_XHCI Philippe Mathieu-Daudé
2019-07-15  9:55   ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-15  9:55   ` [Qemu-arm] " Philippe Mathieu-Daudé
2019-07-15 10:50   ` [Qemu-trivial] " Thomas Huth
2019-07-15 10:50     ` [Qemu-devel] " Thomas Huth
2019-07-15 10:50     ` [Qemu-arm] " Thomas Huth
2019-07-15 10:50     ` [Qemu-riscv] " Thomas Huth
2019-07-15 11:21 ` [Qemu-riscv] [PATCH 0/3] hw/Kconfig: PCI & USB fixes Paolo Bonzini
2019-07-15 11:21   ` [Qemu-devel] " Paolo Bonzini
2019-07-15 11:21   ` [Qemu-arm] " Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190718173308.224f01a9.cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=Alistair.Francis@wdc.com \
    --cc=armbru@redhat.com \
    --cc=atar4qemu@gmail.com \
    --cc=aurelien@aurel32.net \
    --cc=david@gibson.dropbear.id.au \
    --cc=deller@gmx.de \
    --cc=ehabkost@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=mst@redhat.com \
    --cc=palmer@sifive.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=sagark@eecs.berkeley.edu \
    --cc=thuth@redhat.com \
    --cc=walling@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.