All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Paul <sean@poorly.run>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: "David Airlie" <airlied@linux.ie>,
	"Liviu Dudau" <Liviu.Dudau@arm.com>,
	dri-devel@lists.freedesktop.org,
	"Maxime Ripard" <maxime.ripard@bootlin.com>,
	"Thierry Reding" <treding@nvidia.com>,
	"Jani Nikula" <jani.nikula@intel.com>,
	"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
	"Boris Brezillon" <boris.brezillon@bootlin.com>,
	linux-mediatek@lists.infradead.org,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Sean Paul" <sean@poorly.run>,
	linux-arm-kernel@lists.infradead.org,
	"Boris Brezillon" <bbrezillon@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH v1 01/11] drm/panel: make drm_panel.h self-contained
Date: Thu, 18 Jul 2019 13:36:34 -0400	[thread overview]
Message-ID: <20190718173634.GD31819@art_vandelay> (raw)
In-Reply-To: <20190718161507.2047-2-sam@ravnborg.org>

On Thu, Jul 18, 2019 at 06:14:57PM +0200, Sam Ravnborg wrote:
> From: Jani Nikula <jani.nikula@intel.com>
> 
> Fix build warning if drm_panel.h is built with CONFIG_OF=n or
> CONFIG_DRM_PANEL=n and included without the prerequisite err.h:
> 
> ./include/drm/drm_panel.h: In function ‘of_drm_find_panel’:
> ./include/drm/drm_panel.h:203:9: error: implicit declaration of function ‘ERR_PTR’ [-Werror=implicit-function-declaration]
>   return ERR_PTR(-ENODEV);
>          ^~~~~~~
> ./include/drm/drm_panel.h:203:9: error: returning ‘int’ from a function with return type ‘struct drm_panel *’ makes pointer from integer without a cast [-Werror=int-conversion]
>   return ERR_PTR(-ENODEV);
>          ^~~~~~~~~~~~~~~~
> 
> Fixes: 5fa8e4a22182 ("drm/panel: Make of_drm_find_panel() return an ERR_PTR() instead of NULL")
> Cc: Boris Brezillon <boris.brezillon@bootlin.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> Acked-by: Thierry Reding <treding@nvidia.com>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

Reviewed-by: Sean Paul <sean@poorly.run>

> ---
>  include/drm/drm_panel.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h
> index 8c738c0e6e9f..26377836141c 100644
> --- a/include/drm/drm_panel.h
> +++ b/include/drm/drm_panel.h
> @@ -24,6 +24,7 @@
>  #ifndef __DRM_PANEL_H__
>  #define __DRM_PANEL_H__
>  
> +#include <linux/err.h>
>  #include <linux/errno.h>
>  #include <linux/list.h>
>  
> -- 
> 2.20.1
> 

-- 
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Sean Paul <sean@poorly.run>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: "David Airlie" <airlied@linux.ie>,
	"Liviu Dudau" <Liviu.Dudau@arm.com>,
	dri-devel@lists.freedesktop.org,
	"Chris Wilson" <chris@chris-wilson.co.uk>,
	"Eric Anholt" <eric@anholt.net>, "Rob Herring" <robh@kernel.org>,
	"Stefan Agner" <stefan@agner.ch>,
	"Maxime Ripard" <maxime.ripard@bootlin.com>,
	"CK Hu" <ck.hu@mediatek.com>,
	"Thierry Reding" <treding@nvidia.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Chunming Zhou" <david1.zhou@amd.com>,
	"Jani Nikula" <jani.nikula@intel.com>,
	"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Boris Brezillon" <boris.brezillon@bootlin.com>,
	linux-mediatek@lists.infradead.org,
	"Lionel Landwerlin" <lionel.g.landwerlin@intel.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Sean Paul" <sean@poorly.run>,
	linux-arm-kernel@lists.infradead.org,
	"Boris Brezillon" <bbrezillon@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Rob Clark" <robdclark@gmail.com>,
	"Noralf Trønnes" <noralf@tronnes.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH v1 01/11] drm/panel: make drm_panel.h self-contained
Date: Thu, 18 Jul 2019 13:36:34 -0400	[thread overview]
Message-ID: <20190718173634.GD31819@art_vandelay> (raw)
In-Reply-To: <20190718161507.2047-2-sam@ravnborg.org>

On Thu, Jul 18, 2019 at 06:14:57PM +0200, Sam Ravnborg wrote:
> From: Jani Nikula <jani.nikula@intel.com>
> 
> Fix build warning if drm_panel.h is built with CONFIG_OF=n or
> CONFIG_DRM_PANEL=n and included without the prerequisite err.h:
> 
> ./include/drm/drm_panel.h: In function ‘of_drm_find_panel’:
> ./include/drm/drm_panel.h:203:9: error: implicit declaration of function ‘ERR_PTR’ [-Werror=implicit-function-declaration]
>   return ERR_PTR(-ENODEV);
>          ^~~~~~~
> ./include/drm/drm_panel.h:203:9: error: returning ‘int’ from a function with return type ‘struct drm_panel *’ makes pointer from integer without a cast [-Werror=int-conversion]
>   return ERR_PTR(-ENODEV);
>          ^~~~~~~~~~~~~~~~
> 
> Fixes: 5fa8e4a22182 ("drm/panel: Make of_drm_find_panel() return an ERR_PTR() instead of NULL")
> Cc: Boris Brezillon <boris.brezillon@bootlin.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> Acked-by: Thierry Reding <treding@nvidia.com>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

Reviewed-by: Sean Paul <sean@poorly.run>

> ---
>  include/drm/drm_panel.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h
> index 8c738c0e6e9f..26377836141c 100644
> --- a/include/drm/drm_panel.h
> +++ b/include/drm/drm_panel.h
> @@ -24,6 +24,7 @@
>  #ifndef __DRM_PANEL_H__
>  #define __DRM_PANEL_H__
>  
> +#include <linux/err.h>
>  #include <linux/errno.h>
>  #include <linux/list.h>
>  
> -- 
> 2.20.1
> 

-- 
Sean Paul, Software Engineer, Google / Chromium OS

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-07-18 17:36 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-18 16:14 [PATCH v1 0/11] drm: header maintenance Sam Ravnborg
2019-07-18 16:14 ` Sam Ravnborg
2019-07-18 16:14 ` [PATCH v1 01/11] drm/panel: make drm_panel.h self-contained Sam Ravnborg
2019-07-18 16:14   ` Sam Ravnborg
2019-07-18 17:36   ` Sean Paul [this message]
2019-07-18 17:36     ` Sean Paul
2019-07-18 16:14 ` [PATCH v1 02/11] drm: drop uapi dependency from drm_print.h Sam Ravnborg
2019-07-18 16:14   ` Sam Ravnborg
2019-07-18 16:46   ` Chris Wilson
2019-07-18 16:46     ` Chris Wilson
2019-07-19  6:54     ` Koenig, Christian
2019-07-19  6:54       ` Koenig, Christian
2019-07-29 12:45       ` Jani Nikula
2019-07-29 12:45         ` Jani Nikula
2019-07-29 14:35         ` Sam Ravnborg
2019-07-29 14:35           ` Sam Ravnborg
2019-07-29 15:28           ` Koenig, Christian
2019-07-29 15:28             ` Koenig, Christian
2019-07-29 17:50             ` Sam Ravnborg
2019-07-29 17:50               ` Sam Ravnborg
2019-08-02 13:48               ` Jani Nikula
2019-08-02 13:48                 ` [Intel-gfx] " Jani Nikula
2019-08-02 15:28                 ` Sam Ravnborg
2019-08-02 15:28                   ` [Intel-gfx] " Sam Ravnborg
2019-07-18 17:40   ` Sean Paul
2019-07-18 17:40     ` Sean Paul
2019-07-18 16:14 ` [PATCH v1 03/11] drm: drop uapi dependency from drm_vblank.h Sam Ravnborg
2019-07-18 16:14   ` Sam Ravnborg
2019-07-18 17:41   ` Sean Paul
2019-07-18 17:41     ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 04/11] drm/ati_pcigart: drop dependency on drm_os_linux.h Sam Ravnborg
2019-07-18 16:15   ` Sam Ravnborg
2019-07-18 17:49   ` Sean Paul
2019-07-18 17:49     ` Sean Paul
2019-07-18 18:11     ` Sam Ravnborg
2019-07-18 18:11       ` Sam Ravnborg
2019-07-18 18:30       ` Sean Paul
2019-07-18 18:30         ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 05/11] drm/vblank: drop use of DRM_WAIT_ON() Sam Ravnborg
2019-07-18 16:15   ` Sam Ravnborg
2019-07-18 17:50   ` Sean Paul
2019-07-18 17:50     ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 06/11] drm: direct include of drm.h in drm_gem.c Sam Ravnborg
2019-07-18 16:15   ` Sam Ravnborg
2019-07-18 17:51   ` Sean Paul
2019-07-18 17:51     ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 07/11] drm: direct include of drm.h in drm_gem_shmem_helper.c Sam Ravnborg
2019-07-18 16:15   ` Sam Ravnborg
2019-07-18 17:51   ` Sean Paul
2019-07-18 17:51     ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 08/11] drm: direct include of drm.h in drm_prime.c Sam Ravnborg
2019-07-18 16:15   ` Sam Ravnborg
2019-07-18 17:51   ` Sean Paul
2019-07-18 17:51     ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 09/11] drm: direct include of drm.h in drm_syncobj.c Sam Ravnborg
2019-07-18 16:15   ` Sam Ravnborg
2019-07-18 17:51   ` Sean Paul
2019-07-18 17:51     ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 10/11] drm/mediatek: direct include of drm.h in mtk_drm_gem.c Sam Ravnborg
2019-07-18 16:15   ` Sam Ravnborg
2019-07-18 17:52   ` Sean Paul
2019-07-18 17:52     ` Sean Paul
2019-07-19  1:30   ` CK Hu
2019-07-19  1:30     ` CK Hu
2019-07-19  1:34     ` CK Hu
2019-07-19  1:34       ` CK Hu
2019-07-18 16:15 ` [PATCH v1 11/11] drm: drop uapi dependency from drm_file.h Sam Ravnborg
2019-07-18 16:15   ` Sam Ravnborg
2019-07-18 18:40   ` Sean Paul
2019-07-18 18:40     ` Sean Paul
2019-07-19  6:56   ` Koenig, Christian
2019-07-19  6:56     ` Koenig, Christian
2019-07-19 11:08     ` Sam Ravnborg
2019-07-19 11:08       ` Sam Ravnborg
2019-07-18 16:37 ` ✗ Fi.CI.CHECKPATCH: warning for drm: header maintenance Patchwork
2019-07-18 16:57 ` ✓ Fi.CI.BAT: success " Patchwork
2019-07-18 19:11 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-07-19 21:26 ` [PATCH v1 0/11] " Sam Ravnborg
2019-07-19 21:26   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190718173634.GD31819@art_vandelay \
    --to=sean@poorly.run \
    --cc=Liviu.Dudau@arm.com \
    --cc=airlied@linux.ie \
    --cc=bbrezillon@kernel.org \
    --cc=boris.brezillon@bootlin.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=sam@ravnborg.org \
    --cc=treding@nvidia.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.