All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: "Koenig, Christian" <Christian.Koenig@amd.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
	Boris Brezillon <bbrezillon@kernel.org>,
	Jani Nikula <jani.nikula@intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Liviu Dudau <Liviu.Dudau@arm.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	David Airlie <airlied@linux.ie>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Sean Paul <seanpaul@chromium.org>,
	Thierry Reding <treding@nvidia.com>, Sean Paul <sean@poorly.run>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1 02/11] drm: drop uapi dependency from drm_print.h
Date: Mon, 29 Jul 2019 19:50:11 +0200	[thread overview]
Message-ID: <20190729175011.GA1753@ravnborg.org> (raw)
In-Reply-To: <67c2807f-582c-49a9-5699-a8baab3d3a0f@amd.com>

Hi Christian.

On Mon, Jul 29, 2019 at 03:28:15PM +0000, Koenig, Christian wrote:
> Am 29.07.19 um 16:35 schrieb Sam Ravnborg:
> >>>> Even then it so useless (which drm driver is this message for???) that I
> >>>> want to remove them all :(
> >>> Yeah, agree. I mean it is nice if the core drm functions use a prefix
> >>> for debug output.
> >>>
> >>> But I actually don't see the point for individual drivers.
> >> We should all migrate to the versions with device...
> > Just to do an xkdc.com/927 I have considered:
> >
> > drm_err(const struct drm_device *drm, ...)
> > drm_info(const struct drm_device *drm, ...)
> >
> > drm_kms_err(const struct drm_device *drm, ...)
> > drm_kms_info(const struct drm_device *drm, ...))
> 
> Why not get completely rid of those and just use dev_err, dev_warn, 
> pr_err, pr_warn etc?
> 
> I mean is it useful to have this extra printing subsystem in DRM while 
> the standard Linux one actually does a better job?
The added functionality of drm_xxx_err would be to keep the current
drm.debug=0x1f filtering on the command-line.
I do not think we can do this with the standard logging.

And then we can prefix every logging with driver name and device name.

The idea is to make a thin layer on top of the existing pr_xxx() functions.
So not a full subsystem, only a wrapper on top of what we already have.

Anyway, idle talk only. We need patches and sample output if we should
discuss more.

	Sam

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: "Koenig, Christian" <Christian.Koenig@amd.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
	Boris Brezillon <bbrezillon@kernel.org>,
	Jani Nikula <jani.nikula@intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Liviu Dudau <Liviu.Dudau@arm.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Chris Wilson <chris@chris-wilson.co.uk>,
	David Airlie <airlied@linux.ie>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Sean Paul <seanpaul@chromium.org>,
	Thierry Reding <treding@nvidia.com>, Sean Paul <sean@poorly.run>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1 02/11] drm: drop uapi dependency from drm_print.h
Date: Mon, 29 Jul 2019 19:50:11 +0200	[thread overview]
Message-ID: <20190729175011.GA1753@ravnborg.org> (raw)
In-Reply-To: <67c2807f-582c-49a9-5699-a8baab3d3a0f@amd.com>

Hi Christian.

On Mon, Jul 29, 2019 at 03:28:15PM +0000, Koenig, Christian wrote:
> Am 29.07.19 um 16:35 schrieb Sam Ravnborg:
> >>>> Even then it so useless (which drm driver is this message for???) that I
> >>>> want to remove them all :(
> >>> Yeah, agree. I mean it is nice if the core drm functions use a prefix
> >>> for debug output.
> >>>
> >>> But I actually don't see the point for individual drivers.
> >> We should all migrate to the versions with device...
> > Just to do an xkdc.com/927 I have considered:
> >
> > drm_err(const struct drm_device *drm, ...)
> > drm_info(const struct drm_device *drm, ...)
> >
> > drm_kms_err(const struct drm_device *drm, ...)
> > drm_kms_info(const struct drm_device *drm, ...))
> 
> Why not get completely rid of those and just use dev_err, dev_warn, 
> pr_err, pr_warn etc?
> 
> I mean is it useful to have this extra printing subsystem in DRM while 
> the standard Linux one actually does a better job?
The added functionality of drm_xxx_err would be to keep the current
drm.debug=0x1f filtering on the command-line.
I do not think we can do this with the standard logging.

And then we can prefix every logging with driver name and device name.

The idea is to make a thin layer on top of the existing pr_xxx() functions.
So not a full subsystem, only a wrapper on top of what we already have.

Anyway, idle talk only. We need patches and sample output if we should
discuss more.

	Sam


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-07-29 17:50 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-18 16:14 [PATCH v1 0/11] drm: header maintenance Sam Ravnborg
2019-07-18 16:14 ` Sam Ravnborg
2019-07-18 16:14 ` [PATCH v1 01/11] drm/panel: make drm_panel.h self-contained Sam Ravnborg
2019-07-18 16:14   ` Sam Ravnborg
2019-07-18 17:36   ` Sean Paul
2019-07-18 17:36     ` Sean Paul
2019-07-18 16:14 ` [PATCH v1 02/11] drm: drop uapi dependency from drm_print.h Sam Ravnborg
2019-07-18 16:14   ` Sam Ravnborg
2019-07-18 16:46   ` Chris Wilson
2019-07-18 16:46     ` Chris Wilson
2019-07-19  6:54     ` Koenig, Christian
2019-07-19  6:54       ` Koenig, Christian
2019-07-29 12:45       ` Jani Nikula
2019-07-29 12:45         ` Jani Nikula
2019-07-29 14:35         ` Sam Ravnborg
2019-07-29 14:35           ` Sam Ravnborg
2019-07-29 15:28           ` Koenig, Christian
2019-07-29 15:28             ` Koenig, Christian
2019-07-29 17:50             ` Sam Ravnborg [this message]
2019-07-29 17:50               ` Sam Ravnborg
2019-08-02 13:48               ` Jani Nikula
2019-08-02 13:48                 ` [Intel-gfx] " Jani Nikula
2019-08-02 15:28                 ` Sam Ravnborg
2019-08-02 15:28                   ` [Intel-gfx] " Sam Ravnborg
2019-07-18 17:40   ` Sean Paul
2019-07-18 17:40     ` Sean Paul
2019-07-18 16:14 ` [PATCH v1 03/11] drm: drop uapi dependency from drm_vblank.h Sam Ravnborg
2019-07-18 16:14   ` Sam Ravnborg
2019-07-18 17:41   ` Sean Paul
2019-07-18 17:41     ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 04/11] drm/ati_pcigart: drop dependency on drm_os_linux.h Sam Ravnborg
2019-07-18 16:15   ` Sam Ravnborg
2019-07-18 17:49   ` Sean Paul
2019-07-18 17:49     ` Sean Paul
2019-07-18 18:11     ` Sam Ravnborg
2019-07-18 18:11       ` Sam Ravnborg
2019-07-18 18:30       ` Sean Paul
2019-07-18 18:30         ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 05/11] drm/vblank: drop use of DRM_WAIT_ON() Sam Ravnborg
2019-07-18 16:15   ` Sam Ravnborg
2019-07-18 17:50   ` Sean Paul
2019-07-18 17:50     ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 06/11] drm: direct include of drm.h in drm_gem.c Sam Ravnborg
2019-07-18 16:15   ` Sam Ravnborg
2019-07-18 17:51   ` Sean Paul
2019-07-18 17:51     ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 07/11] drm: direct include of drm.h in drm_gem_shmem_helper.c Sam Ravnborg
2019-07-18 16:15   ` Sam Ravnborg
2019-07-18 17:51   ` Sean Paul
2019-07-18 17:51     ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 08/11] drm: direct include of drm.h in drm_prime.c Sam Ravnborg
2019-07-18 16:15   ` Sam Ravnborg
2019-07-18 17:51   ` Sean Paul
2019-07-18 17:51     ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 09/11] drm: direct include of drm.h in drm_syncobj.c Sam Ravnborg
2019-07-18 16:15   ` Sam Ravnborg
2019-07-18 17:51   ` Sean Paul
2019-07-18 17:51     ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 10/11] drm/mediatek: direct include of drm.h in mtk_drm_gem.c Sam Ravnborg
2019-07-18 16:15   ` Sam Ravnborg
2019-07-18 17:52   ` Sean Paul
2019-07-18 17:52     ` Sean Paul
2019-07-19  1:30   ` CK Hu
2019-07-19  1:30     ` CK Hu
2019-07-19  1:34     ` CK Hu
2019-07-19  1:34       ` CK Hu
2019-07-18 16:15 ` [PATCH v1 11/11] drm: drop uapi dependency from drm_file.h Sam Ravnborg
2019-07-18 16:15   ` Sam Ravnborg
2019-07-18 18:40   ` Sean Paul
2019-07-18 18:40     ` Sean Paul
2019-07-19  6:56   ` Koenig, Christian
2019-07-19  6:56     ` Koenig, Christian
2019-07-19 11:08     ` Sam Ravnborg
2019-07-19 11:08       ` Sam Ravnborg
2019-07-18 16:37 ` ✗ Fi.CI.CHECKPATCH: warning for drm: header maintenance Patchwork
2019-07-18 16:57 ` ✓ Fi.CI.BAT: success " Patchwork
2019-07-18 19:11 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-07-19 21:26 ` [PATCH v1 0/11] " Sam Ravnborg
2019-07-19 21:26   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190729175011.GA1753@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=Christian.Koenig@amd.com \
    --cc=Liviu.Dudau@arm.com \
    --cc=airlied@linux.ie \
    --cc=bbrezillon@kernel.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=sean@poorly.run \
    --cc=seanpaul@chromium.org \
    --cc=treding@nvidia.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.