All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Sagar Kadam <sagar.kadam@sifive.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Albert Ou <aou@eecs.berkeley.edu>,
	netdev@vger.kernel.org, Palmer Dabbelt <palmer@sifive.com>,
	ynezz@true.cz,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	nicolas.ferre@microchip.com,
	Sachin Ghadi <sachin.ghadi@sifive.com>,
	Yash Shah <yash.shah@sifive.com>,
	Rob Herring <robh+dt@kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	linux-riscv@lists.infradead.org, davem@davemloft.net
Subject: Re: [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver
Date: Fri, 19 Jul 2019 15:26:57 +0200	[thread overview]
Message-ID: <20190719132657.GD24930@lunn.ch> (raw)
In-Reply-To: <CAARK3H=D1N8gO0Z82_MCtgr5DtT1=E0wzYbn-y451ASgxV-qBg@mail.gmail.com>

On Fri, Jul 19, 2019 at 05:23:45PM +0530, Sagar Kadam wrote:
> > +&eth0 {
> > +       status = "okay";
> > +       phy-mode = "gmii";
> > +       phy-handle = <&phy1>;
> > +       phy1: ethernet-phy@0 {
> > +               reg = <0>;
> > +       };

Hi Sagar

Is there a good reason to call it phy1? Is there a phy0?

Thanks

   Andrew

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Sagar Kadam <sagar.kadam@sifive.com>
Cc: Yash Shah <yash.shah@sifive.com>,
	davem@davemloft.net, Rob Herring <robh+dt@kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-riscv@lists.infradead.org,
	Mark Rutland <mark.rutland@arm.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Palmer Dabbelt <palmer@sifive.com>,
	nicolas.ferre@microchip.com,
	Sachin Ghadi <sachin.ghadi@sifive.com>,
	ynezz@true.cz
Subject: Re: [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver
Date: Fri, 19 Jul 2019 15:26:57 +0200	[thread overview]
Message-ID: <20190719132657.GD24930@lunn.ch> (raw)
In-Reply-To: <CAARK3H=D1N8gO0Z82_MCtgr5DtT1=E0wzYbn-y451ASgxV-qBg@mail.gmail.com>

On Fri, Jul 19, 2019 at 05:23:45PM +0530, Sagar Kadam wrote:
> > +&eth0 {
> > +       status = "okay";
> > +       phy-mode = "gmii";
> > +       phy-handle = <&phy1>;
> > +       phy1: ethernet-phy@0 {
> > +               reg = <0>;
> > +       };

Hi Sagar

Is there a good reason to call it phy1? Is there a phy0?

Thanks

   Andrew

  reply	other threads:[~2019-07-19 13:27 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-19 11:10 [PATCH 1/3] macb: bindings doc: update sifive fu540-c000 binding Yash Shah
2019-07-19 11:10 ` Yash Shah
2019-07-19 11:10 ` [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000 Yash Shah
2019-07-19 11:10   ` Yash Shah
2019-07-19 12:05   ` Nicolas.Ferre
2019-07-19 12:05     ` Nicolas.Ferre
2019-07-19 12:05     ` Nicolas.Ferre
2019-07-22  4:39     ` Yash Shah
2019-07-22  4:39       ` Yash Shah
2019-08-13 18:42       ` Paul Walmsley
2019-08-13 18:42         ` Paul Walmsley
2019-08-20  9:10         ` Andreas Schwab
2019-08-20  9:10           ` Andreas Schwab
2019-08-20 10:16           ` Nicolas.Ferre
2019-08-20 10:16             ` Nicolas.Ferre
2019-08-20 10:16             ` Nicolas.Ferre
2019-07-22 20:02   ` Paul Walmsley
2019-07-22 20:02     ` Paul Walmsley
2019-07-22 21:46   ` Paul Walmsley
2019-07-22 21:46     ` Paul Walmsley
2019-07-19 11:10 ` [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver Yash Shah
2019-07-19 11:10   ` Yash Shah
2019-07-19 11:53   ` Sagar Kadam
2019-07-19 11:53     ` Sagar Kadam
2019-07-19 13:26     ` Andrew Lunn [this message]
2019-07-19 13:26       ` Andrew Lunn
2019-07-22  8:27       ` Sagar Kadam
2019-07-22  8:27         ` Sagar Kadam
2019-07-22 21:48   ` Paul Walmsley
2019-07-22 21:48     ` Paul Walmsley
2019-08-12 23:33     ` Rob Herring
2019-08-12 23:33       ` Rob Herring
2019-07-19 12:02 ` [PATCH 1/3] macb: bindings doc: update sifive fu540-c000 binding Nicolas.Ferre
2019-07-19 12:02   ` Nicolas.Ferre
2019-07-19 12:02   ` Nicolas.Ferre
2019-07-22 19:59 ` Paul Walmsley
2019-07-22 19:59   ` Paul Walmsley
2019-08-12 23:32 ` Rob Herring
2019-08-12 23:32   ` Rob Herring
2019-08-12 23:32   ` Rob Herring
2019-08-13 18:41   ` Paul Walmsley
2019-08-13 18:41     ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190719132657.GD24930@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=aou@eecs.berkeley.edu \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=palmer@sifive.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh+dt@kernel.org \
    --cc=sachin.ghadi@sifive.com \
    --cc=sagar.kadam@sifive.com \
    --cc=yash.shah@sifive.com \
    --cc=ynezz@true.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.