From: Segher Boessenkool <segher@kernel.crashing.org>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2] powerpc: slightly improve cache helpers
Date: Fri, 19 Jul 2019 10:23:03 -0500 [thread overview]
Message-ID: <20190719152303.GA20882@gate.crashing.org> (raw)
In-Reply-To: <20190719032456.GA14108@archlinux-threadripper>
On Thu, Jul 18, 2019 at 08:24:56PM -0700, Nathan Chancellor wrote:
> On Mon, Jul 08, 2019 at 11:49:52PM -0700, Nathan Chancellor wrote:
> > On Tue, Jul 09, 2019 at 07:04:43AM +0200, Christophe Leroy wrote:
> > > Is that a Clang bug ?
> >
> > No idea, it happens with clang-8 and clang-9 though (pretty sure there
> > were fixes for PowerPC in clang-8 so something before it probably won't
> > work but I haven't tried).
> >
> > >
> > > Do you have a disassembly of the code both with and without this patch in
> > > order to compare ?
> >
> > I can give you whatever disassembly you want (or I can upload the raw
> > files if that is easier).
>
> What disassembly/files did you need to start taking a look at this? I
> can upload/send whatever you need.
A before and after of *only this patch*. And then look at what changed;
it maybe be obvious what is the problem to you, as well, so look at it
yourself first?
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Christophe Leroy <christophe.leroy@c-s.fr>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH v2] powerpc: slightly improve cache helpers
Date: Fri, 19 Jul 2019 10:23:03 -0500 [thread overview]
Message-ID: <20190719152303.GA20882@gate.crashing.org> (raw)
In-Reply-To: <20190719032456.GA14108@archlinux-threadripper>
On Thu, Jul 18, 2019 at 08:24:56PM -0700, Nathan Chancellor wrote:
> On Mon, Jul 08, 2019 at 11:49:52PM -0700, Nathan Chancellor wrote:
> > On Tue, Jul 09, 2019 at 07:04:43AM +0200, Christophe Leroy wrote:
> > > Is that a Clang bug ?
> >
> > No idea, it happens with clang-8 and clang-9 though (pretty sure there
> > were fixes for PowerPC in clang-8 so something before it probably won't
> > work but I haven't tried).
> >
> > >
> > > Do you have a disassembly of the code both with and without this patch in
> > > order to compare ?
> >
> > I can give you whatever disassembly you want (or I can upload the raw
> > files if that is easier).
>
> What disassembly/files did you need to start taking a look at this? I
> can upload/send whatever you need.
A before and after of *only this patch*. And then look at what changed;
it maybe be obvious what is the problem to you, as well, so look at it
yourself first?
Segher
next prev parent reply other threads:[~2019-07-19 15:25 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 9:24 [PATCH v2] powerpc: slightly improve cache helpers Christophe Leroy
2019-05-10 9:24 ` Christophe Leroy
2019-07-08 1:19 ` Michael Ellerman
2019-07-08 19:14 ` Nathan Chancellor
2019-07-08 19:14 ` Nathan Chancellor
2019-07-09 5:04 ` Christophe Leroy
2019-07-09 5:04 ` Christophe Leroy
2019-07-09 6:49 ` Nathan Chancellor
2019-07-09 6:49 ` Nathan Chancellor
2019-07-19 3:24 ` Nathan Chancellor
2019-07-19 3:24 ` Nathan Chancellor
2019-07-19 15:23 ` Segher Boessenkool [this message]
2019-07-19 15:23 ` Segher Boessenkool
2019-07-19 16:04 ` Nathan Chancellor
2019-07-19 16:04 ` Nathan Chancellor
2019-07-21 7:58 ` Nathan Chancellor
2019-07-21 7:58 ` Nathan Chancellor
2019-07-21 18:01 ` Segher Boessenkool
2019-07-21 18:01 ` Segher Boessenkool
2019-07-22 2:41 ` Nathan Chancellor
2019-07-22 2:41 ` Nathan Chancellor
2019-07-22 6:19 ` Segher Boessenkool
2019-07-22 6:19 ` Segher Boessenkool
2019-07-22 17:21 ` Nick Desaulniers
2019-07-22 17:21 ` Nick Desaulniers
2019-07-22 17:58 ` Segher Boessenkool
2019-07-22 17:58 ` Segher Boessenkool
2019-07-25 21:30 ` Nick Desaulniers
2019-07-25 21:30 ` Nick Desaulniers
2019-07-29 20:28 ` Nick Desaulniers
2019-07-29 20:28 ` Nick Desaulniers
2019-07-22 10:15 ` Michael Ellerman
2019-07-22 10:15 ` Michael Ellerman
2019-07-22 15:18 ` Segher Boessenkool
2019-07-22 15:18 ` Segher Boessenkool
2019-07-22 23:21 ` Michael Ellerman
2019-07-22 23:21 ` Michael Ellerman
2019-07-25 13:22 ` Segher Boessenkool
2019-07-25 13:22 ` Segher Boessenkool
2019-07-22 0:53 ` [PATCH] powerpc: Test broken dcbz kbuild test robot
2019-07-22 0:53 ` kbuild test robot
2019-07-09 13:35 ` [PATCH v2] powerpc: slightly improve cache helpers Segher Boessenkool
2019-07-09 13:35 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719152303.GA20882@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=natechancellor@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.