From: Shawn Guo <shawnguo@kernel.org>
To: jun.li@nxp.com
Cc: sboyd@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com, mturquette@baylibre.com,
Peter.Chen@nxp.com, ping.bai@nxp.com, leonard.crestez@nxp.com,
daniel.baluta@nxp.com, Anson.Huang@nxp.com, aisheng.dong@nxp.com,
peng.fan@nxp.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 3/5] clk: imx8mm: correct the usb1_ctrl parent to be usb_bus
Date: Mon, 22 Jul 2019 11:34:20 +0800 [thread overview]
Message-ID: <20190722033418.GX3738@dragon> (raw)
In-Reply-To: <20190703072327.38165-1-jun.li@nxp.com>
On Wed, Jul 03, 2019 at 03:23:25PM +0800, jun.li@nxp.com wrote:
> From: Li Jun <jun.li@nxp.com>
>
> Per latest imx8mm datasheet of CCM, the parent of usb1_ctrl_root_clk
> should be usb_bus.
>
> Signed-off-by: Li Jun <jun.li@nxp.com>
I only received 3 patches as a series. In that case, the patches should
have subject prefix like '[PATCH 1/3]' ...
The patches look good to me. Applied all 3, thanks.
Shawn
> ---
> drivers/clk/imx/clk-imx8mm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
> index 6b8e75d..735cf9d 100644
> --- a/drivers/clk/imx/clk-imx8mm.c
> +++ b/drivers/clk/imx/clk-imx8mm.c
> @@ -631,7 +631,7 @@ static int __init imx8mm_clocks_init(struct device_node *ccm_node)
> clks[IMX8MM_CLK_UART2_ROOT] = imx_clk_gate4("uart2_root_clk", "uart2", base + 0x44a0, 0);
> clks[IMX8MM_CLK_UART3_ROOT] = imx_clk_gate4("uart3_root_clk", "uart3", base + 0x44b0, 0);
> clks[IMX8MM_CLK_UART4_ROOT] = imx_clk_gate4("uart4_root_clk", "uart4", base + 0x44c0, 0);
> - clks[IMX8MM_CLK_USB1_CTRL_ROOT] = imx_clk_gate4("usb1_ctrl_root_clk", "usb_core_ref", base + 0x44d0, 0);
> + clks[IMX8MM_CLK_USB1_CTRL_ROOT] = imx_clk_gate4("usb1_ctrl_root_clk", "usb_bus", base + 0x44d0, 0);
> clks[IMX8MM_CLK_GPU3D_ROOT] = imx_clk_gate4("gpu3d_root_clk", "gpu3d_div", base + 0x44f0, 0);
> clks[IMX8MM_CLK_USDHC1_ROOT] = imx_clk_gate4("usdhc1_root_clk", "usdhc1", base + 0x4510, 0);
> clks[IMX8MM_CLK_USDHC2_ROOT] = imx_clk_gate4("usdhc2_root_clk", "usdhc2", base + 0x4520, 0);
> --
> 2.7.4
>
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: jun.li@nxp.com
Cc: mark.rutland@arm.com, Peter.Chen@nxp.com, peng.fan@nxp.com,
ping.bai@nxp.com, Anson.Huang@nxp.com,
devicetree@vger.kernel.org, sboyd@kernel.org,
daniel.baluta@nxp.com, s.hauer@pengutronix.de,
linux-clk@vger.kernel.org, robh+dt@kernel.org, linux-imx@nxp.com,
kernel@pengutronix.de, aisheng.dong@nxp.com,
leonard.crestez@nxp.com, festevam@gmail.com,
mturquette@baylibre.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/5] clk: imx8mm: correct the usb1_ctrl parent to be usb_bus
Date: Mon, 22 Jul 2019 11:34:20 +0800 [thread overview]
Message-ID: <20190722033418.GX3738@dragon> (raw)
In-Reply-To: <20190703072327.38165-1-jun.li@nxp.com>
On Wed, Jul 03, 2019 at 03:23:25PM +0800, jun.li@nxp.com wrote:
> From: Li Jun <jun.li@nxp.com>
>
> Per latest imx8mm datasheet of CCM, the parent of usb1_ctrl_root_clk
> should be usb_bus.
>
> Signed-off-by: Li Jun <jun.li@nxp.com>
I only received 3 patches as a series. In that case, the patches should
have subject prefix like '[PATCH 1/3]' ...
The patches look good to me. Applied all 3, thanks.
Shawn
> ---
> drivers/clk/imx/clk-imx8mm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
> index 6b8e75d..735cf9d 100644
> --- a/drivers/clk/imx/clk-imx8mm.c
> +++ b/drivers/clk/imx/clk-imx8mm.c
> @@ -631,7 +631,7 @@ static int __init imx8mm_clocks_init(struct device_node *ccm_node)
> clks[IMX8MM_CLK_UART2_ROOT] = imx_clk_gate4("uart2_root_clk", "uart2", base + 0x44a0, 0);
> clks[IMX8MM_CLK_UART3_ROOT] = imx_clk_gate4("uart3_root_clk", "uart3", base + 0x44b0, 0);
> clks[IMX8MM_CLK_UART4_ROOT] = imx_clk_gate4("uart4_root_clk", "uart4", base + 0x44c0, 0);
> - clks[IMX8MM_CLK_USB1_CTRL_ROOT] = imx_clk_gate4("usb1_ctrl_root_clk", "usb_core_ref", base + 0x44d0, 0);
> + clks[IMX8MM_CLK_USB1_CTRL_ROOT] = imx_clk_gate4("usb1_ctrl_root_clk", "usb_bus", base + 0x44d0, 0);
> clks[IMX8MM_CLK_GPU3D_ROOT] = imx_clk_gate4("gpu3d_root_clk", "gpu3d_div", base + 0x44f0, 0);
> clks[IMX8MM_CLK_USDHC1_ROOT] = imx_clk_gate4("usdhc1_root_clk", "usdhc1", base + 0x4510, 0);
> clks[IMX8MM_CLK_USDHC2_ROOT] = imx_clk_gate4("usdhc2_root_clk", "usdhc2", base + 0x4520, 0);
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: jun.li@nxp.com
Cc: mark.rutland@arm.com, Peter.Chen@nxp.com, peng.fan@nxp.com,
ping.bai@nxp.com, Anson.Huang@nxp.com,
devicetree@vger.kernel.org, sboyd@kernel.org,
daniel.baluta@nxp.com, s.hauer@pengutronix.de,
linux-clk@vger.kernel.org, robh+dt@kernel.org, linux-imx@nxp.com,
kernel@pengutronix.de, aisheng.dong@nxp.com,
leonard.crestez@nxp.com, festevam@gmail.com,
mturquette@baylibre.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/5] clk: imx8mm: correct the usb1_ctrl parent to be usb_bus
Date: Mon, 22 Jul 2019 11:34:20 +0800 [thread overview]
Message-ID: <20190722033418.GX3738@dragon> (raw)
In-Reply-To: <20190703072327.38165-1-jun.li@nxp.com>
On Wed, Jul 03, 2019 at 03:23:25PM +0800, jun.li@nxp.com wrote:
> From: Li Jun <jun.li@nxp.com>
>
> Per latest imx8mm datasheet of CCM, the parent of usb1_ctrl_root_clk
> should be usb_bus.
>
> Signed-off-by: Li Jun <jun.li@nxp.com>
I only received 3 patches as a series. In that case, the patches should
have subject prefix like '[PATCH 1/3]' ...
The patches look good to me. Applied all 3, thanks.
Shawn
> ---
> drivers/clk/imx/clk-imx8mm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
> index 6b8e75d..735cf9d 100644
> --- a/drivers/clk/imx/clk-imx8mm.c
> +++ b/drivers/clk/imx/clk-imx8mm.c
> @@ -631,7 +631,7 @@ static int __init imx8mm_clocks_init(struct device_node *ccm_node)
> clks[IMX8MM_CLK_UART2_ROOT] = imx_clk_gate4("uart2_root_clk", "uart2", base + 0x44a0, 0);
> clks[IMX8MM_CLK_UART3_ROOT] = imx_clk_gate4("uart3_root_clk", "uart3", base + 0x44b0, 0);
> clks[IMX8MM_CLK_UART4_ROOT] = imx_clk_gate4("uart4_root_clk", "uart4", base + 0x44c0, 0);
> - clks[IMX8MM_CLK_USB1_CTRL_ROOT] = imx_clk_gate4("usb1_ctrl_root_clk", "usb_core_ref", base + 0x44d0, 0);
> + clks[IMX8MM_CLK_USB1_CTRL_ROOT] = imx_clk_gate4("usb1_ctrl_root_clk", "usb_bus", base + 0x44d0, 0);
> clks[IMX8MM_CLK_GPU3D_ROOT] = imx_clk_gate4("gpu3d_root_clk", "gpu3d_div", base + 0x44f0, 0);
> clks[IMX8MM_CLK_USDHC1_ROOT] = imx_clk_gate4("usdhc1_root_clk", "usdhc1", base + 0x4510, 0);
> clks[IMX8MM_CLK_USDHC2_ROOT] = imx_clk_gate4("usdhc2_root_clk", "usdhc2", base + 0x4520, 0);
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-07-22 3:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 7:23 [PATCH 3/5] clk: imx8mm: correct the usb1_ctrl parent to be usb_bus jun.li
2019-07-03 7:23 ` jun.li
2019-07-03 7:23 ` jun.li
2019-07-03 7:23 ` [PATCH 4/5] arm64: dts: imx8mm: Remove setting for IMX8MM_CLK_USB_CORE_REF jun.li
2019-07-03 7:23 ` jun.li
2019-07-03 7:23 ` jun.li
2019-07-03 7:23 ` [PATCH 5/5] arm64: dts: imx8mm-evk: enable usb1 and typec support jun.li
2019-07-03 7:23 ` jun.li
2019-07-03 7:23 ` jun.li
2019-07-22 3:34 ` Shawn Guo [this message]
2019-07-22 3:34 ` [PATCH 3/5] clk: imx8mm: correct the usb1_ctrl parent to be usb_bus Shawn Guo
2019-07-22 3:34 ` Shawn Guo
2019-07-24 11:09 ` Jun Li
2019-07-24 11:09 ` Jun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722033418.GX3738@dragon \
--to=shawnguo@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=Peter.Chen@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=ping.bai@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.