From: Christoph Hellwig <hch@lst.de>
To: Hugh Dickins <hughd@google.com>
Cc: dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
David Howells <dhowells@redhat.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCHv2 2/3] i915: convert to new mount API
Date: Wed, 7 Aug 2019 08:30:02 +0200 [thread overview]
Message-ID: <20190807063002.GG6627@lst.de> (raw)
In-Reply-To: <alpine.LSU.2.11.1908060007190.1941@eggly.anvils>
On Tue, Aug 06, 2019 at 12:50:10AM -0700, Hugh Dickins wrote:
> Though personally I'm averse to managing "f"objects through
> "m"interfaces, which can get ridiculous (notably, MADV_HUGEPAGE works
> on the virtual address of a mapping, but the huge-or-not alignment of
> that mapping must have been decided previously). In Google we do use
> fcntls F_HUGEPAGE and F_NOHUGEPAGE to override on a per-file basis -
> one day I'll get to upstreaming those.
Such an interface seems very useful, although the two fcntls seem a bit
odd.
But I think the point here is that the i915 has its own somewhat odd
instance of tmpfs. If we could pass the equivalent of the huge=*
options to shmem_file_setup all that garbage (including the
shmem_file_setup_with_mnt function) could go away.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Hugh Dickins <hughd@google.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
David Howells <dhowells@redhat.com>,
Christoph Hellwig <hch@lst.de>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCHv2 2/3] i915: convert to new mount API
Date: Wed, 7 Aug 2019 08:30:02 +0200 [thread overview]
Message-ID: <20190807063002.GG6627@lst.de> (raw)
In-Reply-To: <alpine.LSU.2.11.1908060007190.1941@eggly.anvils>
On Tue, Aug 06, 2019 at 12:50:10AM -0700, Hugh Dickins wrote:
> Though personally I'm averse to managing "f"objects through
> "m"interfaces, which can get ridiculous (notably, MADV_HUGEPAGE works
> on the virtual address of a mapping, but the huge-or-not alignment of
> that mapping must have been decided previously). In Google we do use
> fcntls F_HUGEPAGE and F_NOHUGEPAGE to override on a per-file basis -
> one day I'll get to upstreaming those.
Such an interface seems very useful, although the two fcntls seem a bit
odd.
But I think the point here is that the i915 has its own somewhat odd
instance of tmpfs. If we could pass the equivalent of the huge=*
options to shmem_file_setup all that garbage (including the
shmem_file_setup_with_mnt function) could go away.
next prev parent reply other threads:[~2019-08-07 6:30 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 16:03 [PATCHv2 0/3] convert i915 to new mount API Sergey Senozhatsky
2019-08-05 16:03 ` Sergey Senozhatsky
2019-08-05 16:03 ` [PATCHv2 1/3] fs: export put_filesystem() Sergey Senozhatsky
2019-08-05 16:03 ` [PATCHv2 2/3] i915: convert to new mount API Sergey Senozhatsky
2019-08-05 16:03 ` Sergey Senozhatsky
2019-08-05 18:12 ` Al Viro
2019-08-05 18:28 ` Al Viro
2019-08-06 7:50 ` Hugh Dickins
2019-08-07 6:30 ` Christoph Hellwig [this message]
2019-08-07 6:30 ` Christoph Hellwig
2019-08-08 1:23 ` Al Viro
2019-08-08 1:23 ` Al Viro
2019-08-08 15:54 ` Hugh Dickins
2019-08-08 15:54 ` Hugh Dickins
2019-08-08 16:23 ` Chris Wilson
2019-08-08 16:23 ` Chris Wilson
2019-08-08 17:03 ` Matthew Auld
2019-08-08 1:21 ` Al Viro
2019-08-08 1:21 ` Al Viro
2019-08-05 23:33 ` Al Viro
2019-08-06 1:20 ` Sergey Senozhatsky
2019-08-05 16:03 ` [PATCHv2 3/3] i915: do not leak module ref counter Sergey Senozhatsky
2019-08-05 16:36 ` ✗ Fi.CI.CHECKPATCH: warning for convert i915 to new mount API Patchwork
2019-08-05 16:57 ` ✓ Fi.CI.BAT: success " Patchwork
2019-08-05 19:34 ` [PATCHv2 0/3] " Sedat Dilek
2019-08-05 21:25 ` ✓ Fi.CI.IGT: success for " Patchwork
2019-08-08 17:47 ` ✗ Fi.CI.CHECKPATCH: warning for convert i915 to new mount API (rev2) Patchwork
2019-08-08 18:17 ` ✓ Fi.CI.BAT: success " Patchwork
2019-08-09 5:18 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807063002.GG6627@lst.de \
--to=hch@lst.de \
--cc=airlied@linux.ie \
--cc=dhowells@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hughd@google.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.