* Regression in next with codec unload and snd_soc_component_get/put
@ 2019-08-09 7:00 ` Tony Lindgren
0 siblings, 0 replies; 14+ messages in thread
From: Tony Lindgren @ 2019-08-09 7:00 UTC (permalink / raw)
To: Kuninori Morimoto, Mark Brown
Cc: alsa-devel, linux-kernel, linux-arm-kernel, linux-omap
Hi,
Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add
snd_soc_component_get/put()") causes a regression where trying
to rmmod a codec driver fails with module is in use error after
rmmod of snd-soc-audio-graph-card for example.
Any ideas what goes wrong there?
BTW, looks like the lore.kernel.org link in that commit also is
unreachable?
Regards,
Tony
^ permalink raw reply [flat|nested] 14+ messages in thread* Regression in next with codec unload and snd_soc_component_get/put
@ 2019-08-09 7:00 ` Tony Lindgren
0 siblings, 0 replies; 14+ messages in thread
From: Tony Lindgren @ 2019-08-09 7:00 UTC (permalink / raw)
To: Kuninori Morimoto, Mark Brown
Cc: alsa-devel, linux-omap, linux-kernel, linux-arm-kernel
Hi,
Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add
snd_soc_component_get/put()") causes a regression where trying
to rmmod a codec driver fails with module is in use error after
rmmod of snd-soc-audio-graph-card for example.
Any ideas what goes wrong there?
BTW, looks like the lore.kernel.org link in that commit also is
unreachable?
Regards,
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [alsa-devel] Regression in next with codec unload and snd_soc_component_get/put
2019-08-09 7:00 ` Tony Lindgren
@ 2019-08-09 7:25 ` Takashi Iwai
-1 siblings, 0 replies; 14+ messages in thread
From: Takashi Iwai @ 2019-08-09 7:25 UTC (permalink / raw)
To: Tony Lindgren
Cc: Kuninori Morimoto, Mark Brown, Jaroslav Kysela, alsa-devel,
linux-omap, linux-kernel, linux-arm-kernel
On Fri, 09 Aug 2019 09:00:03 +0200,
Tony Lindgren wrote:
>
> Hi,
>
> Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add
> snd_soc_component_get/put()") causes a regression where trying
> to rmmod a codec driver fails with module is in use error after
> rmmod of snd-soc-audio-graph-card for example.
>
> Any ideas what goes wrong there?
There is an obvious typo: soc_cleanup_component() should call
snd_soc_component_module_put_when_remove() instead of *_close().
And the module_get_upon_open boolean switch is a bit hard to
understand. Maybe using enum would be simpler there.
> BTW, looks like the lore.kernel.org link in that commit also is
> unreachable?
It's because alsa-devel ML isn't tracked on lore.kernel.org,
unfortunately.
Jaroslav, I asked this already. Shall we ask lore to track alsa-devel
ML?
https://korg.wiki.kernel.org/userdoc/lore
thanks,
Takashi
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [alsa-devel] Regression in next with codec unload and snd_soc_component_get/put
@ 2019-08-09 7:25 ` Takashi Iwai
0 siblings, 0 replies; 14+ messages in thread
From: Takashi Iwai @ 2019-08-09 7:25 UTC (permalink / raw)
To: Tony Lindgren
Cc: alsa-devel, Kuninori Morimoto, linux-kernel, Jaroslav Kysela,
Mark Brown, linux-omap, linux-arm-kernel
On Fri, 09 Aug 2019 09:00:03 +0200,
Tony Lindgren wrote:
>
> Hi,
>
> Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add
> snd_soc_component_get/put()") causes a regression where trying
> to rmmod a codec driver fails with module is in use error after
> rmmod of snd-soc-audio-graph-card for example.
>
> Any ideas what goes wrong there?
There is an obvious typo: soc_cleanup_component() should call
snd_soc_component_module_put_when_remove() instead of *_close().
And the module_get_upon_open boolean switch is a bit hard to
understand. Maybe using enum would be simpler there.
> BTW, looks like the lore.kernel.org link in that commit also is
> unreachable?
It's because alsa-devel ML isn't tracked on lore.kernel.org,
unfortunately.
Jaroslav, I asked this already. Shall we ask lore to track alsa-devel
ML?
https://korg.wiki.kernel.org/userdoc/lore
thanks,
Takashi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [alsa-devel] Regression in next with codec unload and snd_soc_component_get/put
2019-08-09 7:25 ` Takashi Iwai
@ 2019-08-09 7:46 ` Tony Lindgren
-1 siblings, 0 replies; 14+ messages in thread
From: Tony Lindgren @ 2019-08-09 7:46 UTC (permalink / raw)
To: Takashi Iwai
Cc: Kuninori Morimoto, Mark Brown, Jaroslav Kysela, alsa-devel,
linux-omap, linux-kernel, linux-arm-kernel
* Takashi Iwai <tiwai@suse.de> [190809 07:25]:
> On Fri, 09 Aug 2019 09:00:03 +0200,
> Tony Lindgren wrote:
> >
> > Hi,
> >
> > Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add
> > snd_soc_component_get/put()") causes a regression where trying
> > to rmmod a codec driver fails with module is in use error after
> > rmmod of snd-soc-audio-graph-card for example.
> >
> > Any ideas what goes wrong there?
>
> There is an obvious typo: soc_cleanup_component() should call
> snd_soc_component_module_put_when_remove() instead of *_close().
Making that change locally seems to fix it thanks.
> And the module_get_upon_open boolean switch is a bit hard to
> understand. Maybe using enum would be simpler there.
>
> > BTW, looks like the lore.kernel.org link in that commit also is
> > unreachable?
>
> It's because alsa-devel ML isn't tracked on lore.kernel.org,
> unfortunately.
>
> Jaroslav, I asked this already. Shall we ask lore to track alsa-devel
> ML?
> https://korg.wiki.kernel.org/userdoc/lore
Regards,
Tony
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [alsa-devel] Regression in next with codec unload and snd_soc_component_get/put
@ 2019-08-09 7:46 ` Tony Lindgren
0 siblings, 0 replies; 14+ messages in thread
From: Tony Lindgren @ 2019-08-09 7:46 UTC (permalink / raw)
To: Takashi Iwai
Cc: alsa-devel, Kuninori Morimoto, linux-kernel, Jaroslav Kysela,
Mark Brown, linux-omap, linux-arm-kernel
* Takashi Iwai <tiwai@suse.de> [190809 07:25]:
> On Fri, 09 Aug 2019 09:00:03 +0200,
> Tony Lindgren wrote:
> >
> > Hi,
> >
> > Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add
> > snd_soc_component_get/put()") causes a regression where trying
> > to rmmod a codec driver fails with module is in use error after
> > rmmod of snd-soc-audio-graph-card for example.
> >
> > Any ideas what goes wrong there?
>
> There is an obvious typo: soc_cleanup_component() should call
> snd_soc_component_module_put_when_remove() instead of *_close().
Making that change locally seems to fix it thanks.
> And the module_get_upon_open boolean switch is a bit hard to
> understand. Maybe using enum would be simpler there.
>
> > BTW, looks like the lore.kernel.org link in that commit also is
> > unreachable?
>
> It's because alsa-devel ML isn't tracked on lore.kernel.org,
> unfortunately.
>
> Jaroslav, I asked this already. Shall we ask lore to track alsa-devel
> ML?
> https://korg.wiki.kernel.org/userdoc/lore
Regards,
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [alsa-devel] Regression in next with codec unload and snd_soc_component_get/put
2019-08-09 7:46 ` Tony Lindgren
@ 2019-08-09 8:23 ` Takashi Iwai
-1 siblings, 0 replies; 14+ messages in thread
From: Takashi Iwai @ 2019-08-09 8:23 UTC (permalink / raw)
To: Tony Lindgren
Cc: Kuninori Morimoto, Mark Brown, Jaroslav Kysela, alsa-devel,
linux-omap, linux-kernel, linux-arm-kernel
On Fri, 09 Aug 2019 09:46:43 +0200,
Tony Lindgren wrote:
>
> * Takashi Iwai <tiwai@suse.de> [190809 07:25]:
> > On Fri, 09 Aug 2019 09:00:03 +0200,
> > Tony Lindgren wrote:
> > >
> > > Hi,
> > >
> > > Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add
> > > snd_soc_component_get/put()") causes a regression where trying
> > > to rmmod a codec driver fails with module is in use error after
> > > rmmod of snd-soc-audio-graph-card for example.
> > >
> > > Any ideas what goes wrong there?
> >
> > There is an obvious typo: soc_cleanup_component() should call
> > snd_soc_component_module_put_when_remove() instead of *_close().
>
> Making that change locally seems to fix it thanks.
... and it was already fixed in the later commit 0e36f36b04e7
"ASoC: soc-core: fix module_put() warning in soc_cleanup_component".
Takashi
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [alsa-devel] Regression in next with codec unload and snd_soc_component_get/put
@ 2019-08-09 8:23 ` Takashi Iwai
0 siblings, 0 replies; 14+ messages in thread
From: Takashi Iwai @ 2019-08-09 8:23 UTC (permalink / raw)
To: Tony Lindgren
Cc: alsa-devel, Kuninori Morimoto, linux-kernel, Jaroslav Kysela,
Mark Brown, linux-omap, linux-arm-kernel
On Fri, 09 Aug 2019 09:46:43 +0200,
Tony Lindgren wrote:
>
> * Takashi Iwai <tiwai@suse.de> [190809 07:25]:
> > On Fri, 09 Aug 2019 09:00:03 +0200,
> > Tony Lindgren wrote:
> > >
> > > Hi,
> > >
> > > Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add
> > > snd_soc_component_get/put()") causes a regression where trying
> > > to rmmod a codec driver fails with module is in use error after
> > > rmmod of snd-soc-audio-graph-card for example.
> > >
> > > Any ideas what goes wrong there?
> >
> > There is an obvious typo: soc_cleanup_component() should call
> > snd_soc_component_module_put_when_remove() instead of *_close().
>
> Making that change locally seems to fix it thanks.
... and it was already fixed in the later commit 0e36f36b04e7
"ASoC: soc-core: fix module_put() warning in soc_cleanup_component".
Takashi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [alsa-devel] Regression in next with codec unload and snd_soc_component_get/put
2019-08-09 8:23 ` Takashi Iwai
@ 2019-08-13 10:24 ` Tony Lindgren
-1 siblings, 0 replies; 14+ messages in thread
From: Tony Lindgren @ 2019-08-13 10:24 UTC (permalink / raw)
To: Takashi Iwai
Cc: Kuninori Morimoto, Mark Brown, Jaroslav Kysela, alsa-devel,
linux-omap, linux-kernel, linux-arm-kernel
* Takashi Iwai <tiwai@suse.de> [190809 08:24]:
> On Fri, 09 Aug 2019 09:46:43 +0200,
> Tony Lindgren wrote:
> >
> > * Takashi Iwai <tiwai@suse.de> [190809 07:25]:
> > > On Fri, 09 Aug 2019 09:00:03 +0200,
> > > Tony Lindgren wrote:
> > > >
> > > > Hi,
> > > >
> > > > Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add
> > > > snd_soc_component_get/put()") causes a regression where trying
> > > > to rmmod a codec driver fails with module is in use error after
> > > > rmmod of snd-soc-audio-graph-card for example.
> > > >
> > > > Any ideas what goes wrong there?
> > >
> > > There is an obvious typo: soc_cleanup_component() should call
> > > snd_soc_component_module_put_when_remove() instead of *_close().
> >
> > Making that change locally seems to fix it thanks.
>
> ... and it was already fixed in the later commit 0e36f36b04e7
> "ASoC: soc-core: fix module_put() warning in soc_cleanup_component".
Mark, looks like this commit is still not in Linux next, forgot
to push out something?
Regards,
Tony
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [alsa-devel] Regression in next with codec unload and snd_soc_component_get/put
@ 2019-08-13 10:24 ` Tony Lindgren
0 siblings, 0 replies; 14+ messages in thread
From: Tony Lindgren @ 2019-08-13 10:24 UTC (permalink / raw)
To: Takashi Iwai
Cc: alsa-devel, Kuninori Morimoto, linux-kernel, Jaroslav Kysela,
Mark Brown, linux-omap, linux-arm-kernel
* Takashi Iwai <tiwai@suse.de> [190809 08:24]:
> On Fri, 09 Aug 2019 09:46:43 +0200,
> Tony Lindgren wrote:
> >
> > * Takashi Iwai <tiwai@suse.de> [190809 07:25]:
> > > On Fri, 09 Aug 2019 09:00:03 +0200,
> > > Tony Lindgren wrote:
> > > >
> > > > Hi,
> > > >
> > > > Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add
> > > > snd_soc_component_get/put()") causes a regression where trying
> > > > to rmmod a codec driver fails with module is in use error after
> > > > rmmod of snd-soc-audio-graph-card for example.
> > > >
> > > > Any ideas what goes wrong there?
> > >
> > > There is an obvious typo: soc_cleanup_component() should call
> > > snd_soc_component_module_put_when_remove() instead of *_close().
> >
> > Making that change locally seems to fix it thanks.
>
> ... and it was already fixed in the later commit 0e36f36b04e7
> "ASoC: soc-core: fix module_put() warning in soc_cleanup_component".
Mark, looks like this commit is still not in Linux next, forgot
to push out something?
Regards,
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [alsa-devel] Regression in next with codec unload and snd_soc_component_get/put
2019-08-13 10:24 ` Tony Lindgren
@ 2019-08-13 11:29 ` Mark Brown
-1 siblings, 0 replies; 14+ messages in thread
From: Mark Brown @ 2019-08-13 11:29 UTC (permalink / raw)
To: Tony Lindgren
Cc: Takashi Iwai, Kuninori Morimoto, Jaroslav Kysela, alsa-devel,
linux-omap, linux-kernel, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 399 bytes --]
On Tue, Aug 13, 2019 at 03:24:51AM -0700, Tony Lindgren wrote:
> * Takashi Iwai <tiwai@suse.de> [190809 08:24]:
> > ... and it was already fixed in the later commit 0e36f36b04e7
> > "ASoC: soc-core: fix module_put() warning in soc_cleanup_component".
> Mark, looks like this commit is still not in Linux next, forgot
> to push out something?
There's a build failure the Intel guys haven't fixed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [alsa-devel] Regression in next with codec unload and snd_soc_component_get/put
@ 2019-08-13 11:29 ` Mark Brown
0 siblings, 0 replies; 14+ messages in thread
From: Mark Brown @ 2019-08-13 11:29 UTC (permalink / raw)
To: Tony Lindgren
Cc: alsa-devel, Kuninori Morimoto, Takashi Iwai, linux-kernel,
Jaroslav Kysela, linux-omap, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 399 bytes --]
On Tue, Aug 13, 2019 at 03:24:51AM -0700, Tony Lindgren wrote:
> * Takashi Iwai <tiwai@suse.de> [190809 08:24]:
> > ... and it was already fixed in the later commit 0e36f36b04e7
> > "ASoC: soc-core: fix module_put() warning in soc_cleanup_component".
> Mark, looks like this commit is still not in Linux next, forgot
> to push out something?
There's a build failure the Intel guys haven't fixed.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [alsa-devel] Regression in next with codec unload and snd_soc_component_get/put
2019-08-13 11:29 ` Mark Brown
@ 2019-08-13 14:07 ` Pierre-Louis Bossart
-1 siblings, 0 replies; 14+ messages in thread
From: Pierre-Louis Bossart @ 2019-08-13 14:07 UTC (permalink / raw)
To: Mark Brown, Tony Lindgren
Cc: alsa-devel, Kuninori Morimoto, Takashi Iwai, linux-kernel,
linux-omap, linux-arm-kernel
On 8/13/19 6:29 AM, Mark Brown wrote:
> On Tue, Aug 13, 2019 at 03:24:51AM -0700, Tony Lindgren wrote:
>> * Takashi Iwai <tiwai@suse.de> [190809 08:24]:
>
>>> ... and it was already fixed in the later commit 0e36f36b04e7
>>> "ASoC: soc-core: fix module_put() warning in soc_cleanup_component".
>
>> Mark, looks like this commit is still not in Linux next, forgot
>> to push out something?
>
> There's a build failure the Intel guys haven't fixed.
see ('ASoC: SOF: fix HDA direct MMIO access') posted on alsa-devel
yesterday
https://mailman.alsa-project.org/pipermail/alsa-devel/2019-August/153914.html
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [alsa-devel] Regression in next with codec unload and snd_soc_component_get/put
@ 2019-08-13 14:07 ` Pierre-Louis Bossart
0 siblings, 0 replies; 14+ messages in thread
From: Pierre-Louis Bossart @ 2019-08-13 14:07 UTC (permalink / raw)
To: Mark Brown, Tony Lindgren
Cc: alsa-devel, Kuninori Morimoto, Takashi Iwai, linux-kernel,
linux-omap, linux-arm-kernel
On 8/13/19 6:29 AM, Mark Brown wrote:
> On Tue, Aug 13, 2019 at 03:24:51AM -0700, Tony Lindgren wrote:
>> * Takashi Iwai <tiwai@suse.de> [190809 08:24]:
>
>>> ... and it was already fixed in the later commit 0e36f36b04e7
>>> "ASoC: soc-core: fix module_put() warning in soc_cleanup_component".
>
>> Mark, looks like this commit is still not in Linux next, forgot
>> to push out something?
>
> There's a build failure the Intel guys haven't fixed.
see ('ASoC: SOF: fix HDA direct MMIO access') posted on alsa-devel
yesterday
https://mailman.alsa-project.org/pipermail/alsa-devel/2019-August/153914.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-08-13 14:07 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-09 7:00 Regression in next with codec unload and snd_soc_component_get/put Tony Lindgren
2019-08-09 7:00 ` Tony Lindgren
2019-08-09 7:25 ` [alsa-devel] " Takashi Iwai
2019-08-09 7:25 ` Takashi Iwai
2019-08-09 7:46 ` Tony Lindgren
2019-08-09 7:46 ` Tony Lindgren
2019-08-09 8:23 ` Takashi Iwai
2019-08-09 8:23 ` Takashi Iwai
2019-08-13 10:24 ` Tony Lindgren
2019-08-13 10:24 ` Tony Lindgren
2019-08-13 11:29 ` Mark Brown
2019-08-13 11:29 ` Mark Brown
2019-08-13 14:07 ` Pierre-Louis Bossart
2019-08-13 14:07 ` Pierre-Louis Bossart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.