From: Christoph Hellwig <hch@lst.de>
To: Julien Grall <julien.grall@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, xen-devel@lists.xenproject.org,
Christoph Hellwig <hch@lst.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Xen-devel] [PATCH 07/11] swiotlb-xen: provide a single page-coherent.h header
Date: Sat, 17 Aug 2019 08:50:11 +0200 [thread overview]
Message-ID: <20190817065011.GA18599@lst.de> (raw)
In-Reply-To: <9a3261c6-5d92-cf6b-1ae8-3a8e8b5ef0d4@arm.com>
On Fri, Aug 16, 2019 at 11:40:43PM +0100, Julien Grall wrote:
> I am not sure I agree with this rename. The implementation of the helpers
> are very Arm specific as this is assuming Dom0 is 1:1 mapped.
>
> This was necessary due to the lack of IOMMU on Arm platforms back then.
> But this is now a pain to get rid of it on newer platform...
So if you look at the final version of the header after the whole
series, what assumes a 1:1 mapping? It all just is
if (pfn_valid())
local cache sync;
else
call into the arch code;
are you concerned that the local cache sync might have to be split
up more for a non-1:1 map in that case? We could just move
the xen_dma_* routines into the arch instead of __xen_dma, but it
really helps to have a common interface header.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Julien Grall <julien.grall@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, xen-devel@lists.xenproject.org,
Christoph Hellwig <hch@lst.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Xen-devel] [PATCH 07/11] swiotlb-xen: provide a single page-coherent.h header
Date: Sat, 17 Aug 2019 08:50:11 +0200 [thread overview]
Message-ID: <20190817065011.GA18599@lst.de> (raw)
In-Reply-To: <9a3261c6-5d92-cf6b-1ae8-3a8e8b5ef0d4@arm.com>
On Fri, Aug 16, 2019 at 11:40:43PM +0100, Julien Grall wrote:
> I am not sure I agree with this rename. The implementation of the helpers
> are very Arm specific as this is assuming Dom0 is 1:1 mapped.
>
> This was necessary due to the lack of IOMMU on Arm platforms back then.
> But this is now a pain to get rid of it on newer platform...
So if you look at the final version of the header after the whole
series, what assumes a 1:1 mapping? It all just is
if (pfn_valid())
local cache sync;
else
call into the arch code;
are you concerned that the local cache sync might have to be split
up more for a non-1:1 map in that case? We could just move
the xen_dma_* routines into the arch instead of __xen_dma, but it
really helps to have a common interface header.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Julien Grall <julien.grall@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, xen-devel@lists.xenproject.org,
Christoph Hellwig <hch@lst.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Xen-devel] [PATCH 07/11] swiotlb-xen: provide a single page-coherent.h header
Date: Sat, 17 Aug 2019 08:50:11 +0200 [thread overview]
Message-ID: <20190817065011.GA18599@lst.de> (raw)
In-Reply-To: <9a3261c6-5d92-cf6b-1ae8-3a8e8b5ef0d4@arm.com>
On Fri, Aug 16, 2019 at 11:40:43PM +0100, Julien Grall wrote:
> I am not sure I agree with this rename. The implementation of the helpers
> are very Arm specific as this is assuming Dom0 is 1:1 mapped.
>
> This was necessary due to the lack of IOMMU on Arm platforms back then.
> But this is now a pain to get rid of it on newer platform...
So if you look at the final version of the header after the whole
series, what assumes a 1:1 mapping? It all just is
if (pfn_valid())
local cache sync;
else
call into the arch code;
are you concerned that the local cache sync might have to be split
up more for a non-1:1 map in that case? We could just move
the xen_dma_* routines into the arch instead of __xen_dma, but it
really helps to have a common interface header.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Julien Grall <julien.grall@arm.com>
Cc: Christoph Hellwig <hch@lst.de>,
Stefano Stabellini <sstabellini@kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
xen-devel@lists.xenproject.org, iommu@lists.linux-foundation.org,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Xen-devel] [PATCH 07/11] swiotlb-xen: provide a single page-coherent.h header
Date: Sat, 17 Aug 2019 08:50:11 +0200 [thread overview]
Message-ID: <20190817065011.GA18599@lst.de> (raw)
In-Reply-To: <9a3261c6-5d92-cf6b-1ae8-3a8e8b5ef0d4@arm.com>
On Fri, Aug 16, 2019 at 11:40:43PM +0100, Julien Grall wrote:
> I am not sure I agree with this rename. The implementation of the helpers
> are very Arm specific as this is assuming Dom0 is 1:1 mapped.
>
> This was necessary due to the lack of IOMMU on Arm platforms back then.
> But this is now a pain to get rid of it on newer platform...
So if you look at the final version of the header after the whole
series, what assumes a 1:1 mapping? It all just is
if (pfn_valid())
local cache sync;
else
call into the arch code;
are you concerned that the local cache sync might have to be split
up more for a non-1:1 map in that case? We could just move
the xen_dma_* routines into the arch instead of __xen_dma, but it
really helps to have a common interface header.
next prev parent reply other threads:[~2019-08-17 6:50 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 13:00 swiotlb-xen cleanups Christoph Hellwig
2019-08-16 13:00 ` Christoph Hellwig
2019-08-16 13:00 ` Christoph Hellwig
2019-08-16 13:00 ` [Xen-devel] " Christoph Hellwig
2019-08-16 13:00 ` [PATCH 01/11] xen/arm: use dma-noncoherent.h calls for xen-swiotlb cache maintainance Christoph Hellwig
2019-08-16 13:00 ` Christoph Hellwig
2019-08-16 13:00 ` Christoph Hellwig
2019-08-16 13:00 ` [Xen-devel] " Christoph Hellwig
2019-08-19 11:45 ` Julien Grall
2019-08-19 11:45 ` Julien Grall
2019-08-19 11:45 ` Julien Grall
2019-08-19 11:45 ` Julien Grall
2019-08-26 9:20 ` Christoph Hellwig
2019-08-26 9:20 ` Christoph Hellwig
2019-08-26 9:20 ` Christoph Hellwig
2019-08-26 9:20 ` Christoph Hellwig
2019-08-16 13:00 ` [PATCH 02/11] xen/arm: use dev_is_dma_coherent Christoph Hellwig
2019-08-16 13:00 ` Christoph Hellwig
2019-08-16 13:00 ` Christoph Hellwig
2019-08-16 13:00 ` [Xen-devel] " Christoph Hellwig
2019-08-19 11:31 ` Julien Grall
2019-08-19 11:31 ` Julien Grall
2019-08-19 11:31 ` Julien Grall
2019-08-19 11:31 ` Julien Grall
2019-08-16 13:00 ` [PATCH 03/11] xen/arm: pass one less argument to dma_cache_maint Christoph Hellwig
2019-08-16 13:00 ` Christoph Hellwig
2019-08-16 13:00 ` Christoph Hellwig
2019-08-16 13:00 ` [Xen-devel] " Christoph Hellwig
2019-08-16 13:37 ` Robin Murphy
2019-08-16 13:37 ` Robin Murphy
2019-08-16 13:37 ` Robin Murphy
2019-08-16 13:37 ` [Xen-devel] " Robin Murphy
2019-08-16 16:43 ` Christoph Hellwig
2019-08-16 16:43 ` Christoph Hellwig
2019-08-16 16:43 ` Christoph Hellwig
2019-08-16 16:43 ` [Xen-devel] " Christoph Hellwig
2019-08-16 13:00 ` [PATCH 04/11] xen/arm: remove xen_dma_ops Christoph Hellwig
2019-08-16 13:00 ` Christoph Hellwig
2019-08-16 13:00 ` Christoph Hellwig
2019-08-16 13:00 ` [Xen-devel] " Christoph Hellwig
2019-08-19 11:38 ` Julien Grall
2019-08-19 11:38 ` Julien Grall
2019-08-19 11:38 ` Julien Grall
2019-08-19 11:38 ` Julien Grall
2019-08-16 13:00 ` [PATCH 05/11] xen: remove the exports for xen_{create, destroy}_contiguous_region Christoph Hellwig
2019-08-16 13:00 ` [PATCH 05/11] xen: remove the exports for xen_{create,destroy}_contiguous_region Christoph Hellwig
2019-08-16 13:00 ` [PATCH 05/11] xen: remove the exports for xen_{create, destroy}_contiguous_region Christoph Hellwig
2019-08-16 13:00 ` [Xen-devel] " Christoph Hellwig
2019-08-16 13:00 ` [PATCH 06/11] swiotlb-xen: always use dma-direct helpers to alloc coherent pages Christoph Hellwig
2019-08-16 13:00 ` Christoph Hellwig
2019-08-16 13:00 ` Christoph Hellwig
2019-08-16 13:00 ` [Xen-devel] " Christoph Hellwig
2019-08-16 13:00 ` [PATCH 07/11] swiotlb-xen: provide a single page-coherent.h header Christoph Hellwig
2019-08-16 13:00 ` Christoph Hellwig
2019-08-16 13:00 ` Christoph Hellwig
2019-08-16 13:00 ` [Xen-devel] " Christoph Hellwig
2019-08-16 22:40 ` Julien Grall
2019-08-16 22:40 ` Julien Grall
2019-08-16 22:40 ` Julien Grall
2019-08-16 22:40 ` Julien Grall
2019-08-17 6:50 ` Christoph Hellwig [this message]
2019-08-17 6:50 ` Christoph Hellwig
2019-08-17 6:50 ` Christoph Hellwig
2019-08-17 6:50 ` Christoph Hellwig
2019-08-17 18:20 ` Julien Grall
2019-08-17 18:20 ` Julien Grall
2019-08-17 18:20 ` Julien Grall
2019-08-17 18:20 ` Julien Grall
2019-08-16 13:00 ` [PATCH 08/11] swiotlb-xen: use the same foreign page check everywhere Christoph Hellwig
2019-08-16 13:00 ` Christoph Hellwig
2019-08-16 13:00 ` Christoph Hellwig
2019-08-16 13:00 ` [Xen-devel] " Christoph Hellwig
2019-08-19 13:53 ` Julien Grall
2019-08-19 13:53 ` Julien Grall
2019-08-19 13:53 ` Julien Grall
2019-08-19 13:53 ` Julien Grall
2019-08-16 13:00 ` [PATCH 09/11] swiotlb-xen: simplify cache maintainance Christoph Hellwig
2019-08-16 13:00 ` Christoph Hellwig
2019-08-16 13:00 ` Christoph Hellwig
2019-08-16 13:00 ` [Xen-devel] " Christoph Hellwig
2019-08-16 13:00 ` [PATCH 10/11] swiotlb-xen: merge xen_unmap_single into xen_swiotlb_unmap_page Christoph Hellwig
2019-08-16 13:00 ` Christoph Hellwig
2019-08-16 13:00 ` Christoph Hellwig
2019-08-16 13:00 ` [Xen-devel] " Christoph Hellwig
2019-08-16 13:00 ` [PATCH 11/11] arm64: use asm-generic/dma-mapping.h Christoph Hellwig
2019-08-16 13:00 ` Christoph Hellwig
2019-08-16 13:00 ` Christoph Hellwig
2019-08-16 13:00 ` [Xen-devel] " Christoph Hellwig
2019-08-19 7:32 ` Will Deacon
2019-08-19 7:32 ` Will Deacon
2019-08-19 7:32 ` Will Deacon
2019-08-19 7:32 ` [Xen-devel] " Will Deacon
2019-08-27 2:00 ` swiotlb-xen cleanups Stefano Stabellini
2019-08-27 2:00 ` Stefano Stabellini
2019-08-27 2:00 ` Stefano Stabellini
2019-08-27 2:00 ` [Xen-devel] " Stefano Stabellini
2019-08-27 6:21 ` Christoph Hellwig
2019-08-27 6:21 ` Christoph Hellwig
2019-08-27 6:21 ` Christoph Hellwig
2019-08-27 6:21 ` [Xen-devel] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190817065011.GA18599@lst.de \
--to=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.