All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Mason Yang <masonccyang@mxic.com.tw>
Cc: kstewart@linuxfoundation.org, vigneshr@ti.com,
	bbrezillon@kernel.org, juliensu@mxic.com.tw, richard@nod.at,
	linux-kernel@vger.kernel.org, frieder.schrempf@kontron.de,
	marek.vasut@gmail.com, linux-mtd@lists.infradead.org,
	tglx@linutronix.de, computersforpeace@gmail.com,
	dwmw2@infradead.org
Subject: Re: [PATCH] Add support for Macronix NAND randomizer
Date: Sat, 24 Aug 2019 13:03:29 +0200	[thread overview]
Message-ID: <20190824130329.68f310aa@xps13> (raw)
In-Reply-To: <1566280428-4159-1-git-send-email-masonccyang@mxic.com.tw>

Hi Mason,

Mason Yang <masonccyang@mxic.com.tw> wrote on Tue, 20 Aug 2019 13:53:48
+0800:

> Macronix NANDs support randomizer operation for user data scrambled,
> which can be enabled with a SET_FEATURE.
> 
> User data written to the NAND device without randomizer is still readable
> after randomizer function enabled.
> The penalty of randomizer are NOP = 1 instead of NOP = 4 and more time period

please don't use 'NOP' here, use 'subpage accesses' instead, otherwise
people might not understand what it means while it has a real impact.

> is needed in program operation and entering deep power-down mode.
> i.e., tPROG 300us to 340us(randomizer enabled)
> 
> If subpage write not available with hardware ECC, for example,
> NAND chip options NAND_NO_SUBPAGE_WRITE be set in driver and
> randomizer function is recommended for high-reliability.
> Driver checks byte 167 of Vendor Blocks in ONFI parameter page table
> to see if this high-reliability function is supported.
> 

You did not flagged this patch as a v2 and forgot about the changelog.
You did not listen to our comments in the last version neither. I was
open to a solution with a specific DT property for warned users but I
don't see it coming.
 

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Mason Yang <masonccyang@mxic.com.tw>
Cc: richard@nod.at, marek.vasut@gmail.com, dwmw2@infradead.org,
	bbrezillon@kernel.org, computersforpeace@gmail.com,
	vigneshr@ti.com, kstewart@linuxfoundation.org,
	juliensu@mxic.com.tw, linux-kernel@vger.kernel.org,
	frieder.schrempf@kontron.de, linux-mtd@lists.infradead.org,
	tglx@linutronix.de
Subject: Re: [PATCH] Add support for Macronix NAND randomizer
Date: Sat, 24 Aug 2019 13:03:29 +0200	[thread overview]
Message-ID: <20190824130329.68f310aa@xps13> (raw)
In-Reply-To: <1566280428-4159-1-git-send-email-masonccyang@mxic.com.tw>

Hi Mason,

Mason Yang <masonccyang@mxic.com.tw> wrote on Tue, 20 Aug 2019 13:53:48
+0800:

> Macronix NANDs support randomizer operation for user data scrambled,
> which can be enabled with a SET_FEATURE.
> 
> User data written to the NAND device without randomizer is still readable
> after randomizer function enabled.
> The penalty of randomizer are NOP = 1 instead of NOP = 4 and more time period

please don't use 'NOP' here, use 'subpage accesses' instead, otherwise
people might not understand what it means while it has a real impact.

> is needed in program operation and entering deep power-down mode.
> i.e., tPROG 300us to 340us(randomizer enabled)
> 
> If subpage write not available with hardware ECC, for example,
> NAND chip options NAND_NO_SUBPAGE_WRITE be set in driver and
> randomizer function is recommended for high-reliability.
> Driver checks byte 167 of Vendor Blocks in ONFI parameter page table
> to see if this high-reliability function is supported.
> 

You did not flagged this patch as a v2 and forgot about the changelog.
You did not listen to our comments in the last version neither. I was
open to a solution with a specific DT property for warned users but I
don't see it coming.
 

Thanks,
Miquèl

  reply	other threads:[~2019-08-24 11:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-20  5:53 [PATCH] Add support for Macronix NAND randomizer Mason Yang
2019-08-20  5:53 ` Mason Yang
2019-08-24 11:03 ` Miquel Raynal [this message]
2019-08-24 11:03   ` Miquel Raynal
2019-08-26  2:52   ` masonccyang
2019-08-26  2:52     ` masonccyang
2019-08-26  7:23     ` Miquel Raynal
2019-08-26  7:23       ` Miquel Raynal
2019-08-26  9:24       ` masonccyang
2019-08-26  9:24         ` masonccyang
2019-08-29  9:07   ` masonccyang
2019-08-29  9:07     ` masonccyang
2019-08-30  9:51     ` Miquel Raynal
2019-08-30  9:51       ` Miquel Raynal
2019-09-02  6:53       ` masonccyang
2019-09-02  6:53         ` masonccyang
2019-09-02  7:05         ` Richard Weinberger
2019-09-02  7:05           ` Richard Weinberger
2019-09-02  7:39           ` masonccyang
2019-09-02  7:39             ` masonccyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190824130329.68f310aa@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=bbrezillon@kernel.org \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=frieder.schrempf@kontron.de \
    --cc=juliensu@mxic.com.tw \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=masonccyang@mxic.com.tw \
    --cc=richard@nod.at \
    --cc=tglx@linutronix.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.