All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: masonccyang@mxic.com.tw
Cc: kstewart@linuxfoundation.org, vigneshr@ti.com,
	bbrezillon@kernel.org, juliensu@mxic.com.tw, richard@nod.at,
	linux-kernel@vger.kernel.org, frieder.schrempf@kontron.de,
	marek.vasut@gmail.com, linux-mtd@lists.infradead.org,
	tglx@linutronix.de, computersforpeace@gmail.com,
	dwmw2@infradead.org
Subject: Re: [PATCH] Add support for Macronix NAND randomizer
Date: Fri, 30 Aug 2019 11:51:00 +0200	[thread overview]
Message-ID: <20190830115100.3fec9bf1@xps13> (raw)
In-Reply-To: <OF22C5A579.E2E7676F-ON48258465.002F7F69-48258465.00322849@mxic.com.tw>

Hi Mason,

masonccyang@mxic.com.tw wrote on Thu, 29 Aug 2019 17:07:51 +0800:

> Hi Miquel, 
> 
> 
> > > 
> > > If subpage write not available with hardware ECC, for example,
> > > NAND chip options NAND_NO_SUBPAGE_WRITE be set in driver and
> > > randomizer function is recommended for high-reliability.
> > > Driver checks byte 167 of Vendor Blocks in ONFI parameter page table
> > > to see if this high-reliability function is supported.
> > >   
> > 
> > You did not flagged this patch as a v2 and forgot about the changelog.
> > You did not listen to our comments in the last version neither. I was
> > open to a solution with a specific DT property for warned users but I
> > don't see it coming.
> >   
> 
> Based on your comments by specific DT property for randomizer support.
> to add a new property in children nodes:
> 
> i.e,.
> 
> nand: nand-controller@43c30000 {
> 
>                 nand@0 {
>                         reg = <0>;
>                         nand-reliability = "randomizer";

                          mxic,enable-randomizer-otp;

Would be better (with the proper documentation in the bindings).


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: masonccyang@mxic.com.tw
Cc: bbrezillon@kernel.org, computersforpeace@gmail.com,
	dwmw2@infradead.org, frieder.schrempf@kontron.de,
	juliensu@mxic.com.tw, kstewart@linuxfoundation.org,
	linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
	marek.vasut@gmail.com, richard@nod.at, tglx@linutronix.de,
	vigneshr@ti.com
Subject: Re: [PATCH] Add support for Macronix NAND randomizer
Date: Fri, 30 Aug 2019 11:51:00 +0200	[thread overview]
Message-ID: <20190830115100.3fec9bf1@xps13> (raw)
In-Reply-To: <OF22C5A579.E2E7676F-ON48258465.002F7F69-48258465.00322849@mxic.com.tw>

Hi Mason,

masonccyang@mxic.com.tw wrote on Thu, 29 Aug 2019 17:07:51 +0800:

> Hi Miquel, 
> 
> 
> > > 
> > > If subpage write not available with hardware ECC, for example,
> > > NAND chip options NAND_NO_SUBPAGE_WRITE be set in driver and
> > > randomizer function is recommended for high-reliability.
> > > Driver checks byte 167 of Vendor Blocks in ONFI parameter page table
> > > to see if this high-reliability function is supported.
> > >   
> > 
> > You did not flagged this patch as a v2 and forgot about the changelog.
> > You did not listen to our comments in the last version neither. I was
> > open to a solution with a specific DT property for warned users but I
> > don't see it coming.
> >   
> 
> Based on your comments by specific DT property for randomizer support.
> to add a new property in children nodes:
> 
> i.e,.
> 
> nand: nand-controller@43c30000 {
> 
>                 nand@0 {
>                         reg = <0>;
>                         nand-reliability = "randomizer";

                          mxic,enable-randomizer-otp;

Would be better (with the proper documentation in the bindings).


Thanks,
Miquèl

  reply	other threads:[~2019-08-30  9:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-20  5:53 [PATCH] Add support for Macronix NAND randomizer Mason Yang
2019-08-20  5:53 ` Mason Yang
2019-08-24 11:03 ` Miquel Raynal
2019-08-24 11:03   ` Miquel Raynal
2019-08-26  2:52   ` masonccyang
2019-08-26  2:52     ` masonccyang
2019-08-26  7:23     ` Miquel Raynal
2019-08-26  7:23       ` Miquel Raynal
2019-08-26  9:24       ` masonccyang
2019-08-26  9:24         ` masonccyang
2019-08-29  9:07   ` masonccyang
2019-08-29  9:07     ` masonccyang
2019-08-30  9:51     ` Miquel Raynal [this message]
2019-08-30  9:51       ` Miquel Raynal
2019-09-02  6:53       ` masonccyang
2019-09-02  6:53         ` masonccyang
2019-09-02  7:05         ` Richard Weinberger
2019-09-02  7:05           ` Richard Weinberger
2019-09-02  7:39           ` masonccyang
2019-09-02  7:39             ` masonccyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190830115100.3fec9bf1@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=bbrezillon@kernel.org \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=frieder.schrempf@kontron.de \
    --cc=juliensu@mxic.com.tw \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=masonccyang@mxic.com.tw \
    --cc=richard@nod.at \
    --cc=tglx@linutronix.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.