All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Efremov <efremov@linux.com>
To: cocci@systeme.lip6.fr
Cc: Michal Marek <michal.lkml@markovi.net>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	linux-kernel@vger.kernel.org
Subject: [Cocci] [PATCH] scripts: coccinelle: check for !(un)?likely usage
Date: Sun, 25 Aug 2019 16:05:36 +0300	[thread overview]
Message-ID: <20190825130536.14683-1-efremov@linux.com> (raw)

This patch adds coccinelle script for detecting !likely and !unlikely
usage. It's better to use unlikely instead of !likely and vice versa.

Signed-off-by: Denis Efremov <efremov@linux.com>
---
 scripts/coccinelle/misc/unlikely.cocci | 70 ++++++++++++++++++++++++++
 1 file changed, 70 insertions(+)
 create mode 100644 scripts/coccinelle/misc/unlikely.cocci

diff --git a/scripts/coccinelle/misc/unlikely.cocci b/scripts/coccinelle/misc/unlikely.cocci
new file mode 100644
index 000000000000..88278295d76a
--- /dev/null
+++ b/scripts/coccinelle/misc/unlikely.cocci
@@ -0,0 +1,70 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/// Use unlikely instead of !likely and likely instead of !unlikely.
+///
+// Confidence: High
+// Copyright: (C) 2019 Denis Efremov, ISPRAS.
+// Options: --include-headers
+
+virtual patch
+virtual context
+virtual org
+virtual report
+
+//----------------------------------------------------------
+//  For context mode
+//----------------------------------------------------------
+
+@depends on context disable unlikely@
+expression E;
+@@
+
+(
+* !likely(E)
+|
+* !unlikely(E)
+)
+
+//----------------------------------------------------------
+//  For patch mode
+//----------------------------------------------------------
+
+@depends on patch disable unlikely@
+expression E;
+@@
+
+(
+-!likely(E)
++unlikely(E)
+|
+-!unlikely(E)
++likely(E)
+)
+
+//----------------------------------------------------------
+//  For org and report mode
+//----------------------------------------------------------
+
+@r depends on (org || report) disable unlikely@
+expression E;
+position p;
+@@
+
+(
+ !likely@p(E)
+|
+ !unlikely@p(E)
+)
+
+@script:python depends on org@
+p << r.p;
+@@
+
+coccilib.org.print_todo(p[0], "WARNING use unlikely instead of !likely")
+
+@script:python depends on report@
+p << r.p;
+@@
+
+msg="WARNING: Use unlikely instead of !likely"
+coccilib.report.print_report(p[0], msg)
+
-- 
2.21.0

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

WARNING: multiple messages have this Message-ID (diff)
From: Denis Efremov <efremov@linux.com>
To: cocci@systeme.lip6.fr
Cc: Denis Efremov <efremov@linux.com>,
	linux-kernel@vger.kernel.org, Julia Lawall <Julia.Lawall@lip6.fr>,
	Gilles Muller <Gilles.Muller@lip6.fr>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	Michal Marek <michal.lkml@markovi.net>
Subject: [PATCH] scripts: coccinelle: check for !(un)?likely usage
Date: Sun, 25 Aug 2019 16:05:36 +0300	[thread overview]
Message-ID: <20190825130536.14683-1-efremov@linux.com> (raw)

This patch adds coccinelle script for detecting !likely and !unlikely
usage. It's better to use unlikely instead of !likely and vice versa.

Signed-off-by: Denis Efremov <efremov@linux.com>
---
 scripts/coccinelle/misc/unlikely.cocci | 70 ++++++++++++++++++++++++++
 1 file changed, 70 insertions(+)
 create mode 100644 scripts/coccinelle/misc/unlikely.cocci

diff --git a/scripts/coccinelle/misc/unlikely.cocci b/scripts/coccinelle/misc/unlikely.cocci
new file mode 100644
index 000000000000..88278295d76a
--- /dev/null
+++ b/scripts/coccinelle/misc/unlikely.cocci
@@ -0,0 +1,70 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/// Use unlikely instead of !likely and likely instead of !unlikely.
+///
+// Confidence: High
+// Copyright: (C) 2019 Denis Efremov, ISPRAS.
+// Options: --include-headers
+
+virtual patch
+virtual context
+virtual org
+virtual report
+
+//----------------------------------------------------------
+//  For context mode
+//----------------------------------------------------------
+
+@depends on context disable unlikely@
+expression E;
+@@
+
+(
+* !likely(E)
+|
+* !unlikely(E)
+)
+
+//----------------------------------------------------------
+//  For patch mode
+//----------------------------------------------------------
+
+@depends on patch disable unlikely@
+expression E;
+@@
+
+(
+-!likely(E)
++unlikely(E)
+|
+-!unlikely(E)
++likely(E)
+)
+
+//----------------------------------------------------------
+//  For org and report mode
+//----------------------------------------------------------
+
+@r depends on (org || report) disable unlikely@
+expression E;
+position p;
+@@
+
+(
+ !likely@p(E)
+|
+ !unlikely@p(E)
+)
+
+@script:python depends on org@
+p << r.p;
+@@
+
+coccilib.org.print_todo(p[0], "WARNING use unlikely instead of !likely")
+
+@script:python depends on report@
+p << r.p;
+@@
+
+msg="WARNING: Use unlikely instead of !likely"
+coccilib.report.print_report(p[0], msg)
+
-- 
2.21.0


             reply	other threads:[~2019-08-25 13:06 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-25 13:05 Denis Efremov [this message]
2019-08-25 13:05 ` [PATCH] scripts: coccinelle: check for !(un)?likely usage Denis Efremov
2019-08-25 15:30 ` [Cocci] " Markus Elfring
2019-08-25 15:30   ` Markus Elfring
2019-08-25 21:06   ` [Cocci] " Denis Efremov
2019-08-25 21:06     ` Denis Efremov
2019-08-25 15:30 ` [Cocci] " Markus Elfring
2019-08-25 15:30   ` Markus Elfring
2019-08-25 16:37 ` [Cocci] " Joe Perches
2019-08-25 16:37   ` Joe Perches
2019-08-25 18:59   ` [Cocci] " Denis Efremov
2019-08-25 18:59     ` Denis Efremov
2019-08-25 19:19     ` [Cocci] " Julia Lawall
2019-08-25 19:19       ` Julia Lawall
2019-08-28 11:33       ` [Cocci] " Rasmus Villemoes
2019-08-28 11:33         ` Rasmus Villemoes
2019-08-28 11:59         ` [Cocci] " Joe Perches
2019-08-28 11:59           ` Joe Perches
2019-08-28 12:33         ` [Cocci] " Denis Efremov
2019-08-28 12:33           ` Denis Efremov
2019-08-28 13:05           ` Rasmus Villemoes
2019-08-28 13:14             ` Denis Efremov
2019-08-28 12:33         ` [Cocci] " Julia Lawall
2019-08-28 12:33           ` Julia Lawall
2019-08-28 12:41       ` [Cocci] " Denis Efremov
2019-08-28 12:41         ` Denis Efremov
2019-08-28 13:57         ` [Cocci] " Denis Efremov
2019-08-28 13:57           ` Denis Efremov
2019-08-25 21:19     ` [Cocci] " Denis Efremov
2019-08-25 21:19       ` Denis Efremov
2019-09-01 17:24   ` Pavel Machek
2019-09-01 17:39     ` [Cocci] " Denis Efremov
2019-09-01 17:39       ` Denis Efremov
2019-08-29 17:10 ` [Cocci] [PATCH v2] " Denis Efremov
2019-08-29 17:10   ` Denis Efremov
2019-08-29 17:13   ` [Cocci] " Denis Efremov
2019-08-29 17:13     ` Denis Efremov
2019-08-30  0:42     ` [Cocci] " Julia Lawall
2019-08-30  0:42       ` Julia Lawall
2019-08-30  6:56       ` [Cocci] " Denis Efremov
2019-08-30  6:56         ` Denis Efremov
2019-08-30  8:06         ` [Cocci] " Rasmus Villemoes
2019-08-30  8:06           ` Rasmus Villemoes
2019-08-29 20:07   ` [Cocci] " Markus Elfring
2019-08-29 20:07     ` Markus Elfring
2019-08-30  7:55   ` [Cocci] " Markus Elfring
2019-08-30  7:55     ` Markus Elfring
2019-08-30  7:55     ` Markus Elfring
2019-09-06 20:19   ` [Cocci] " Julia Lawall
2019-09-06 20:19     ` Julia Lawall
2019-09-06 20:55     ` [Cocci] " Denis Efremov
2019-09-06 20:55       ` Denis Efremov
2019-09-07  8:05       ` [Cocci] [v2] " Markus Elfring
2019-09-07  8:05         ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190825130536.14683-1-efremov@linux.com \
    --to=efremov@linux.com \
    --cc=cocci@systeme.lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=nicolas.palix@imag.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.