From: Denis Efremov <efremov@linux.com>
To: Pavel Machek <pavel@ucw.cz>, Joe Perches <joe@perches.com>
Cc: Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>,
linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr
Subject: Re: [Cocci] [PATCH] scripts: coccinelle: check for !(un)?likely usage
Date: Sun, 1 Sep 2019 20:39:30 +0300 [thread overview]
Message-ID: <45362841-2ae6-e946-2ae0-ab56a98f15ca@linux.com> (raw)
In-Reply-To: <20190901172403.GA1047@bug>
On 01.09.2019 20:24, Pavel Machek wrote:
> Hi!
>
>>> This patch adds coccinelle script for detecting !likely and !unlikely
>>> usage. It's better to use unlikely instead of !likely and vice versa.
>>
>> Please explain _why_ is it better in the changelog.
>>
>> btw: there are relatively few uses like this in the kernel.
>>
>> $ git grep -P '!\s*(?:un)?likely\s*\(' | wc -l
>> 40
>>
>> afaict: It may save 2 bytes of x86/64 object code.
>>
>> For instance:
>>
>> $ diff -urN kernel/tsacct.lst.old kernel/tsacct.lst.new|less
>> --- kernel/tsacct.lst.old 2019-08-25 09:21:39.936570183 -0700
>> +++ kernel/tsacct.lst.new 2019-08-25 09:22:20.774324886 -0700
>> @@ -24,158 +24,153 @@
>> 15: 48 89 fb mov %rdi,%rbx
>> u64 time, delta;
>>
>> - if (!likely(tsk->mm))
>> + if (unlikely(tsk->mm))
>
> Are you sure this is equivalent?
>
> Pavel
Hi,
No, it's not correct. Thanks Rasmus for clarifying the things here.
This was my mistake. As a human, I failed to parse "likely" and "!"
and made too hasty conclusions :)
The correct transformation is in v2. This will be
!likely(tsk->mm) -> unlikely(!tsk->mm)
Thanks,
Denis
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
WARNING: multiple messages have this Message-ID (diff)
From: Denis Efremov <efremov@linux.com>
To: Pavel Machek <pavel@ucw.cz>, Joe Perches <joe@perches.com>
Cc: cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org,
Julia Lawall <Julia.Lawall@lip6.fr>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
Michal Marek <michal.lkml@markovi.net>
Subject: Re: [PATCH] scripts: coccinelle: check for !(un)?likely usage
Date: Sun, 1 Sep 2019 20:39:30 +0300 [thread overview]
Message-ID: <45362841-2ae6-e946-2ae0-ab56a98f15ca@linux.com> (raw)
In-Reply-To: <20190901172403.GA1047@bug>
On 01.09.2019 20:24, Pavel Machek wrote:
> Hi!
>
>>> This patch adds coccinelle script for detecting !likely and !unlikely
>>> usage. It's better to use unlikely instead of !likely and vice versa.
>>
>> Please explain _why_ is it better in the changelog.
>>
>> btw: there are relatively few uses like this in the kernel.
>>
>> $ git grep -P '!\s*(?:un)?likely\s*\(' | wc -l
>> 40
>>
>> afaict: It may save 2 bytes of x86/64 object code.
>>
>> For instance:
>>
>> $ diff -urN kernel/tsacct.lst.old kernel/tsacct.lst.new|less
>> --- kernel/tsacct.lst.old 2019-08-25 09:21:39.936570183 -0700
>> +++ kernel/tsacct.lst.new 2019-08-25 09:22:20.774324886 -0700
>> @@ -24,158 +24,153 @@
>> 15: 48 89 fb mov %rdi,%rbx
>> u64 time, delta;
>>
>> - if (!likely(tsk->mm))
>> + if (unlikely(tsk->mm))
>
> Are you sure this is equivalent?
>
> Pavel
Hi,
No, it's not correct. Thanks Rasmus for clarifying the things here.
This was my mistake. As a human, I failed to parse "likely" and "!"
and made too hasty conclusions :)
The correct transformation is in v2. This will be
!likely(tsk->mm) -> unlikely(!tsk->mm)
Thanks,
Denis
next prev parent reply other threads:[~2019-09-01 17:39 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-25 13:05 [Cocci] [PATCH] scripts: coccinelle: check for !(un)?likely usage Denis Efremov
2019-08-25 13:05 ` Denis Efremov
2019-08-25 15:30 ` [Cocci] " Markus Elfring
2019-08-25 15:30 ` Markus Elfring
2019-08-25 15:30 ` [Cocci] " Markus Elfring
2019-08-25 15:30 ` Markus Elfring
2019-08-25 21:06 ` [Cocci] " Denis Efremov
2019-08-25 21:06 ` Denis Efremov
2019-08-25 16:37 ` [Cocci] " Joe Perches
2019-08-25 16:37 ` Joe Perches
2019-08-25 18:59 ` [Cocci] " Denis Efremov
2019-08-25 18:59 ` Denis Efremov
2019-08-25 19:19 ` [Cocci] " Julia Lawall
2019-08-25 19:19 ` Julia Lawall
2019-08-28 11:33 ` [Cocci] " Rasmus Villemoes
2019-08-28 11:33 ` Rasmus Villemoes
2019-08-28 11:59 ` [Cocci] " Joe Perches
2019-08-28 11:59 ` Joe Perches
2019-08-28 12:33 ` [Cocci] " Denis Efremov
2019-08-28 12:33 ` Denis Efremov
2019-08-28 13:05 ` Rasmus Villemoes
2019-08-28 13:14 ` Denis Efremov
2019-08-28 12:33 ` [Cocci] " Julia Lawall
2019-08-28 12:33 ` Julia Lawall
2019-08-28 12:41 ` [Cocci] " Denis Efremov
2019-08-28 12:41 ` Denis Efremov
2019-08-28 13:57 ` [Cocci] " Denis Efremov
2019-08-28 13:57 ` Denis Efremov
2019-08-25 21:19 ` [Cocci] " Denis Efremov
2019-08-25 21:19 ` Denis Efremov
2019-09-01 17:24 ` Pavel Machek
2019-09-01 17:39 ` Denis Efremov [this message]
2019-09-01 17:39 ` Denis Efremov
2019-08-29 17:10 ` [Cocci] [PATCH v2] " Denis Efremov
2019-08-29 17:10 ` Denis Efremov
2019-08-29 17:13 ` [Cocci] " Denis Efremov
2019-08-29 17:13 ` Denis Efremov
2019-08-30 0:42 ` [Cocci] " Julia Lawall
2019-08-30 0:42 ` Julia Lawall
2019-08-30 6:56 ` [Cocci] " Denis Efremov
2019-08-30 6:56 ` Denis Efremov
2019-08-30 8:06 ` [Cocci] " Rasmus Villemoes
2019-08-30 8:06 ` Rasmus Villemoes
2019-08-29 20:07 ` [Cocci] " Markus Elfring
2019-08-29 20:07 ` Markus Elfring
2019-08-30 7:55 ` [Cocci] " Markus Elfring
2019-08-30 7:55 ` Markus Elfring
2019-08-30 7:55 ` Markus Elfring
2019-09-06 20:19 ` [Cocci] " Julia Lawall
2019-09-06 20:19 ` Julia Lawall
2019-09-06 20:55 ` [Cocci] " Denis Efremov
2019-09-06 20:55 ` Denis Efremov
2019-09-07 8:05 ` [Cocci] [v2] " Markus Elfring
2019-09-07 8:05 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45362841-2ae6-e946-2ae0-ab56a98f15ca@linux.com \
--to=efremov@linux.com \
--cc=cocci@systeme.lip6.fr \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.