From: Joerg Roedel <joro@8bytes.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: devicetree@vger.kernel.org, Frank Rowand <frowand.list@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org, kernel@pengutronix.de,
Matthias Brugger <matthias.bgg@gmail.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 1/2] iommu: pass cell_count = -1 to of_for_each_phandle with cells_name
Date: Tue, 3 Sep 2019 14:52:10 +0200 [thread overview]
Message-ID: <20190903125210.GB11530@8bytes.org> (raw)
In-Reply-To: <20190824132846.8589-1-u.kleine-koenig@pengutronix.de>
On Sat, Aug 24, 2019 at 03:28:45PM +0200, Uwe Kleine-König wrote:
> Currently of_for_each_phandle ignores the cell_count parameter when a
> cells_name is given. I intend to change that and let the iterator fall
> back to a non-negative cell_count if the cells_name property is missing
> in the referenced node.
>
> To not change how existing of_for_each_phandle's users iterate, fix them
> to pass cell_count = -1 when also cells_name is given which yields the
> expected behaviour with and without my change.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/iommu/arm-smmu.c | 2 +-
> drivers/iommu/mtk_iommu_v1.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Acked-by: Joerg Roedel <jroedel@suse.de>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
devicetree@vger.kernel.org, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH v1 1/2] iommu: pass cell_count = -1 to of_for_each_phandle with cells_name
Date: Tue, 3 Sep 2019 14:52:10 +0200 [thread overview]
Message-ID: <20190903125210.GB11530@8bytes.org> (raw)
In-Reply-To: <20190824132846.8589-1-u.kleine-koenig@pengutronix.de>
On Sat, Aug 24, 2019 at 03:28:45PM +0200, Uwe Kleine-König wrote:
> Currently of_for_each_phandle ignores the cell_count parameter when a
> cells_name is given. I intend to change that and let the iterator fall
> back to a non-negative cell_count if the cells_name property is missing
> in the referenced node.
>
> To not change how existing of_for_each_phandle's users iterate, fix them
> to pass cell_count = -1 when also cells_name is given which yields the
> expected behaviour with and without my change.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/iommu/arm-smmu.c | 2 +-
> drivers/iommu/mtk_iommu_v1.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Acked-by: Joerg Roedel <jroedel@suse.de>
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: devicetree@vger.kernel.org, Frank Rowand <frowand.list@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org, kernel@pengutronix.de,
Matthias Brugger <matthias.bgg@gmail.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 1/2] iommu: pass cell_count = -1 to of_for_each_phandle with cells_name
Date: Tue, 3 Sep 2019 14:52:10 +0200 [thread overview]
Message-ID: <20190903125210.GB11530@8bytes.org> (raw)
In-Reply-To: <20190824132846.8589-1-u.kleine-koenig@pengutronix.de>
On Sat, Aug 24, 2019 at 03:28:45PM +0200, Uwe Kleine-König wrote:
> Currently of_for_each_phandle ignores the cell_count parameter when a
> cells_name is given. I intend to change that and let the iterator fall
> back to a non-negative cell_count if the cells_name property is missing
> in the referenced node.
>
> To not change how existing of_for_each_phandle's users iterate, fix them
> to pass cell_count = -1 when also cells_name is given which yields the
> expected behaviour with and without my change.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/iommu/arm-smmu.c | 2 +-
> drivers/iommu/mtk_iommu_v1.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Acked-by: Joerg Roedel <jroedel@suse.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-03 12:52 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-24 13:28 [PATCH v1 1/2] iommu: pass cell_count = -1 to of_for_each_phandle with cells_name Uwe Kleine-König
2019-08-24 13:28 ` Uwe Kleine-König
2019-08-24 13:28 ` Uwe Kleine-König
2019-08-24 13:28 ` [PATCH v1 2/2] of: Let of_for_each_phandle fallback to non-negative cell_count Uwe Kleine-König
2019-08-24 13:28 ` Uwe Kleine-König
2019-08-24 13:28 ` Uwe Kleine-König
2019-09-02 14:26 ` Rob Herring
2019-09-02 14:26 ` Rob Herring
2019-09-02 14:26 ` Rob Herring
2019-09-13 21:58 ` Rob Herring
2019-09-13 21:58 ` Rob Herring
2019-09-13 21:58 ` Rob Herring
2019-09-17 9:40 ` Geert Uytterhoeven
2019-09-17 9:40 ` Geert Uytterhoeven
2019-09-17 9:40 ` Geert Uytterhoeven
[not found] ` <CAMuHMdV+pwoAA0zH_vQf2nKqzrgHP8rcMStyJbnuu2qviFC_qg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-09-17 10:13 ` Uwe Kleine-König
2019-09-17 10:13 ` Uwe Kleine-König
2019-09-17 10:13 ` Uwe Kleine-König
2019-09-17 10:13 ` Uwe Kleine-König
2019-09-17 11:25 ` Peter Rosin
2019-09-17 11:25 ` Peter Rosin
2019-09-17 11:25 ` Peter Rosin
[not found] ` <489c90fb-a135-4fd8-ecb9-46404bd3c234-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
2019-09-17 12:25 ` Uwe Kleine-König
2019-09-17 12:25 ` Uwe Kleine-König
2019-09-17 12:25 ` Uwe Kleine-König
2019-09-17 12:25 ` Uwe Kleine-König
2019-09-17 12:44 ` Marek Szyprowski
2019-09-17 12:44 ` Marek Szyprowski
2019-09-17 12:44 ` Marek Szyprowski
2019-09-17 12:52 ` Geert Uytterhoeven
2019-09-17 12:52 ` Geert Uytterhoeven
2019-09-17 12:52 ` Geert Uytterhoeven
2019-09-03 12:52 ` Joerg Roedel [this message]
2019-09-03 12:52 ` [PATCH v1 1/2] iommu: pass cell_count = -1 to of_for_each_phandle with cells_name Joerg Roedel
2019-09-03 12:52 ` Joerg Roedel
2019-09-12 7:43 ` Uwe Kleine-König
2019-09-12 7:43 ` Uwe Kleine-König
2019-09-12 7:43 ` Uwe Kleine-König
2019-09-13 7:37 ` Joerg Roedel
2019-09-13 7:37 ` Joerg Roedel
2019-09-13 7:37 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903125210.GB11530@8bytes.org \
--to=joro@8bytes.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.