From: Rob Herring <robh@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: devicetree@vger.kernel.org, Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
linux-mediatek@lists.infradead.org, kernel@pengutronix.de,
Matthias Brugger <matthias.bgg@gmail.com>,
Frank Rowand <frowand.list@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v1 2/2] of: Let of_for_each_phandle fallback to non-negative cell_count
Date: Fri, 13 Sep 2019 16:58:09 -0500 [thread overview]
Message-ID: <20190913215809.GA11833@bogus> (raw)
In-Reply-To: <20190824132846.8589-2-u.kleine-koenig@pengutronix.de>
On Sat, 24 Aug 2019 15:28:46 +0200, =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= wrote:
> Referencing device tree nodes from a property allows to pass arguments.
> This is for example used for referencing gpios. This looks as follows:
>
> gpio_ctrl: gpio-controller {
> #gpio-cells = <2>
> ...
> }
>
> someothernode {
> gpios = <&gpio_ctrl 5 0 &gpio_ctrl 3 0>;
> ...
> }
>
> To know the number of arguments this must be either fixed, or the
> referenced node is checked for a $cells_name (here: "#gpio-cells")
> property and with this information the start of the second reference can
> be determined.
>
> Currently regulators are referenced with no additional arguments. To
> allow some optional arguments without having to change all referenced
> nodes this change introduces a way to specify a default cell_count. So
> when a phandle is parsed we check for the $cells_name property and use
> it as before if present. If it is not present we fall back to
> cells_count if non-negative and only fail if cells_count is smaller than
> zero.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/of/base.c | 25 +++++++++++++++++--------
> 1 file changed, 17 insertions(+), 8 deletions(-)
>
Applied both patches, thanks.
Rob
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH v1 2/2] of: Let of_for_each_phandle fallback to non-negative cell_count
Date: Fri, 13 Sep 2019 16:58:09 -0500 [thread overview]
Message-ID: <20190913215809.GA11833@bogus> (raw)
In-Reply-To: <20190824132846.8589-2-u.kleine-koenig@pengutronix.de>
On Sat, 24 Aug 2019 15:28:46 +0200, =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= wrote:
> Referencing device tree nodes from a property allows to pass arguments.
> This is for example used for referencing gpios. This looks as follows:
>
> gpio_ctrl: gpio-controller {
> #gpio-cells = <2>
> ...
> }
>
> someothernode {
> gpios = <&gpio_ctrl 5 0 &gpio_ctrl 3 0>;
> ...
> }
>
> To know the number of arguments this must be either fixed, or the
> referenced node is checked for a $cells_name (here: "#gpio-cells")
> property and with this information the start of the second reference can
> be determined.
>
> Currently regulators are referenced with no additional arguments. To
> allow some optional arguments without having to change all referenced
> nodes this change introduces a way to specify a default cell_count. So
> when a phandle is parsed we check for the $cells_name property and use
> it as before if present. If it is not present we fall back to
> cells_count if non-negative and only fail if cells_count is smaller than
> zero.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/of/base.c | 25 +++++++++++++++++--------
> 1 file changed, 17 insertions(+), 8 deletions(-)
>
Applied both patches, thanks.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: devicetree@vger.kernel.org, Will Deacon <will@kernel.org>,
Joerg Roedel <joro@8bytes.org>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
linux-mediatek@lists.infradead.org, kernel@pengutronix.de,
Matthias Brugger <matthias.bgg@gmail.com>,
Frank Rowand <frowand.list@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v1 2/2] of: Let of_for_each_phandle fallback to non-negative cell_count
Date: Fri, 13 Sep 2019 16:58:09 -0500 [thread overview]
Message-ID: <20190913215809.GA11833@bogus> (raw)
In-Reply-To: <20190824132846.8589-2-u.kleine-koenig@pengutronix.de>
On Sat, 24 Aug 2019 15:28:46 +0200, =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= wrote:
> Referencing device tree nodes from a property allows to pass arguments.
> This is for example used for referencing gpios. This looks as follows:
>
> gpio_ctrl: gpio-controller {
> #gpio-cells = <2>
> ...
> }
>
> someothernode {
> gpios = <&gpio_ctrl 5 0 &gpio_ctrl 3 0>;
> ...
> }
>
> To know the number of arguments this must be either fixed, or the
> referenced node is checked for a $cells_name (here: "#gpio-cells")
> property and with this information the start of the second reference can
> be determined.
>
> Currently regulators are referenced with no additional arguments. To
> allow some optional arguments without having to change all referenced
> nodes this change introduces a way to specify a default cell_count. So
> when a phandle is parsed we check for the $cells_name property and use
> it as before if present. If it is not present we fall back to
> cells_count if non-negative and only fail if cells_count is smaller than
> zero.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/of/base.c | 25 +++++++++++++++++--------
> 1 file changed, 17 insertions(+), 8 deletions(-)
>
Applied both patches, thanks.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-13 21:58 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-24 13:28 [PATCH v1 1/2] iommu: pass cell_count = -1 to of_for_each_phandle with cells_name Uwe Kleine-König
2019-08-24 13:28 ` Uwe Kleine-König
2019-08-24 13:28 ` Uwe Kleine-König
2019-08-24 13:28 ` [PATCH v1 2/2] of: Let of_for_each_phandle fallback to non-negative cell_count Uwe Kleine-König
2019-08-24 13:28 ` Uwe Kleine-König
2019-08-24 13:28 ` Uwe Kleine-König
2019-09-02 14:26 ` Rob Herring
2019-09-02 14:26 ` Rob Herring
2019-09-02 14:26 ` Rob Herring
2019-09-13 21:58 ` Rob Herring [this message]
2019-09-13 21:58 ` Rob Herring
2019-09-13 21:58 ` Rob Herring
2019-09-17 9:40 ` Geert Uytterhoeven
2019-09-17 9:40 ` Geert Uytterhoeven
2019-09-17 9:40 ` Geert Uytterhoeven
[not found] ` <CAMuHMdV+pwoAA0zH_vQf2nKqzrgHP8rcMStyJbnuu2qviFC_qg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-09-17 10:13 ` Uwe Kleine-König
2019-09-17 10:13 ` Uwe Kleine-König
2019-09-17 10:13 ` Uwe Kleine-König
2019-09-17 10:13 ` Uwe Kleine-König
2019-09-17 11:25 ` Peter Rosin
2019-09-17 11:25 ` Peter Rosin
2019-09-17 11:25 ` Peter Rosin
[not found] ` <489c90fb-a135-4fd8-ecb9-46404bd3c234-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
2019-09-17 12:25 ` Uwe Kleine-König
2019-09-17 12:25 ` Uwe Kleine-König
2019-09-17 12:25 ` Uwe Kleine-König
2019-09-17 12:25 ` Uwe Kleine-König
2019-09-17 12:44 ` Marek Szyprowski
2019-09-17 12:44 ` Marek Szyprowski
2019-09-17 12:44 ` Marek Szyprowski
2019-09-17 12:52 ` Geert Uytterhoeven
2019-09-17 12:52 ` Geert Uytterhoeven
2019-09-17 12:52 ` Geert Uytterhoeven
2019-09-03 12:52 ` [PATCH v1 1/2] iommu: pass cell_count = -1 to of_for_each_phandle with cells_name Joerg Roedel
2019-09-03 12:52 ` Joerg Roedel
2019-09-03 12:52 ` Joerg Roedel
2019-09-12 7:43 ` Uwe Kleine-König
2019-09-12 7:43 ` Uwe Kleine-König
2019-09-12 7:43 ` Uwe Kleine-König
2019-09-13 7:37 ` Joerg Roedel
2019-09-13 7:37 ` Joerg Roedel
2019-09-13 7:37 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913215809.GA11833@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robin.murphy@arm.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.