From: Dan Carpenter <dan.carpenter@oracle.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
David Airlie <airlied@linux.ie>, Mark Brown <broonie@kernel.org>,
kernel-janitors@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
dri-devel@lists.freedesktop.org,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] drm: panel-lvds: Potential Oops in probe error handling
Date: Wed, 04 Sep 2019 12:57:04 +0000 [thread overview]
Message-ID: <20190904125704.GC3093@kadam> (raw)
In-Reply-To: <20190904115057.GC4811@pendragon.ideasonboard.com>
On Wed, Sep 04, 2019 at 02:50:57PM +0300, Laurent Pinchart wrote:
> > error:
> > - put_device(&lvds->backlight->dev);
> > + if (lvds->backlight)
> > + put_device(&lvds->backlight->dev);
>
> How about simply
>
> - put_device(&lvds->backlight->dev);
> + backlight_put(lvds->backlight);
Yeah. That's cleaner. I will resend.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
David Airlie <airlied@linux.ie>, Mark Brown <broonie@kernel.org>,
kernel-janitors@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
dri-devel@lists.freedesktop.org,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] drm: panel-lvds: Potential Oops in probe error handling
Date: Wed, 4 Sep 2019 15:57:04 +0300 [thread overview]
Message-ID: <20190904125704.GC3093@kadam> (raw)
In-Reply-To: <20190904115057.GC4811@pendragon.ideasonboard.com>
On Wed, Sep 04, 2019 at 02:50:57PM +0300, Laurent Pinchart wrote:
> > error:
> > - put_device(&lvds->backlight->dev);
> > + if (lvds->backlight)
> > + put_device(&lvds->backlight->dev);
>
> How about simply
>
> - put_device(&lvds->backlight->dev);
> + backlight_put(lvds->backlight);
Yeah. That's cleaner. I will resend.
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-09-04 12:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 10:03 [PATCH] drm: panel-lvds: Potential Oops in probe error handling Dan Carpenter
2019-09-04 10:03 ` Dan Carpenter
2019-09-04 11:50 ` Laurent Pinchart
2019-09-04 11:50 ` Laurent Pinchart
2019-09-04 12:57 ` Dan Carpenter [this message]
2019-09-04 12:57 ` Dan Carpenter
2019-09-04 18:55 ` [PATCH v2] " Dan Carpenter
2019-09-04 18:55 ` Dan Carpenter
2019-09-04 21:48 ` Laurent Pinchart
2019-09-04 21:48 ` Laurent Pinchart
2019-09-08 16:04 ` Sam Ravnborg
2019-09-08 16:04 ` Sam Ravnborg
2019-09-10 13:32 ` Dan Carpenter
2019-09-10 13:32 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904125704.GC3093@kadam \
--to=dan.carpenter@oracle.com \
--cc=airlied@linux.ie \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.