All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: agross@kernel.org, jorge.ramirez-ortiz@linaro.org,
	mturquette@baylibre.com
Cc: bjorn.andersson@linaro.org, niklas.cassel@linaro.org,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] clk: qcom: apcs-msm8916: get parent clock names from DT
Date: Mon, 09 Sep 2019 03:23:54 -0700	[thread overview]
Message-ID: <20190909102354.D60252089F@mail.kernel.org> (raw)
In-Reply-To: <20190826164510.6425-2-jorge.ramirez-ortiz@linaro.org>

Quoting Jorge Ramirez-Ortiz (2019-08-26 09:45:07)
> @@ -61,6 +63,16 @@ static int qcom_apcs_msm8916_clk_probe(struct platform_device *pdev)
>         if (!a53cc)
>                 return -ENOMEM;
>  
> +       /* legacy bindings only defined the pll parent clock (index = 0) with no

Another nitpick: This is wrong multi-line comment style. SHould be a
bare /* on this line.

> +        * name; when both of the parents are specified in the bindings, the
> +        * pll is the second one (index = 1).
> +        */

  parent reply	other threads:[~2019-09-09 10:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-26 16:45 [PATCH 1/5] clk: qcom: gcc: limit GPLL0_AO_OUT operating frequency Jorge Ramirez-Ortiz
2019-08-26 16:45 ` [PATCH 2/5] clk: qcom: apcs-msm8916: get parent clock names from DT Jorge Ramirez-Ortiz
2019-09-09 10:21   ` Stephen Boyd
2019-09-09 14:17     ` Jorge Ramirez-Ortiz, Linaro
2019-09-09 16:17       ` Stephen Boyd
2019-09-09 16:54         ` Jorge Ramirez-Ortiz, Linaro
2019-09-10  9:14           ` Stephen Boyd
2019-09-10  9:34             ` Jorge Ramirez
2019-09-10  9:40               ` Jorge Ramirez
2019-09-10 10:20                 ` Stephen Boyd
2019-09-09 10:23   ` Stephen Boyd [this message]
2019-08-26 16:45 ` [PATCH 3/5] clk: qcom: hfpll: " Jorge Ramirez-Ortiz
2019-09-09 10:22   ` Stephen Boyd
2019-08-26 16:45 ` [PATCH 4/5] clk: qcom: hfpll: register as clock provider Jorge Ramirez-Ortiz
2019-09-09 10:22   ` Stephen Boyd
2019-08-26 16:45 ` [PATCH 5/5] clk: qcom: hfpll: CLK_IGNORE_UNUSED Jorge Ramirez-Ortiz
2019-09-09 10:23   ` Stephen Boyd
2019-09-05  7:30 ` [PATCH 1/5] clk: qcom: gcc: limit GPLL0_AO_OUT operating frequency Jorge Ramirez
2019-09-09 10:05   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190909102354.D60252089F@mail.kernel.org \
    --to=sboyd@kernel.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=jorge.ramirez-ortiz@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=niklas.cassel@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.