[alsa-devel] DPCM: suspicious code in dpcm_prune_paths()

[alsa-devel] DPCM: suspicious code in dpcm_prune_paths()

[Guennadi Liakhovetski]

Hi,

This code in dpcm_prune_paths() seems to have no effect:

		/* is there a valid CODEC DAI widget for this BE */
		for_each_rtd_codec_dai(dpcm->be, i, dai) {
			widget = dai_get_widget(dai, stream);

			/* prune the BE if it's no longer in our active list */
			if (widget && widget_in_list(list, widget))
				continue;
		}

Neither of the variables, that are modified in this loop are used outside 
of it. Was the "continue" maybe meant to continue the encompassing loop?

Thanks
Guennadi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] DPCM: suspicious code in dpcm_prune_paths()

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 590 bytes --]

On Tue, Sep 10, 2019 at 11:20:17AM +0200, Guennadi Liakhovetski wrote:

> This code in dpcm_prune_paths() seems to have no effect:

> 		/* is there a valid CODEC DAI widget for this BE */
> 		for_each_rtd_codec_dai(dpcm->be, i, dai) {
> 			widget = dai_get_widget(dai, stream);
> 
> 			/* prune the BE if it's no longer in our active list */
> 			if (widget && widget_in_list(list, widget))
> 				continue;
> 		}

> Neither of the variables, that are modified in this loop are used outside 
> of it. Was the "continue" maybe meant to continue the encompassing loop?

Liam?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel