All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: linux-block@vger.kernel.org, axboe@kernel.dk,
	martin.petersen@oracle.com, linux-nvme@lists.infradead.org,
	keith.busch@intel.com, hch@lst.de, sagi@grimberg.me,
	shlomin@mellanox.com, israelr@mellanox.com
Subject: Re: [PATCH v6 1/2] block: use symbolic constants for t10_pi type
Date: Mon, 16 Sep 2019 09:51:51 +0200	[thread overview]
Message-ID: <20190916075151.GA25796@lst.de> (raw)
In-Reply-To: <1568493253-18142-1-git-send-email-maxg@mellanox.com>

On Sat, Sep 14, 2019 at 11:34:12PM +0300, Max Gurtovoy wrote:
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> Signed-off-by: Max Gurtovoy <maxg@mellanox.com>

A little bit of a changelog would have been nice, but otherwise this
looks fine to me:

Reviewed-by: Christoph Hellwig <hch@lst.de>

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: axboe@kernel.dk, keith.busch@intel.com, sagi@grimberg.me,
	martin.petersen@oracle.com, israelr@mellanox.com,
	linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
	shlomin@mellanox.com, hch@lst.de
Subject: Re: [PATCH v6 1/2] block: use symbolic constants for t10_pi type
Date: Mon, 16 Sep 2019 09:51:51 +0200	[thread overview]
Message-ID: <20190916075151.GA25796@lst.de> (raw)
In-Reply-To: <1568493253-18142-1-git-send-email-maxg@mellanox.com>

On Sat, Sep 14, 2019 at 11:34:12PM +0300, Max Gurtovoy wrote:
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> Signed-off-by: Max Gurtovoy <maxg@mellanox.com>

A little bit of a changelog would have been nice, but otherwise this
looks fine to me:

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  parent reply	other threads:[~2019-09-16  7:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-14 20:34 [PATCH v6 1/2] block: use symbolic constants for t10_pi type Max Gurtovoy
2019-09-14 20:34 ` Max Gurtovoy
2019-09-14 20:34 ` [PATCH 2/2] block: centralize PI remapping logic to the block layer Max Gurtovoy
2019-09-14 20:34   ` Max Gurtovoy
2019-09-16  7:59   ` Christoph Hellwig
2019-09-16  7:59     ` Christoph Hellwig
2019-09-16  7:51 ` Christoph Hellwig [this message]
2019-09-16  7:51   ` [PATCH v6 1/2] block: use symbolic constants for t10_pi type Christoph Hellwig
2019-09-16 14:57   ` Jens Axboe
2019-09-16 14:57     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190916075151.GA25796@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=israelr@mellanox.com \
    --cc=keith.busch@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=martin.petersen@oracle.com \
    --cc=maxg@mellanox.com \
    --cc=sagi@grimberg.me \
    --cc=shlomin@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.