From: Christoph Hellwig <hch@lst.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Max Gurtovoy <maxg@mellanox.com>,
axboe@kernel.dk, keith.busch@intel.com, sagi@grimberg.me,
israelr@mellanox.com, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, shlomin@mellanox.com, hch@lst.de
Subject: Re: [PATCH v4 1/3] block: centralize PI remapping logic to the block layer
Date: Mon, 16 Sep 2019 10:03:28 +0200 [thread overview]
Message-ID: <20190916080328.GB25898@lst.de> (raw)
In-Reply-To: <yq1lfurdejc.fsf@oracle.com>
On Fri, Sep 13, 2019 at 06:20:23PM -0400, Martin K. Petersen wrote:
>
> Max,
>
> > what about broken type 3 in the NVMe spec ?
> >
> > I don't really know what is broken there but maybe we can avoid
> > supporting it for NVMe until it's fixed.
>
> The intent in NVMe was for Type 3 to work exactly like it does in
> SCSI. But the way the spec is worded it does not. So it is unclear
> whether implementors (if any) went with the SCSI compatible route or
> with what the NVMe spec actually says.
Do we actually have Linux users of Type 3 at all? I think for NVMe
we could just trivially disable Linux support, and I suspect for SCSI
as well, but I'll have to defer to you on that.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org, sagi@grimberg.me,
israelr@mellanox.com, linux-nvme@lists.infradead.org,
keith.busch@intel.com, shlomin@mellanox.com,
Max Gurtovoy <maxg@mellanox.com>,
hch@lst.de
Subject: Re: [PATCH v4 1/3] block: centralize PI remapping logic to the block layer
Date: Mon, 16 Sep 2019 10:03:28 +0200 [thread overview]
Message-ID: <20190916080328.GB25898@lst.de> (raw)
In-Reply-To: <yq1lfurdejc.fsf@oracle.com>
On Fri, Sep 13, 2019 at 06:20:23PM -0400, Martin K. Petersen wrote:
>
> Max,
>
> > what about broken type 3 in the NVMe spec ?
> >
> > I don't really know what is broken there but maybe we can avoid
> > supporting it for NVMe until it's fixed.
>
> The intent in NVMe was for Type 3 to work exactly like it does in
> SCSI. But the way the spec is worded it does not. So it is unclear
> whether implementors (if any) went with the SCSI compatible route or
> with what the NVMe spec actually says.
Do we actually have Linux users of Type 3 at all? I think for NVMe
we could just trivially disable Linux support, and I suspect for SCSI
as well, but I'll have to defer to you on that.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-09-16 8:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-08 15:26 [PATCH v4 1/3] block: centralize PI remapping logic to the block layer Max Gurtovoy
2019-09-08 15:26 ` Max Gurtovoy
2019-09-08 15:26 ` [PATCH v4 2/3] block: don't remap ref tag for T10 PI type 0 Max Gurtovoy
2019-09-08 15:26 ` Max Gurtovoy
2019-09-09 2:22 ` Martin K. Petersen
2019-09-09 2:22 ` Martin K. Petersen
2019-09-09 2:36 ` Keith Busch
2019-09-09 2:36 ` Keith Busch
2019-09-09 2:49 ` Martin K. Petersen
2019-09-09 2:49 ` Martin K. Petersen
2019-09-09 13:31 ` Max Gurtovoy
2019-09-09 13:31 ` Max Gurtovoy
2019-09-08 15:26 ` [PATCH v4 3/3] nvme: remove PI values definition from NVMe subsystem Max Gurtovoy
2019-09-08 15:26 ` Max Gurtovoy
2019-09-09 2:21 ` [PATCH v4 1/3] block: centralize PI remapping logic to the block layer Martin K. Petersen
2019-09-09 2:21 ` Martin K. Petersen
2019-09-09 13:55 ` Max Gurtovoy
2019-09-09 13:55 ` Max Gurtovoy
2019-09-10 2:29 ` Martin K. Petersen
2019-09-10 2:29 ` Martin K. Petersen
2019-09-10 22:27 ` Max Gurtovoy
2019-09-10 22:27 ` Max Gurtovoy
2019-09-11 1:16 ` Martin K. Petersen
2019-09-11 1:16 ` Martin K. Petersen
2019-09-11 9:12 ` Max Gurtovoy
2019-09-11 9:12 ` Max Gurtovoy
2019-09-13 22:20 ` Martin K. Petersen
2019-09-13 22:20 ` Martin K. Petersen
2019-09-16 8:03 ` Christoph Hellwig [this message]
2019-09-16 8:03 ` Christoph Hellwig
2019-09-16 17:19 ` Martin K. Petersen
2019-09-16 17:19 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190916080328.GB25898@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=israelr@mellanox.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=shlomin@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.