From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Keith Busch <kbusch@kernel.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Max Gurtovoy <maxg@mellanox.com>,
axboe@kernel.dk, keith.busch@intel.com, sagi@grimberg.me,
israelr@mellanox.com, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, shlomin@mellanox.com, hch@lst.de
Subject: Re: [PATCH v4 2/3] block: don't remap ref tag for T10 PI type 0
Date: Sun, 08 Sep 2019 22:49:00 -0400 [thread overview]
Message-ID: <yq136h6i3qb.fsf@oracle.com> (raw)
In-Reply-To: <20190909023601.GA6772@keith-busch> (Keith Busch's message of "Sun, 8 Sep 2019 20:36:02 -0600")
Keith,
> At least for nvme, type 0 means you have meta data but not for
> protection information,
Yeah, NVMe does not support DIX Type 0.
> so remapping the place the where reference tag exists for other PI
> types corrupts the metadata.
But the device shouldn't have an integrity profile in that case (see
previous mail about why keying off of the protection_type is a problem).
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Keith Busch <kbusch@kernel.org>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org, sagi@grimberg.me,
"Martin K. Petersen" <martin.petersen@oracle.com>,
israelr@mellanox.com, linux-nvme@lists.infradead.org,
keith.busch@intel.com, shlomin@mellanox.com,
Max Gurtovoy <maxg@mellanox.com>,
hch@lst.de
Subject: Re: [PATCH v4 2/3] block: don't remap ref tag for T10 PI type 0
Date: Sun, 08 Sep 2019 22:49:00 -0400 [thread overview]
Message-ID: <yq136h6i3qb.fsf@oracle.com> (raw)
In-Reply-To: <20190909023601.GA6772@keith-busch> (Keith Busch's message of "Sun, 8 Sep 2019 20:36:02 -0600")
Keith,
> At least for nvme, type 0 means you have meta data but not for
> protection information,
Yeah, NVMe does not support DIX Type 0.
> so remapping the place the where reference tag exists for other PI
> types corrupts the metadata.
But the device shouldn't have an integrity profile in that case (see
previous mail about why keying off of the protection_type is a problem).
--
Martin K. Petersen Oracle Linux Engineering
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-09-09 2:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-08 15:26 [PATCH v4 1/3] block: centralize PI remapping logic to the block layer Max Gurtovoy
2019-09-08 15:26 ` Max Gurtovoy
2019-09-08 15:26 ` [PATCH v4 2/3] block: don't remap ref tag for T10 PI type 0 Max Gurtovoy
2019-09-08 15:26 ` Max Gurtovoy
2019-09-09 2:22 ` Martin K. Petersen
2019-09-09 2:22 ` Martin K. Petersen
2019-09-09 2:36 ` Keith Busch
2019-09-09 2:36 ` Keith Busch
2019-09-09 2:49 ` Martin K. Petersen [this message]
2019-09-09 2:49 ` Martin K. Petersen
2019-09-09 13:31 ` Max Gurtovoy
2019-09-09 13:31 ` Max Gurtovoy
2019-09-08 15:26 ` [PATCH v4 3/3] nvme: remove PI values definition from NVMe subsystem Max Gurtovoy
2019-09-08 15:26 ` Max Gurtovoy
2019-09-09 2:21 ` [PATCH v4 1/3] block: centralize PI remapping logic to the block layer Martin K. Petersen
2019-09-09 2:21 ` Martin K. Petersen
2019-09-09 13:55 ` Max Gurtovoy
2019-09-09 13:55 ` Max Gurtovoy
2019-09-10 2:29 ` Martin K. Petersen
2019-09-10 2:29 ` Martin K. Petersen
2019-09-10 22:27 ` Max Gurtovoy
2019-09-10 22:27 ` Max Gurtovoy
2019-09-11 1:16 ` Martin K. Petersen
2019-09-11 1:16 ` Martin K. Petersen
2019-09-11 9:12 ` Max Gurtovoy
2019-09-11 9:12 ` Max Gurtovoy
2019-09-13 22:20 ` Martin K. Petersen
2019-09-13 22:20 ` Martin K. Petersen
2019-09-16 8:03 ` Christoph Hellwig
2019-09-16 8:03 ` Christoph Hellwig
2019-09-16 17:19 ` Martin K. Petersen
2019-09-16 17:19 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq136h6i3qb.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=israelr@mellanox.com \
--cc=kbusch@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=shlomin@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.