From: Sam Ravnborg <sam@ravnborg.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
dri-devel@lists.freedesktop.org, Mark Brown <broonie@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH v3] drm: panel-lvds: Potential Oops in probe error handling
Date: Sat, 21 Sep 2019 18:55:41 +0000 [thread overview]
Message-ID: <20190921185541.GA32133@ravnborg.org> (raw)
In-Reply-To: <20190911104928.GA15930@mwanda>
Hi Dan.
On Wed, Sep 11, 2019 at 01:49:28PM +0300, Dan Carpenter wrote:
> The "lvds->backlight" pointer could be NULL in situations where
> of_parse_phandle() returns NULL. This code is cleaner if we use the
> managed devm_of_find_backlight() so the clean up is automatic.
>
> Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v3: Use devm_of_find_backlight(). This version is quite a bit more
> ambitious, and I haven't tested it so please review carefully.
Looks good.
Applied and pushed to drm-misc-next.
It will hit upstream not at this but next merge window.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
dri-devel@lists.freedesktop.org, Mark Brown <broonie@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH v3] drm: panel-lvds: Potential Oops in probe error handling
Date: Sat, 21 Sep 2019 20:55:41 +0200 [thread overview]
Message-ID: <20190921185541.GA32133@ravnborg.org> (raw)
In-Reply-To: <20190911104928.GA15930@mwanda>
Hi Dan.
On Wed, Sep 11, 2019 at 01:49:28PM +0300, Dan Carpenter wrote:
> The "lvds->backlight" pointer could be NULL in situations where
> of_parse_phandle() returns NULL. This code is cleaner if we use the
> managed devm_of_find_backlight() so the clean up is automatic.
>
> Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v3: Use devm_of_find_backlight(). This version is quite a bit more
> ambitious, and I haven't tested it so please review carefully.
Looks good.
Applied and pushed to drm-misc-next.
It will hit upstream not at this but next merge window.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-09-21 18:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 10:49 [PATCH v3] drm: panel-lvds: Potential Oops in probe error handling Dan Carpenter
2019-09-11 10:49 ` Dan Carpenter
2019-09-21 18:55 ` Sam Ravnborg [this message]
2019-09-21 18:55 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190921185541.GA32133@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.