From: Rob Herring <robh@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-rockchip@lists.infradead.org,
christoph.muellner@theobroma-systems.com,
Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PATCH 09/13] arm64: dts: rockchip: document explicit px30 cru dependencies
Date: Mon, 30 Sep 2019 17:58:11 -0500 [thread overview]
Message-ID: <20190930225811.GA14016@bogus> (raw)
In-Reply-To: <20190917082659.25549-9-heiko@sntech.de>
On Tue, 17 Sep 2019 10:26:55 +0200, Heiko Stuebner wrote:
> The px30 contains 2 separate clock controllers the regular cru creating
> most clocks as well as the pmucru managing the GPLL and some other clocks.
>
> The gpll of course also is needed by the cru, so while we normally do rely
> on clock names to associate clocks getting probed later on (for example
> xin32k coming from an i2c device in most cases) it is safer to declare the
> explicit dependency between the two crus. This makes sure that for example
> the clock-framework probes them in the correct order from the start.
>
> The assigned-clocks properties were simply working by chance in the past
> so split them accordingly to the 2 crus to honor the loading direction.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> .../bindings/clock/rockchip,px30-cru.txt | 5 ++++
> arch/arm64/boot/dts/rockchip/px30.dtsi | 25 +++++++++++--------
> 2 files changed, 20 insertions(+), 10 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
Heiko Stuebner <heiko@sntech.de>,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
christoph.muellner@theobroma-systems.com
Subject: Re: [PATCH 09/13] arm64: dts: rockchip: document explicit px30 cru dependencies
Date: Mon, 30 Sep 2019 17:58:11 -0500 [thread overview]
Message-ID: <20190930225811.GA14016@bogus> (raw)
In-Reply-To: <20190917082659.25549-9-heiko@sntech.de>
On Tue, 17 Sep 2019 10:26:55 +0200, Heiko Stuebner wrote:
> The px30 contains 2 separate clock controllers the regular cru creating
> most clocks as well as the pmucru managing the GPLL and some other clocks.
>
> The gpll of course also is needed by the cru, so while we normally do rely
> on clock names to associate clocks getting probed later on (for example
> xin32k coming from an i2c device in most cases) it is safer to declare the
> explicit dependency between the two crus. This makes sure that for example
> the clock-framework probes them in the correct order from the start.
>
> The assigned-clocks properties were simply working by chance in the past
> so split them accordingly to the 2 crus to honor the loading direction.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> .../bindings/clock/rockchip,px30-cru.txt | 5 ++++
> arch/arm64/boot/dts/rockchip/px30.dtsi | 25 +++++++++++--------
> 2 files changed, 20 insertions(+), 10 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-rockchip@lists.infradead.org,
christoph.muellner@theobroma-systems.com,
Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PATCH 09/13] arm64: dts: rockchip: document explicit px30 cru dependencies
Date: Mon, 30 Sep 2019 17:58:11 -0500 [thread overview]
Message-ID: <20190930225811.GA14016@bogus> (raw)
In-Reply-To: <20190917082659.25549-9-heiko@sntech.de>
On Tue, 17 Sep 2019 10:26:55 +0200, Heiko Stuebner wrote:
> The px30 contains 2 separate clock controllers the regular cru creating
> most clocks as well as the pmucru managing the GPLL and some other clocks.
>
> The gpll of course also is needed by the cru, so while we normally do rely
> on clock names to associate clocks getting probed later on (for example
> xin32k coming from an i2c device in most cases) it is safer to declare the
> explicit dependency between the two crus. This makes sure that for example
> the clock-framework probes them in the correct order from the start.
>
> The assigned-clocks properties were simply working by chance in the past
> so split them accordingly to the 2 crus to honor the loading direction.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> .../bindings/clock/rockchip,px30-cru.txt | 5 ++++
> arch/arm64/boot/dts/rockchip/px30.dtsi | 25 +++++++++++--------
> 2 files changed, 20 insertions(+), 10 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2019-09-30 22:58 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 8:26 [PATCH 01/13] arm64: dts: rockchip: fix iface clock-name on px30 iommus Heiko Stuebner
2019-09-17 8:26 ` Heiko Stuebner
2019-09-17 8:26 ` [PATCH 02/13] arm64: dts: rockchip: remove static xin32k from px30 Heiko Stuebner
2019-09-17 8:26 ` Heiko Stuebner
2019-09-17 8:26 ` Heiko Stuebner
2019-09-17 8:26 ` [PATCH 03/13] arm64: dts: rockchip: remove px30 emmc_pwren pinctrl Heiko Stuebner
2019-09-17 8:26 ` Heiko Stuebner
2019-09-17 8:26 ` [PATCH 04/13] arm64: dts: rockchip: add default px30 emmc pinctrl Heiko Stuebner
2019-09-17 8:26 ` Heiko Stuebner
2019-09-17 8:26 ` [PATCH 05/13] arm64: dts: rockchip: fix the px30-evb power tree Heiko Stuebner
2019-09-17 8:26 ` Heiko Stuebner
2019-09-17 8:26 ` [PATCH 06/13] arm64: dts: rockchip: add emmc-powersequence to px30-evb Heiko Stuebner
2019-09-17 8:26 ` Heiko Stuebner
2019-09-17 8:26 ` [PATCH 07/13] arm64: dts: rockchip: move px30-evb console output to uart 5 Heiko Stuebner
2019-09-17 8:26 ` Heiko Stuebner
2019-09-17 8:26 ` [PATCH 08/13] arm64: dts: rockchip: remove unused pin settings from px30 Heiko Stuebner
2019-09-17 8:26 ` Heiko Stuebner
2019-09-17 8:26 ` [PATCH 09/13] arm64: dts: rockchip: document explicit px30 cru dependencies Heiko Stuebner
2019-09-17 8:26 ` Heiko Stuebner
2019-09-30 22:58 ` Rob Herring [this message]
2019-09-30 22:58 ` Rob Herring
2019-09-30 22:58 ` Rob Herring
2019-09-17 8:26 ` [PATCH 10/13] arm64: dts: rockchip: add px30-evb i2c1 devices Heiko Stuebner
2019-09-17 8:26 ` Heiko Stuebner
2019-09-17 8:26 ` [PATCH 11/13] dt-bindings: document PX30 usb2phy General Register Files Heiko Stuebner
2019-09-17 8:26 ` Heiko Stuebner
2019-09-30 22:58 ` Rob Herring
2019-09-30 22:58 ` Rob Herring
2019-09-30 22:58 ` Rob Herring
2019-09-17 8:26 ` [PATCH 12/13] arm64: dts: rockchip: add usb2phy for px30 Heiko Stuebner
2019-09-17 8:26 ` Heiko Stuebner
2019-09-17 8:26 ` [PATCH 13/13] arm64: dts: rockchip: enable usb2phy on px30-evb Heiko Stuebner
2019-09-17 8:26 ` Heiko Stuebner
2019-10-03 21:25 ` [PATCH 01/13] arm64: dts: rockchip: fix iface clock-name on px30 iommus Heiko Stuebner
2019-10-03 21:25 ` Heiko Stuebner
2019-10-31 14:15 ` Heiko Stuebner
2019-10-31 14:15 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930225811.GA14016@bogus \
--to=robh@kernel.org \
--cc=christoph.muellner@theobroma-systems.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.