[linux-stable-rc:linux-4.19.y 7762/7788] include/linux/spinlock.h:384:9: sparse: sparse: context imbalance in 'flush_end_io' - unexpected unlock

[linux-stable-rc:linux-4.19.y 7762/7788] include/linux/spinlock.h:384:9: sparse: sparse: context imbalance in 'flush_end_io' - unexpected unlock

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1695 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
head:   45830aebf3fc94937285ed325fdb97043f6b6108
commit: 9afbbbbab3cd79e3aa14edd4c6269e89eab79343 [7762/7788] block: fix null pointer dereference in blk_mq_rq_timed_out()
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty
        git checkout 9afbbbbab3cd79e3aa14edd4c6269e89eab79343
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> include/linux/spinlock.h:384:9: sparse: sparse: context imbalance in 'flush_end_io' - unexpected unlock

vim +/flush_end_io +384 include/linux/spinlock.h

c2f21ce2e31286 Thomas Gleixner 2009-12-02  381  
3490565b633c70 Denys Vlasenko  2015-07-13  382  static __always_inline void spin_unlock_irqrestore(spinlock_t *lock, unsigned long flags)
c2f21ce2e31286 Thomas Gleixner 2009-12-02  383  {
c2f21ce2e31286 Thomas Gleixner 2009-12-02 @384  	raw_spin_unlock_irqrestore(&lock->rlock, flags);
c2f21ce2e31286 Thomas Gleixner 2009-12-02  385  }
c2f21ce2e31286 Thomas Gleixner 2009-12-02  386  

:::::: The code at line 384 was first introduced by commit
:::::: c2f21ce2e31286a0a32f8da0a7856e9ca1122ef3 locking: Implement new raw_spinlock

:::::: TO: Thomas Gleixner <tglx@linutronix.de>
:::::: CC: Thomas Gleixner <tglx@linutronix.de>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Re: [linux-stable-rc:linux-4.19.y 7762/7788] include/linux/spinlock.h:384:9: sparse: sparse: context imbalance in 'flush_end_io' - unexpected unlock

[Greg Kroah-Hartman]

[-- Attachment #1: Type: text/plain, Size: 1671 bytes --]

On Thu, Oct 03, 2019 at 08:33:38PM -0600, Jens Axboe wrote:
> On 10/3/19 8:20 PM, kbuild test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> > head:   45830aebf3fc94937285ed325fdb97043f6b6108
> > commit: 9afbbbbab3cd79e3aa14edd4c6269e89eab79343 [7762/7788] block: fix null pointer dereference in blk_mq_rq_timed_out()
> > reproduce:
> >          # apt-get install sparse
> >          # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty
> >          git checkout 9afbbbbab3cd79e3aa14edd4c6269e89eab79343
> >          make ARCH=x86_64 allmodconfig
> >          make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> > 
> > If you fix the issue, kindly add following tag
> > Reported-by: kbuild test robot <lkp@intel.com>
> > 
> > 
> > sparse warnings: (new ones prefixed by >>)
> > 
> >>> include/linux/spinlock.h:384:9: sparse: sparse: context imbalance in 'flush_end_io' - unexpected unlock
> > 
> > vim +/flush_end_io +384 include/linux/spinlock.h
> > 
> > c2f21ce2e31286 Thomas Gleixner 2009-12-02  381
> > 3490565b633c70 Denys Vlasenko  2015-07-13  382  static __always_inline void spin_unlock_irqrestore(spinlock_t *lock, unsigned long flags)
> > c2f21ce2e31286 Thomas Gleixner 2009-12-02  383  {
> > c2f21ce2e31286 Thomas Gleixner 2009-12-02 @384  	raw_spin_unlock_irqrestore(&lock->rlock, flags);
> > c2f21ce2e31286 Thomas Gleixner 2009-12-02  385  }
> > c2f21ce2e31286 Thomas Gleixner 2009-12-02  386
> 
> This report looks bogus - both for mainline, and I checked that the 4.19
> backport is correct too.

Thanks for testing and verifying that this is sane.

greg k-h

Re: [linux-stable-rc:linux-4.19.y 7762/7788] include/linux/spinlock.h:384:9: sparse: sparse: context imbalance in 'flush_end_io' - unexpected unlock

[Rong Chen]

[-- Attachment #1: Type: text/plain, Size: 1657 bytes --]



On 10/4/19 10:33 AM, Jens Axboe wrote:
> On 10/3/19 8:20 PM, kbuild test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
>> head:   45830aebf3fc94937285ed325fdb97043f6b6108
>> commit: 9afbbbbab3cd79e3aa14edd4c6269e89eab79343 [7762/7788] block: fix null pointer dereference in blk_mq_rq_timed_out()
>> reproduce:
>>           # apt-get install sparse
>>           # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty
>>           git checkout 9afbbbbab3cd79e3aa14edd4c6269e89eab79343
>>           make ARCH=x86_64 allmodconfig
>>           make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
>>
>> If you fix the issue, kindly add following tag
>> Reported-by: kbuild test robot <lkp@intel.com>
>>
>>
>> sparse warnings: (new ones prefixed by >>)
>>
>>>> include/linux/spinlock.h:384:9: sparse: sparse: context imbalance in 'flush_end_io' - unexpected unlock
>> vim +/flush_end_io +384 include/linux/spinlock.h
>>
>> c2f21ce2e31286 Thomas Gleixner 2009-12-02  381
>> 3490565b633c70 Denys Vlasenko  2015-07-13  382  static __always_inline void spin_unlock_irqrestore(spinlock_t *lock, unsigned long flags)
>> c2f21ce2e31286 Thomas Gleixner 2009-12-02  383  {
>> c2f21ce2e31286 Thomas Gleixner 2009-12-02 @384  	raw_spin_unlock_irqrestore(&lock->rlock, flags);
>> c2f21ce2e31286 Thomas Gleixner 2009-12-02  385  }
>> c2f21ce2e31286 Thomas Gleixner 2009-12-02  386
> This report looks bogus - both for mainline, and I checked that the 4.19
> backport is correct too.
>

Sorry for the inconvenience. It's a false positive. we'll fix it asap.

Best Regards,
Rong Chen