* Re: [PATCH 2/6] dt-bindings: Input: edt-ft5x06 - add disable wakeup-source documentation
2019-10-02 13:00 ` Marco Felsch
@ 2019-10-02 14:48 ` Maxime Ripard
2019-10-02 15:20 ` Benoit Parrot
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Maxime Ripard @ 2019-10-02 14:48 UTC (permalink / raw)
To: Marco Felsch
Cc: Rob Herring, Dmitry Torokhov, andriy.shevchenko, bparrot,
andy.shevchenko, simon.budig, hdegoede, fcooper, linux-input,
devicetree, kernel, bcousson, tony, nicolas.ferre,
alexandre.belloni, ludovic.desroches, s.hauer, festevam,
linux-imx, shawnguo, wens
[-- Attachment #1: Type: text/plain, Size: 540 bytes --]
On Wed, Oct 02, 2019 at 03:00:18PM +0200, Marco Felsch wrote:
> all of you using a edt,* touchscreen and currently the driver marks
> the touchscreen as wakeup source. To keep backward compatibility I added
> a workaround binding (see below) but Dmitry prefer to use the normal
> "wakeup-source" binding and change the affected device-tree's
> (discussion below). Can you give me your ack/nack for Dmitry's solution?
we don't have any upstrem suspend support on the Allwinner SoCs, so
you can safely ignore all the sunxi DTS here.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 2/6] dt-bindings: Input: edt-ft5x06 - add disable wakeup-source documentation
2019-10-02 13:00 ` Marco Felsch
2019-10-02 14:48 ` Maxime Ripard
@ 2019-10-02 15:20 ` Benoit Parrot
2019-10-02 17:30 ` Dmitry Torokhov
2019-10-02 15:24 ` Alexandre Belloni
2019-10-14 9:14 ` Shawn Guo
3 siblings, 1 reply; 8+ messages in thread
From: Benoit Parrot @ 2019-10-02 15:20 UTC (permalink / raw)
To: Marco Felsch
Cc: Rob Herring, Dmitry Torokhov, andriy.shevchenko, andy.shevchenko,
simon.budig, hdegoede, fcooper, linux-input, devicetree, kernel,
bcousson, tony, nicolas.ferre, alexandre.belloni,
ludovic.desroches, s.hauer, festevam, linux-imx, shawnguo,
mripard, wens
Marco Felsch <m.felsch@pengutronix.de> wrote on Wed [2019-Oct-02 15:00:18 +0200]:
> Hi,
>
> all of you using a edt,* touchscreen and currently the driver marks
> the touchscreen as wakeup source. To keep backward compatibility I added
> a workaround binding (see below) but Dmitry prefer to use the normal
> "wakeup-source" binding and change the affected device-tree's
> (discussion below). Can you give me your ack/nack for Dmitry's solution?
So, if I understand this correctly, currently the driver always assume it
is a wakeup source regardless if the "wakeup-source" DT property being
present or not. And the proposed change now is to fix the driver so that it
will assume a wakeup source role only if the DT property is present?
If that is the case then ACK from my side for the AM43x devices.
Regards,
Benoit
>
> Regards,
> Marco
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/6] dt-bindings: Input: edt-ft5x06 - add disable wakeup-source documentation
2019-10-02 15:20 ` Benoit Parrot
@ 2019-10-02 17:30 ` Dmitry Torokhov
0 siblings, 0 replies; 8+ messages in thread
From: Dmitry Torokhov @ 2019-10-02 17:30 UTC (permalink / raw)
To: Benoit Parrot
Cc: Marco Felsch, Rob Herring, andriy.shevchenko, andy.shevchenko,
simon.budig, hdegoede, fcooper, linux-input, devicetree, kernel,
bcousson, tony, nicolas.ferre, alexandre.belloni,
ludovic.desroches, s.hauer, festevam, linux-imx, shawnguo,
mripard, wens
On Wed, Oct 02, 2019 at 10:20:03AM -0500, Benoit Parrot wrote:
> Marco Felsch <m.felsch@pengutronix.de> wrote on Wed [2019-Oct-02 15:00:18 +0200]:
> > Hi,
> >
> > all of you using a edt,* touchscreen and currently the driver marks
> > the touchscreen as wakeup source. To keep backward compatibility I added
> > a workaround binding (see below) but Dmitry prefer to use the normal
> > "wakeup-source" binding and change the affected device-tree's
> > (discussion below). Can you give me your ack/nack for Dmitry's solution?
>
> So, if I understand this correctly, currently the driver always assume it
> is a wakeup source regardless if the "wakeup-source" DT property being
> present or not. And the proposed change now is to fix the driver so that it
> will assume a wakeup source role only if the DT property is present?
Yes, that is correct.
>
> If that is the case then ACK from my side for the AM43x devices.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/6] dt-bindings: Input: edt-ft5x06 - add disable wakeup-source documentation
2019-10-02 13:00 ` Marco Felsch
2019-10-02 14:48 ` Maxime Ripard
2019-10-02 15:20 ` Benoit Parrot
@ 2019-10-02 15:24 ` Alexandre Belloni
2019-10-14 9:14 ` Shawn Guo
3 siblings, 0 replies; 8+ messages in thread
From: Alexandre Belloni @ 2019-10-02 15:24 UTC (permalink / raw)
To: Marco Felsch
Cc: Rob Herring, Dmitry Torokhov, andriy.shevchenko, bparrot,
andy.shevchenko, simon.budig, hdegoede, fcooper, linux-input,
devicetree, kernel, bcousson, tony, nicolas.ferre,
ludovic.desroches, s.hauer, festevam, linux-imx, shawnguo,
mripard, wens
On 02/10/2019 15:00:18+0200, Marco Felsch wrote:
> Hi,
>
> all of you using a edt,* touchscreen and currently the driver marks
> the touchscreen as wakeup source. To keep backward compatibility I added
> a workaround binding (see below) but Dmitry prefer to use the normal
> "wakeup-source" binding and change the affected device-tree's
> (discussion below). Can you give me your ack/nack for Dmitry's solution?
>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Regards,
> Marco
>
> On 19-09-30 18:11, Rob Herring wrote:
> > On Tue, Sep 17, 2019 at 10:26:58AM -0700, Dmitry Torokhov wrote:
> > > On Tue, Sep 17, 2019 at 07:18:14PM +0200, Marco Felsch wrote:
> > > > Hi Dmitry,
> > > >
> > > > On 19-09-17 10:07, Dmitry Torokhov wrote:
> > > > > On Tue, Sep 17, 2019 at 05:58:04PM +0200, Marco Felsch wrote:
> > > > > > The default driver behaviour is to enable the wakeup-source everytime.
> > > > > > There are hardware designs which have a dedicated gpio to act as wakeup
> > > > > > device. So it must be allowed to disable the wakeup-source capability.
> > > > > >
> > > > > > This patch adds the binding documentation to disable the wakeup-source
> > > > > > capability.
> > > > > >
> > > > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > > > > > ---
> > > > > > .../devicetree/bindings/input/touchscreen/edt-ft5x06.txt | 4 ++++
> > > > > > 1 file changed, 4 insertions(+)
> > > > > >
> > > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt
> > > > > > index 870b8c5cce9b..4d6524fe3cf4 100644
> > > > > > --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt
> > > > > > +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt
> > > > > > @@ -35,6 +35,10 @@ Optional properties:
> > > > > > - pinctrl-0: a phandle pointing to the pin settings for the
> > > > > > control gpios
> > > > > >
> > > > > > + - edt,disable-wakeup-source: If left the device will act as wakeup-source
> > > > > > + (for legacy compatibility). Add the property
> > > > > > + so the device won't act as wakeup-source.
> > > > >
> > > > > I think this is too ugly and I consider it being a bug in the driver
> > > > > that it enables wakeup unconditionally.
> > > >
> > > > That's right.
> > > >
> > > > > Let's just update DTS in tree for devices that actually want it (I am
> > > > > curious how many that do not declare "wakeup-source" have it working and
> > > > > actually want it) and key the dirver behavior off the standard property.
> > > >
> > > > There are a few DTS using this driver and the current driver behaviour.
> > > > We need to keep the backward compatibility since the DTB is part of the
> > > > firmware and firmware isn't always included during a system-update. I
> > > > know its ugly but IMHO that's the right way to go to keep the backward
> > > > compatibility. Let us see what the DT-folk says.
> > > >
> > > > > Until we start seeing this controller in devices that actually have DTS
> > > > > in hardware device tree I think it is better to use standard property.
> > > >
> > > > Sorry, I didn't get you here..
> > >
> > > What I was trying to say is that I have not actually seen DTB that is
> > > part of hardware or separately upgradable frimware (not talking about
> > > ppc or sparc boxes, but ones that might be using this driver). It is
> > > always built into the kernel in my experience, so backward compatibility
> > > is simply a tool that is being used to prevent us from being too wild
> > > with hacking on bindings, but rarely a practical concern.
> >
> > Well, that's self fulfilling...
> >
> > > In cases like this I think it is worthwhile to simply update in-tree
> > > DTS and arrive at a sane binding.
> >
> > Get the maintainers of the affected platforms to agree to the changes.
> >
> > Rob
> >
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/6] dt-bindings: Input: edt-ft5x06 - add disable wakeup-source documentation
2019-10-02 13:00 ` Marco Felsch
` (2 preceding siblings ...)
2019-10-02 15:24 ` Alexandre Belloni
@ 2019-10-14 9:14 ` Shawn Guo
3 siblings, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2019-10-14 9:14 UTC (permalink / raw)
To: Marco Felsch
Cc: Rob Herring, Dmitry Torokhov, andriy.shevchenko, bparrot,
andy.shevchenko, simon.budig, hdegoede, fcooper, linux-input,
devicetree, kernel, bcousson, tony, nicolas.ferre,
alexandre.belloni, ludovic.desroches, s.hauer, festevam,
linux-imx, mripard, wens
On Wed, Oct 02, 2019 at 03:00:18PM +0200, Marco Felsch wrote:
> Hi,
>
> all of you using a edt,* touchscreen and currently the driver marks
> the touchscreen as wakeup source. To keep backward compatibility I added
> a workaround binding (see below) but Dmitry prefer to use the normal
> "wakeup-source" binding and change the affected device-tree's
> (discussion below). Can you give me your ack/nack for Dmitry's solution?
Acked-by: Shawn Guo <shawnguo@kernel.org>
>
> Regards,
> Marco
>
> On 19-09-30 18:11, Rob Herring wrote:
> > On Tue, Sep 17, 2019 at 10:26:58AM -0700, Dmitry Torokhov wrote:
> > > On Tue, Sep 17, 2019 at 07:18:14PM +0200, Marco Felsch wrote:
> > > > Hi Dmitry,
> > > >
> > > > On 19-09-17 10:07, Dmitry Torokhov wrote:
> > > > > On Tue, Sep 17, 2019 at 05:58:04PM +0200, Marco Felsch wrote:
> > > > > > The default driver behaviour is to enable the wakeup-source everytime.
> > > > > > There are hardware designs which have a dedicated gpio to act as wakeup
> > > > > > device. So it must be allowed to disable the wakeup-source capability.
> > > > > >
> > > > > > This patch adds the binding documentation to disable the wakeup-source
> > > > > > capability.
> > > > > >
> > > > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > > > > > ---
> > > > > > .../devicetree/bindings/input/touchscreen/edt-ft5x06.txt | 4 ++++
> > > > > > 1 file changed, 4 insertions(+)
> > > > > >
> > > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt
> > > > > > index 870b8c5cce9b..4d6524fe3cf4 100644
> > > > > > --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt
> > > > > > +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt
> > > > > > @@ -35,6 +35,10 @@ Optional properties:
> > > > > > - pinctrl-0: a phandle pointing to the pin settings for the
> > > > > > control gpios
> > > > > >
> > > > > > + - edt,disable-wakeup-source: If left the device will act as wakeup-source
> > > > > > + (for legacy compatibility). Add the property
> > > > > > + so the device won't act as wakeup-source.
> > > > >
> > > > > I think this is too ugly and I consider it being a bug in the driver
> > > > > that it enables wakeup unconditionally.
> > > >
> > > > That's right.
> > > >
> > > > > Let's just update DTS in tree for devices that actually want it (I am
> > > > > curious how many that do not declare "wakeup-source" have it working and
> > > > > actually want it) and key the dirver behavior off the standard property.
> > > >
> > > > There are a few DTS using this driver and the current driver behaviour.
> > > > We need to keep the backward compatibility since the DTB is part of the
> > > > firmware and firmware isn't always included during a system-update. I
> > > > know its ugly but IMHO that's the right way to go to keep the backward
> > > > compatibility. Let us see what the DT-folk says.
> > > >
> > > > > Until we start seeing this controller in devices that actually have DTS
> > > > > in hardware device tree I think it is better to use standard property.
> > > >
> > > > Sorry, I didn't get you here..
> > >
> > > What I was trying to say is that I have not actually seen DTB that is
> > > part of hardware or separately upgradable frimware (not talking about
> > > ppc or sparc boxes, but ones that might be using this driver). It is
> > > always built into the kernel in my experience, so backward compatibility
> > > is simply a tool that is being used to prevent us from being too wild
> > > with hacking on bindings, but rarely a practical concern.
> >
> > Well, that's self fulfilling...
> >
> > > In cases like this I think it is worthwhile to simply update in-tree
> > > DTS and arrive at a sane binding.
> >
> > Get the maintainers of the affected platforms to agree to the changes.
> >
> > Rob
> >
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 8+ messages in thread