From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Nicolas Palix <nicolas.palix@imag.fr>,
Michal Marek <michal.lkml@markovi.net>,
Arnd Bergmann <arnd@arndb.de>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Marc Zyngier <maz@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] [PATCH] coccinelle: api/devm_platform_ioremap_resource: remove useless script
Date: Sat, 19 Oct 2019 14:09:41 +0200 [thread overview]
Message-ID: <20191019120941.GL3125@piout.net> (raw)
In-Reply-To: <81269cd6-e26d-b8aa-cf17-3a2285851564@web.de>
On 19/10/2019 11:00:47+0200, Markus Elfring wrote:
> > While it is useful for new drivers to use devm_platform_ioremap_resource,
>
> This is nice.
>
>
> > this script is currently used to spam maintainers,
>
> This view is unfortunate.
>
> Do we stumble on a target conflict again?
>
>
> > often updating very old drivers.
>
> This can also happen.
>
>
> > The net benefit is the removal of 2 lines of code in the driver
>
> Additional effects can be reconsidered, can't they?
>
What are the additional effects? What is the end goal of converting all
the existing drivers to devm_platform_ioremap_resource? The existing
code is currently always correct and it is difficult to see how this
would lead to any bug avoidance in the long term.
> > but the review load for the maintainers is huge.
>
> Does collateral evolution trigger a remarkable amount of changes occasionally?
>
This is not an evolution, it is unnecessary churn. Those patches have no
benefit and eat up very valuable reviewer time.
>
> How will such feedback influence the development and integration of
> further scripts for the semantic patch language (Coccinelle software)?
>
There are a few other scripts that have no added value when applied to
existing code, like ptr_ret.cocci.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Nicolas Palix <nicolas.palix@imag.fr>,
Michal Marek <michal.lkml@markovi.net>,
Arnd Bergmann <arnd@arndb.de>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Marc Zyngier <maz@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [PATCH] coccinelle: api/devm_platform_ioremap_resource: remove useless script
Date: Sat, 19 Oct 2019 12:09:41 +0000 [thread overview]
Message-ID: <20191019120941.GL3125@piout.net> (raw)
In-Reply-To: <81269cd6-e26d-b8aa-cf17-3a2285851564@web.de>
On 19/10/2019 11:00:47+0200, Markus Elfring wrote:
> > While it is useful for new drivers to use devm_platform_ioremap_resource,
>
> This is nice.
>
>
> > this script is currently used to spam maintainers,
>
> This view is unfortunate.
>
> Do we stumble on a target conflict again?
>
>
> > often updating very old drivers.
>
> This can also happen.
>
>
> > The net benefit is the removal of 2 lines of code in the driver
>
> Additional effects can be reconsidered, can't they?
>
What are the additional effects? What is the end goal of converting all
the existing drivers to devm_platform_ioremap_resource? The existing
code is currently always correct and it is difficult to see how this
would lead to any bug avoidance in the long term.
> > but the review load for the maintainers is huge.
>
> Does collateral evolution trigger a remarkable amount of changes occasionally?
>
This is not an evolution, it is unnecessary churn. Those patches have no
benefit and eat up very valuable reviewer time.
>
> How will such feedback influence the development and integration of
> further scripts for the semantic patch language (Coccinelle software)?
>
There are a few other scripts that have no added value when applied to
existing code, like ptr_ret.cocci.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>,
Himanshu Jha <himanshujha199640@gmail.com>,
kernel-janitors@vger.kernel.org,
Coccinelle <cocci@systeme.lip6.fr>, Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Linus Torvalds <torvalds@linuxfoundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>
Subject: Re: [PATCH] coccinelle: api/devm_platform_ioremap_resource: remove useless script
Date: Sat, 19 Oct 2019 14:09:41 +0200 [thread overview]
Message-ID: <20191019120941.GL3125@piout.net> (raw)
In-Reply-To: <81269cd6-e26d-b8aa-cf17-3a2285851564@web.de>
On 19/10/2019 11:00:47+0200, Markus Elfring wrote:
> > While it is useful for new drivers to use devm_platform_ioremap_resource,
>
> This is nice.
>
>
> > this script is currently used to spam maintainers,
>
> This view is unfortunate.
>
> Do we stumble on a target conflict again?
>
>
> > often updating very old drivers.
>
> This can also happen.
>
>
> > The net benefit is the removal of 2 lines of code in the driver
>
> Additional effects can be reconsidered, can't they?
>
What are the additional effects? What is the end goal of converting all
the existing drivers to devm_platform_ioremap_resource? The existing
code is currently always correct and it is difficult to see how this
would lead to any bug avoidance in the long term.
> > but the review load for the maintainers is huge.
>
> Does collateral evolution trigger a remarkable amount of changes occasionally?
>
This is not an evolution, it is unnecessary churn. Those patches have no
benefit and eat up very valuable reviewer time.
>
> How will such feedback influence the development and integration of
> further scripts for the semantic patch language (Coccinelle software)?
>
There are a few other scripts that have no added value when applied to
existing code, like ptr_ret.cocci.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-10-20 5:44 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 14:22 [PATCH] coccinelle: api/devm_platform_ioremap_resource: remove useless script Alexandre Belloni
2019-10-17 14:22 ` Alexandre Belloni
2019-10-17 14:34 ` Julia Lawall
2019-10-17 14:34 ` Julia Lawall
2019-10-17 16:13 ` [PATCH] coccinelle: api/devm_platform_ioremap =?UTF-8?Q?=5Fresource=3A=20remove Marc Zyngier
2019-10-17 16:13 ` [PATCH] coccinelle: api/devm_platform_ioremap_resource: remove useless script Marc Zyngier
2019-10-19 11:35 ` [Cocci] " Markus Elfring
2019-10-19 11:35 ` Markus Elfring
2019-10-19 11:35 ` Markus Elfring
2019-10-19 20:43 ` [Cocci] " Marc Zyngier
2019-10-19 20:43 ` Marc Zyngier
2019-10-19 20:43 ` Marc Zyngier
2019-10-19 22:13 ` [Cocci] " Joe Perches
2019-10-19 22:13 ` Joe Perches
2019-10-19 22:13 ` Joe Perches
2019-10-24 15:40 ` [Cocci] " Masahiro Yamada
2019-10-24 15:40 ` Masahiro Yamada
2019-10-24 15:40 ` Masahiro Yamada
2019-10-24 18:30 ` [Cocci] " Markus Elfring
2019-10-24 18:30 ` Markus Elfring
2019-10-24 18:30 ` Markus Elfring
2019-10-25 8:08 ` [Cocci] " Andy Shevchenko
2019-10-25 8:08 ` Andy Shevchenko
2019-10-25 8:08 ` Andy Shevchenko
2019-10-25 8:38 ` [Cocci] " Julia Lawall
2019-10-25 8:38 ` Julia Lawall
2019-10-25 8:38 ` Julia Lawall
2019-10-29 2:58 ` [Cocci] " Masahiro Yamada
2019-10-29 2:58 ` Masahiro Yamada
2019-10-29 2:58 ` Masahiro Yamada
2019-10-29 8:55 ` [Cocci] " Julia Lawall
2019-10-29 8:55 ` Julia Lawall
2019-10-29 8:55 ` Julia Lawall
2019-10-20 5:38 ` [Cocci] " Julia Lawall
2019-10-20 5:38 ` Julia Lawall
2019-10-20 5:38 ` Julia Lawall
2019-10-20 9:34 ` [Cocci] " Marc Zyngier
2019-10-20 9:34 ` Marc Zyngier
2019-10-20 9:34 ` Marc Zyngier
2019-10-20 5:45 ` [Cocci] " Markus Elfring
2019-10-20 5:45 ` Markus Elfring
2019-10-20 5:45 ` Markus Elfring
2019-10-19 9:00 ` [Cocci] [PATCH] " Markus Elfring
2019-10-19 9:00 ` Markus Elfring
2019-10-19 9:00 ` Markus Elfring
2019-10-19 12:09 ` Alexandre Belloni [this message]
2019-10-19 12:09 ` Alexandre Belloni
2019-10-19 12:09 ` Alexandre Belloni
2019-10-19 14:06 ` [Cocci] " Markus Elfring
2019-10-19 14:06 ` Markus Elfring
2019-10-19 14:06 ` Markus Elfring
2019-10-19 14:29 ` [Cocci] [PATCH] " Bartosz Golaszewski
2019-10-19 14:29 ` Bartosz Golaszewski
2019-10-19 14:29 ` Bartosz Golaszewski
2019-10-19 16:36 ` [Cocci] " Markus Elfring
2019-10-19 16:36 ` Markus Elfring
2019-10-19 16:36 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191019120941.GL3125@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=Markus.Elfring@web.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=cocci@systeme.lip6.fr \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=tglx@linutronix.de \
--cc=torvalds@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.