From: Lee Jones <lee.jones@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Barry Song <baohua@kernel.org>, James Cameron <quozl@laptop.org>,
stephan@gerhold.net, Linus Walleij <linus.walleij@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lubomir Rintel <lkundrak@v3.sk>, Mark Brown <broonie@kernel.org>,
Daniel Drake <drake@endlessm.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 0/9] Simplify MFD Core
Date: Mon, 21 Oct 2019 12:39:57 +0100 [thread overview]
Message-ID: <20191021113957.GC4365@dell> (raw)
In-Reply-To: <CAK8P3a10w9Xg6U8EgUqPLbucP3A0wc9xO_WNG06LxHrsZkZc1g@mail.gmail.com>
On Mon, 21 Oct 2019, Arnd Bergmann wrote:
> On Mon, Oct 21, 2019 at 12:58 PM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > MFD currently has one over-complicated user. CS5535 uses a mixture of
> > cell cloning, reference counting and subsystem-level call-backs to
> > achieve its goal of requesting an IO memory region only once across 3
> > consumers. The same can be achieved by handling the region centrally
> > during the parent device's .probe() sequence. Releasing can be handed
> > in a similar way during .remove().
> >
> > While we're here, take the opportunity to provide some clean-ups and
> > error checking to issues noticed along the way.
> >
> > This also paves the way for clean cell disabling via Device Tree being
> > discussed at [0]
> >
> > [0] https://lkml.org/lkml/2019/10/18/612.
>
> As the CS5535 is primarily used on the OLPC XO1, it would be
> good to have someone test the series on such a machine.
>
> I've added a few people to Cc that may be able to help test it, or
> know someone who can.
Wonderful. Thank you.
> For the actual patches, see
> https://lore.kernel.org/lkml/20191021105822.20271-1-lee.jones@linaro.org/T/#t
>
> Arnd
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
Mark Brown <broonie@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Barry Song <baohua@kernel.org>,
stephan@gerhold.net,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Daniel Drake <drake@endlessm.com>,
Lubomir Rintel <lkundrak@v3.sk>, James Cameron <quozl@laptop.org>
Subject: Re: [PATCH v2 0/9] Simplify MFD Core
Date: Mon, 21 Oct 2019 12:39:57 +0100 [thread overview]
Message-ID: <20191021113957.GC4365@dell> (raw)
In-Reply-To: <CAK8P3a10w9Xg6U8EgUqPLbucP3A0wc9xO_WNG06LxHrsZkZc1g@mail.gmail.com>
On Mon, 21 Oct 2019, Arnd Bergmann wrote:
> On Mon, Oct 21, 2019 at 12:58 PM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > MFD currently has one over-complicated user. CS5535 uses a mixture of
> > cell cloning, reference counting and subsystem-level call-backs to
> > achieve its goal of requesting an IO memory region only once across 3
> > consumers. The same can be achieved by handling the region centrally
> > during the parent device's .probe() sequence. Releasing can be handed
> > in a similar way during .remove().
> >
> > While we're here, take the opportunity to provide some clean-ups and
> > error checking to issues noticed along the way.
> >
> > This also paves the way for clean cell disabling via Device Tree being
> > discussed at [0]
> >
> > [0] https://lkml.org/lkml/2019/10/18/612.
>
> As the CS5535 is primarily used on the OLPC XO1, it would be
> good to have someone test the series on such a machine.
>
> I've added a few people to Cc that may be able to help test it, or
> know someone who can.
Wonderful. Thank you.
> For the actual patches, see
> https://lore.kernel.org/lkml/20191021105822.20271-1-lee.jones@linaro.org/T/#t
>
> Arnd
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-10-21 11:40 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 10:58 [PATCH v2 0/9] Simplify MFD Core Lee Jones
2019-10-21 10:58 ` Lee Jones
2019-10-21 10:58 ` [PATCH v2 1/9] mfd: cs5535-mfd: Use PLATFORM_DEVID_* defines and tidy error message Lee Jones
2019-10-21 10:58 ` Lee Jones
2019-10-21 11:15 ` Daniel Thompson
2019-10-21 11:15 ` Daniel Thompson
2019-10-21 11:33 ` Lee Jones
2019-10-21 11:33 ` Lee Jones
2019-10-21 11:35 ` Lee Jones
2019-10-21 11:35 ` Lee Jones
2019-10-21 10:58 ` [PATCH v2 2/9] mfd: cs5535-mfd: Remove mfd_cell->id hack Lee Jones
2019-10-21 10:58 ` Lee Jones
2019-10-21 11:11 ` Daniel Thompson
2019-10-21 11:11 ` Daniel Thompson
2019-10-21 11:46 ` Lee Jones
2019-10-21 11:46 ` Lee Jones
2019-10-21 10:58 ` [PATCH v2 3/9] mfd: cs5535-mfd: Request shared IO regions centrally Lee Jones
2019-10-21 10:58 ` Lee Jones
2019-10-21 12:26 ` Daniel Thompson
2019-10-21 12:26 ` Daniel Thompson
2019-10-21 12:46 ` Lee Jones
2019-10-21 12:46 ` Lee Jones
2019-10-21 10:58 ` [PATCH v2 4/9] mfd: cs5535-mfd: Register clients using their own dedicated MFD cell entries Lee Jones
2019-10-21 10:58 ` Lee Jones
2019-10-21 12:29 ` Daniel Thompson
2019-10-21 12:29 ` Daniel Thompson
2019-10-21 13:21 ` Lee Jones
2019-10-21 13:21 ` Lee Jones
2019-10-21 10:58 ` [PATCH v2 5/9] mfd: mfd-core: Remove mfd_clone_cell() Lee Jones
2019-10-21 10:58 ` Lee Jones
2019-10-21 12:29 ` Daniel Thompson
2019-10-21 12:29 ` Daniel Thompson
2019-10-21 10:58 ` [PATCH v2 6/9] x86: olpc: Remove invocation of MFD's .enable()/.disable() call-backs Lee Jones
2019-10-21 10:58 ` Lee Jones
2019-10-21 12:17 ` Daniel Thompson
2019-10-21 12:17 ` Daniel Thompson
2019-10-21 10:58 ` [PATCH v2 7/9] mfd: mfd-core: Protect against NULL call-back function pointer Lee Jones
2019-10-21 10:58 ` Lee Jones
2019-10-21 12:30 ` Daniel Thompson
2019-10-21 12:30 ` Daniel Thompson
2019-10-21 12:32 ` Daniel Thompson
2019-10-21 12:32 ` Daniel Thompson
2019-10-21 12:40 ` Lee Jones
2019-10-21 12:40 ` Lee Jones
2019-10-21 10:58 ` [PATCH v2 8/9] mfd: mfd-core: Remove usage counting for .{en, dis}able() call-backs Lee Jones
2019-10-21 10:58 ` [PATCH v2 8/9] mfd: mfd-core: Remove usage counting for .{en,dis}able() call-backs Lee Jones
2019-10-21 12:33 ` Daniel Thompson
2019-10-21 12:33 ` Daniel Thompson
2019-10-21 10:58 ` [PATCH v2 9/9] mfd: mfd-core: Move pdev->mfd_cell creation back into mfd_add_device() Lee Jones
2019-10-21 10:58 ` Lee Jones
2019-10-21 12:45 ` Daniel Thompson
2019-10-21 12:45 ` Daniel Thompson
2019-10-21 11:29 ` [PATCH v2 0/9] Simplify MFD Core Arnd Bergmann
2019-10-21 11:29 ` Arnd Bergmann
2019-10-21 11:39 ` Lee Jones [this message]
2019-10-21 11:39 ` Lee Jones
2019-10-21 11:44 ` Lubomir Rintel
2019-10-21 11:44 ` Lubomir Rintel
2019-10-21 11:53 ` Lee Jones
2019-10-21 11:53 ` Lee Jones
2019-10-21 12:21 ` Lubomir Rintel
2019-10-21 12:21 ` Lubomir Rintel
2019-10-21 13:01 ` Lee Jones
2019-10-21 13:01 ` Lee Jones
2019-11-01 9:07 ` Lee Jones
2019-11-01 9:07 ` Lee Jones
2019-11-01 15:01 ` Lubomir Rintel
2019-11-01 15:01 ` Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021113957.GC4365@dell \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=baohua@kernel.org \
--cc=broonie@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=drake@endlessm.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=quozl@laptop.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.