All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/display/psr: Print in debugfs if PSR is not enabled because of sink
@ 2019-10-23 21:49 ` José Roberto de Souza
  0 siblings, 0 replies; 10+ messages in thread
From: José Roberto de Souza @ 2019-10-23 21:49 UTC (permalink / raw)
  To: intel-gfx; +Cc: Ap Kamal, Dhinakaran Pandiyan

Right now if sink reported any PSR error or if it fails to
acknowledge the PSR wakeup it sets a flag and do not attempt to
enable PSR anymore. That is the safest approach to avoid repetitive
glitches and allowed us to have PSR enabled by default.

But from time to time even good PSR panels have a PSR error, causing
tests to fail. And for now we are not yet to the point were we could
try to recover from PSR errors, so lets add this information to the
debugfs so IGT can check if PSR is disabled because of sink errors or
not and eliminate this noise from CI runs.

Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Ap Kamal <kamal.ap@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/i915_debugfs.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index bc0bdf0419e0..07e368ec4fb8 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -2194,8 +2194,12 @@ static int i915_edp_psr_status(struct seq_file *m, void *data)
 		status = "disabled";
 	seq_printf(m, "PSR mode: %s\n", status);
 
-	if (!psr->enabled)
+	if (!psr->enabled) {
+		seq_printf(m, "PSR sink not reliable: %s\n",
+			   yesno(psr->sink_not_reliable));
+
 		goto unlock;
+	}
 
 	if (psr->psr2_enabled) {
 		val = I915_READ(EDP_PSR2_CTL(dev_priv->psr.transcoder));
-- 
2.23.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-10-25  1:01 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-23 21:49 [PATCH] drm/i915/display/psr: Print in debugfs if PSR is not enabled because of sink José Roberto de Souza
2019-10-23 21:49 ` [Intel-gfx] " José Roberto de Souza
2019-10-24  2:53 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-10-24  2:53   ` [Intel-gfx] " Patchwork
2019-10-24  6:51 ` [PATCH] " Ramalingam C
2019-10-24  6:51   ` [Intel-gfx] " Ramalingam C
2019-10-25  0:50 ` ✗ Fi.CI.IGT: failure for " Patchwork
2019-10-25  0:50   ` [Intel-gfx] " Patchwork
2019-10-25  1:01   ` Souza, Jose
2019-10-25  1:01     ` [Intel-gfx] " Souza, Jose

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.