All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/5] Update VSC SDP / HDR Metadata SDP states on pipe updates.
Date: Fri, 25 Oct 2019 15:19:27 +0300	[thread overview]
Message-ID: <20191025121927.GG1208@intel.com> (raw)
In-Reply-To: <20191024182423.958952-1-gwan-gyeong.mun@intel.com>

On Thu, Oct 24, 2019 at 09:24:18PM +0300, Gwan-gyeong Mun wrote:
> It calls intel_dp_vsc_enable() and intel_dp_hdr_metadata_enable() on pipe
> updates to make sure that we enable sending of VSC SDP and HDR Metadata
> Infoframe SDP packet (when applicable) on fastsets.

I think we first need to move the stuff into the crtc state and add
real precompute+readout+state check. Then we could start thinking about
optimizing things for fastsets.

> In order to set an enabled state of VSC SDP and HDR Metadata Infoframe SDP,
> It adds intel_enable_infoframe() function to handle enabling/disabling of
> each Video DIP. And it add intel_infoframe_enabled() function to get an
> enabled state of a specific infoframe.
> 
> Gwan-gyeong Mun (5):
>   drm/i915: Add whether or not to enable an each of Video DIP
>   drm/i915: Add checking a specific Video DIP is enabled or not
>   drm/i915/dp: Stop sending of VSC SDP when it is not needed
>   drm/i915/dp: Stop sending of HDR Metadata Infoframe when it is not
>     needed
>   drm/i915/dp: Call dp_vsc_enable() / dp_hdr_metata_enable() on pipe
>     updates
> 
>  drivers/gpu/drm/i915/display/intel_ddi.c      |  2 +
>  .../drm/i915/display/intel_display_types.h    |  4 ++
>  drivers/gpu/drm/i915/display/intel_dp.c       | 20 ++++++-
>  drivers/gpu/drm/i915/display/intel_hdmi.c     | 56 +++++++++++++++++++
>  drivers/gpu/drm/i915/display/intel_hdmi.h     |  6 ++
>  5 files changed, 86 insertions(+), 2 deletions(-)
> 
> -- 
> 2.23.0

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 0/5] Update VSC SDP / HDR Metadata SDP states on pipe updates.
Date: Fri, 25 Oct 2019 15:19:27 +0300	[thread overview]
Message-ID: <20191025121927.GG1208@intel.com> (raw)
Message-ID: <20191025121927.jsBn9x3CTsMJx4vxzOXCP63yAl9jmy7mcHhukz5GXWA@z> (raw)
In-Reply-To: <20191024182423.958952-1-gwan-gyeong.mun@intel.com>

On Thu, Oct 24, 2019 at 09:24:18PM +0300, Gwan-gyeong Mun wrote:
> It calls intel_dp_vsc_enable() and intel_dp_hdr_metadata_enable() on pipe
> updates to make sure that we enable sending of VSC SDP and HDR Metadata
> Infoframe SDP packet (when applicable) on fastsets.

I think we first need to move the stuff into the crtc state and add
real precompute+readout+state check. Then we could start thinking about
optimizing things for fastsets.

> In order to set an enabled state of VSC SDP and HDR Metadata Infoframe SDP,
> It adds intel_enable_infoframe() function to handle enabling/disabling of
> each Video DIP. And it add intel_infoframe_enabled() function to get an
> enabled state of a specific infoframe.
> 
> Gwan-gyeong Mun (5):
>   drm/i915: Add whether or not to enable an each of Video DIP
>   drm/i915: Add checking a specific Video DIP is enabled or not
>   drm/i915/dp: Stop sending of VSC SDP when it is not needed
>   drm/i915/dp: Stop sending of HDR Metadata Infoframe when it is not
>     needed
>   drm/i915/dp: Call dp_vsc_enable() / dp_hdr_metata_enable() on pipe
>     updates
> 
>  drivers/gpu/drm/i915/display/intel_ddi.c      |  2 +
>  .../drm/i915/display/intel_display_types.h    |  4 ++
>  drivers/gpu/drm/i915/display/intel_dp.c       | 20 ++++++-
>  drivers/gpu/drm/i915/display/intel_hdmi.c     | 56 +++++++++++++++++++
>  drivers/gpu/drm/i915/display/intel_hdmi.h     |  6 ++
>  5 files changed, 86 insertions(+), 2 deletions(-)
> 
> -- 
> 2.23.0

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-10-25 12:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24 18:24 [PATCH 0/5] Update VSC SDP / HDR Metadata SDP states on pipe updates Gwan-gyeong Mun
2019-10-24 18:24 ` [Intel-gfx] " Gwan-gyeong Mun
2019-10-24 18:24 ` [PATCH 1/5] drm/i915: Add whether or not to enable an each of Video DIP Gwan-gyeong Mun
2019-10-24 18:24   ` [Intel-gfx] " Gwan-gyeong Mun
2019-10-24 18:24 ` [PATCH 2/5] drm/i915: Add checking a specific Video DIP is enabled or not Gwan-gyeong Mun
2019-10-24 18:24   ` [Intel-gfx] " Gwan-gyeong Mun
2019-10-24 18:24 ` [PATCH 3/5] drm/i915/dp: Stop sending of VSC SDP when it is not needed Gwan-gyeong Mun
2019-10-24 18:24   ` [Intel-gfx] " Gwan-gyeong Mun
2019-10-24 18:24 ` [PATCH 4/5] drm/i915/dp: Stop sending of HDR Metadata Infoframe " Gwan-gyeong Mun
2019-10-24 18:24   ` [Intel-gfx] " Gwan-gyeong Mun
2019-10-24 18:24 ` [PATCH 5/5] drm/i915/dp: Call dp_vsc_enable() / dp_hdr_metata_enable() on pipe updates Gwan-gyeong Mun
2019-10-24 18:24   ` [Intel-gfx] " Gwan-gyeong Mun
2019-10-24 22:08 ` ✗ Fi.CI.CHECKPATCH: warning for Update VSC SDP / HDR Metadata SDP states " Patchwork
2019-10-24 22:08   ` [Intel-gfx] " Patchwork
2019-10-24 22:37 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-10-24 22:37   ` [Intel-gfx] " Patchwork
2019-10-25 12:19 ` Ville Syrjälä [this message]
2019-10-25 12:19   ` [Intel-gfx] [PATCH 0/5] " Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191025121927.GG1208@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=gwan-gyeong.mun@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.