[PATCH] staging: ks7010: Fix unnecessary long lines

[PATCH] staging: ks7010: Fix unnecessary long lines

[Frank A. Cancio Bello]

checkpatch message: "WARNING:LONG_LINE: line over 80 characters"

Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com>
---

This is the first patch that I send for "Outreachy December 2019 to
March 2020". My plan is to keep these first patches very simple.
Once they get approved I will move to less trivial fixes ;)

 drivers/staging/ks7010/ks7010_sdio.c | 3 ++-
 drivers/staging/ks7010/ks_hostif.c   | 9 ++++++---
 drivers/staging/ks7010/ks_wlan_net.c | 3 ++-
 3 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index 4b379542ecd5..c7ba658e234e 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -446,7 +446,8 @@ static void ks_wlan_hw_rx(struct ks_wlan_private *priv, size_t size)
 				     DUMP_PREFIX_OFFSET,
 				     rx_buffer->data, 32);
 #endif
-		ret = ks7010_sdio_writeb(priv, READ_STATUS_REG, REG_STATUS_IDLE);
+		ret = ks7010_sdio_writeb(priv,
+					 READ_STATUS_REG, REG_STATUS_IDLE);
 		if (ret)
 			netdev_err(priv->net_dev, "write READ_STATUS_REG\n");
 
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index 2666f9e30c15..4206e535de5e 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -79,7 +79,8 @@ static void ks_wlan_hw_wakeup_task(struct work_struct *work)
 				&priv->psstatus.wakeup_wait,
 				msecs_to_jiffies(20));
 		if (time_left <= 0) {
-			netdev_dbg(priv->net_dev, "wake up timeout or interrupted !!!\n");
+			netdev_dbg(priv->net_dev,
+				   "wake up timeout or interrupted !!!\n");
 			schedule_work(&priv->wakeup_work);
 			return;
 		}
@@ -438,7 +439,8 @@ void hostif_data_indication(struct ks_wlan_private *priv)
 
 	/* source address check */
 	if (ether_addr_equal(&priv->eth_addr[0], eth_hdr->h_source)) {
-		netdev_err(priv->net_dev, "invalid : source is own mac address !!\n");
+		netdev_err(priv->net_dev,
+			   "invalid : source is own mac address !!\n");
 		netdev_err(priv->net_dev,
 			   "eth_hdrernet->h_dest=%02X:%02X:%02X:%02X:%02X:%02X\n",
 			   eth_hdr->h_source[0], eth_hdr->h_source[1],
@@ -1831,7 +1833,8 @@ void hostif_sme_mode_setup(struct ks_wlan_private *priv)
 			if (!is_11b_rate(priv->reg.rate_set.body[i]))
 				break;
 
-			if ((priv->reg.rate_set.body[i] & RATE_MASK) >= TX_RATE_5M) {
+			if ((priv->reg.rate_set.body[i] & RATE_MASK) >=
+			    TX_RATE_5M) {
 				rate_octet[i] = priv->reg.rate_set.body[i] &
 						RATE_MASK;
 			} else {
diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c
index 3cffc8be6656..0e1486ccb901 100644
--- a/drivers/staging/ks7010/ks_wlan_net.c
+++ b/drivers/staging/ks7010/ks_wlan_net.c
@@ -1212,7 +1212,8 @@ static inline char *ks_wlan_translate_scan(struct net_device *dev,
 		iwe.u.mode = (capabilities & WLAN_CAPABILITY_ESS) ?
 			      IW_MODE_INFRA : IW_MODE_ADHOC;
 		current_ev = iwe_stream_add_event(info, current_ev,
-						  end_buf, &iwe, IW_EV_UINT_LEN);
+						  end_buf, &iwe,
+						  IW_EV_UINT_LEN);
 	}
 
 	/* Add frequency */
-- 
2.17.1

Re: [PATCH] staging: ks7010: Fix unnecessary long lines

[Greg KH]

On Sun, Oct 27, 2019 at 03:40:56AM +0000, Frank A. Cancio Bello wrote:
> checkpatch message: "WARNING:LONG_LINE: line over 80 characters"
> 
> Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com>
> ---
> 
> This is the first patch that I send for "Outreachy December 2019 to
> March 2020". My plan is to keep these first patches very simple.
> Once they get approved I will move to less trivial fixes ;)
> 
>  drivers/staging/ks7010/ks7010_sdio.c | 3 ++-
>  drivers/staging/ks7010/ks_hostif.c   | 9 ++++++---
>  drivers/staging/ks7010/ks_wlan_net.c | 3 ++-
>  3 files changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index 4b379542ecd5..c7ba658e234e 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -446,7 +446,8 @@ static void ks_wlan_hw_rx(struct ks_wlan_private *priv, size_t size)
>  				     DUMP_PREFIX_OFFSET,
>  				     rx_buffer->data, 32);
>  #endif
> -		ret = ks7010_sdio_writeb(priv, READ_STATUS_REG, REG_STATUS_IDLE);
> +		ret = ks7010_sdio_writeb(priv,
> +					 READ_STATUS_REG, REG_STATUS_IDLE);

Why not just wrap the last parameter?  That's the normal way to do
something like this.

thanks,

greg k-h

Re: [PATCH] staging: ks7010: Fix unnecessary long lines

[Frank A. Cancio Bello]

On Sun, Oct 27, 2019 at 08:04:56AM +0100, Greg KH wrote:
> On Sun, Oct 27, 2019 at 03:40:56AM +0000, Frank A. Cancio Bello wrote:
> > checkpatch message: "WARNING:LONG_LINE: line over 80 characters"
> > 
> > Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com>
> > ---
> > 
> > This is the first patch that I send for "Outreachy December 2019 to
> > March 2020". My plan is to keep these first patches very simple.
> > Once they get approved I will move to less trivial fixes ;)
> > 
> >  drivers/staging/ks7010/ks7010_sdio.c | 3 ++-
> >  drivers/staging/ks7010/ks_hostif.c   | 9 ++++++---
> >  drivers/staging/ks7010/ks_wlan_net.c | 3 ++-
> >  3 files changed, 10 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> > index 4b379542ecd5..c7ba658e234e 100644
> > --- a/drivers/staging/ks7010/ks7010_sdio.c
> > +++ b/drivers/staging/ks7010/ks7010_sdio.c
> > @@ -446,7 +446,8 @@ static void ks_wlan_hw_rx(struct ks_wlan_private *priv, size_t size)
> >  				     DUMP_PREFIX_OFFSET,
> >  				     rx_buffer->data, 32);
> >  #endif
> > -		ret = ks7010_sdio_writeb(priv, READ_STATUS_REG, REG_STATUS_IDLE);
> > +		ret = ks7010_sdio_writeb(priv,
> > +					 READ_STATUS_REG, REG_STATUS_IDLE);
> 
> Why not just wrap the last parameter?  That's the normal way to do
> something like this.

Thanks for the suggestion. I already sent a new version of the patch.

Frank A.

>
> thanks,
> 
> greg k-h